[GitHub] [ignite] ptupitsyn commented on a change in pull request #9522: IGNITE-15807 IgniteClient with undefined port first of all connect to the default port

[GitBox <gi...@apache.org>]

ptupitsyn commented on a change in pull request #9522:
URL: https://github.com/apache/ignite/pull/9522#discussion_r738299917



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java
##########
@@ -644,7 +643,18 @@ synchronized boolean initChannelHolders() {
         if (idx != -1)
             currDfltHolder = holders.get(idx);
 
-        for (InetSocketAddress addr : allAddrs) {
+        List<InetSocketAddress> allAddrsSorted = new ArrayList<>(allAddrs);
+
+        allAddrsSorted.sort((a1, a2) -> {

Review comment:
       Not sure we should do the sorting here. We can expect the user to provide a "primary" address first, let's keep the original order.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org