You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/24 09:25:44 UTC

[GitHub] [superset] amitmiran137 opened a new pull request #13773: Feat/dashboard extra jwt

amitmiran137 opened a new pull request #13773:
URL: https://github.com/apache/superset/pull/13773


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (b9bd404) into [master](https://codecov.io/gh/apache/superset/commit/f6f412b4ae784d31b81e0753792f4762ec504f1d?el=desc) (f6f412b) will **increase** coverage by `0.94%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head b9bd404 differs from pull request most recent head 308c659. Consider uploading reports for the commit 308c659 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.38%   77.32%   +0.94%     
   ==========================================
     Files         934      936       +2     
     Lines       47393    47395       +2     
     Branches     5964     5911      -53     
   ==========================================
   + Hits        36199    36647     +448     
   + Misses      11016    10604     -412     
   + Partials      178      144      -34     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | mysql | `80.57% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.61% <85.18%> (+0.01%)` | :arrow_up: |
   | python | `80.69% <85.18%> (+<0.01%)` | :arrow_up: |
   | sqlite | `80.17% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+20.00%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (+14.60%)` | :arrow_up: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [153 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] hartatovich commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
hartatovich commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r601443804



##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -530,7 +530,10 @@ export function refreshChart(chartKey, force, dashboardId) {
     }
     dispatch(
       postChartFormData(
-        chart.latestQueryFormData,
+        {
+          ...chart.latestQueryFormData,
+          extra_jwt: dashboardInfo.extraJwt,
+        },

Review comment:
       ```suggestion
           {
             ...chart.latdfgdfgdfg
             extra_jwt: dashboardInfo.extraJwt,
           },
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r606619065



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       In this use case we would probably just have 2 separated Dashboards
   Just bc there no sense of providing dashboard to a client and show him only have of charts, that is a very bad UX don't you think ? 💆
   
   I know Air BnB   have this portion of a dashboard use case 
   But for us it just doesnt makes sense 🙅




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (d2c98ca) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `1.00%`.
   > The diff coverage is `58.15%`.
   
   > :exclamation: Current head d2c98ca differs from pull request most recent head f56bf36. Consider uploading reports for the commit f56bf36 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   75.96%   -1.01%     
   ==========================================
     Files         930      946      +16     
     Lines       46278    48483    +2205     
     Branches     5554     6137     +583     
   ==========================================
   + Hits        35619    36828    +1209     
   - Misses      10525    11505     +980     
   - Partials      134      150      +16     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.02% <43.13%> (-1.42%)` | :arrow_down: |
   | hive | `?` | |
   | mysql | `?` | |
   | postgres | `80.62% <ø> (+0.12%)` | :arrow_up: |
   | python | `80.62% <ø> (-0.26%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `48.59% <ø> (-15.79%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [345 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...f56bf36](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r606426128



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       What if you want to publish a dashboard to some users, but a subset of these users cannot have access to a couple of more sensitive charts in the dashboard? If seems by turning on the DASHBOARD_RBAC flag, there is no way to accommodate this case, unless you add some kind of dashboard level metadata to indicate this dashboard should not issue a JWT.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (6caf77e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.55%`.
   > The diff coverage is `62.57%`.
   
   > :exclamation: Current head 6caf77e differs from pull request most recent head 9a1bdf4. Consider uploading reports for the commit 9a1bdf4 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   76.41%   -0.56%     
   ==========================================
     Files         930      943      +13     
     Lines       46278    48459    +2181     
     Branches     5554     6152     +598     
   ==========================================
   + Hits        35619    37031    +1412     
   - Misses      10525    11278     +753     
   - Partials      134      150      +16     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `80.30% <90.00%> (+0.17%)` | :arrow_up: |
   | javascript | `63.71% <58.65%> (+1.21%)` | :arrow_up: |
   | mysql | `80.61% <90.00%> (+0.14%)` | :arrow_up: |
   | postgres | `80.64% <90.00%> (+0.14%)` | :arrow_up: |
   | python | `81.02% <90.00%> (+0.13%)` | :arrow_up: |
   | sqlite | `80.20% <90.00%> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.05% <ø> (-15.33%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [331 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (b9bd404) into [master](https://codecov.io/gh/apache/superset/commit/f6f412b4ae784d31b81e0753792f4762ec504f1d?el=desc) (f6f412b) will **decrease** coverage by `0.77%`.
   > The diff coverage is `82.75%`.
   
   > :exclamation: Current head b9bd404 differs from pull request most recent head 308c659. Consider uploading reports for the commit 308c659 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   78.09%   77.31%   -0.78%     
   ==========================================
     Files         934      935       +1     
     Lines       47395    47400       +5     
     Branches     5964     5948      -16     
   ==========================================
   - Hits        37014    36649     -365     
   - Misses      10237    10588     +351     
   - Partials      144      163      +19     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.24% <50.00%> (+0.20%)` | :arrow_up: |
   | javascript | `66.28% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.57% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.60% <85.18%> (+<0.01%)` | :arrow_up: |
   | python | `80.69% <85.18%> (+<0.01%)` | :arrow_up: |
   | sqlite | `80.17% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `56.43% <0.00%> (-22.18%)` | :arrow_down: |
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [54 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r606619065



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       In this use case we would probably just have 2 separated Dashboards
   Just bc there no sense of providing dashboard to a client and show him only have of charts, that is a very bad UX don't you think ? 💆
   
   I know Air BnB  have this have a dashboard use case 
   But for us it just doesnt makes sense 🙅




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (366da54) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.43%`.
   > The diff coverage is `64.89%`.
   
   > :exclamation: Current head 366da54 differs from pull request most recent head 429fa38. Consider uploading reports for the commit 429fa38 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   76.53%   -0.44%     
   ==========================================
     Files         930      936       +6     
     Lines       46278    47300    +1022     
     Branches     5554     5810     +256     
   ==========================================
   + Hits        35619    36202     +583     
   - Misses      10525    10939     +414     
   - Partials      134      159      +25     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `52.61% <40.09%> (-4.83%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.74% <59.28%> (+1.25%)` | :arrow_up: |
   | mysql | `80.61% <88.88%> (+0.14%)` | :arrow_up: |
   | postgres | `80.62% <88.88%> (+0.12%)` | :arrow_up: |
   | python | `80.67% <88.88%> (-0.22%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `46.47% <ø> (-17.91%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [341 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (34fde5c) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.21%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head 34fde5c differs from pull request most recent head 51b9e71. Consider uploading reports for the commit 51b9e71 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.33%   -0.22%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47352      +51     
     Branches     5907     5911       +4     
   ==========================================
   - Hits        36685    36622      -63     
   - Misses      10472    10586     +114     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.73% <85.18%> (-0.42%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [13 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (9a1bdf4) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.40%`.
   > The diff coverage is `71.13%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.37%   +0.40%     
   ==========================================
     Files         930      934       +4     
     Lines       46278    47144     +866     
     Branches     5554     5760     +206     
   ==========================================
   + Hits        35619    36477     +858     
   + Misses      10525    10524       -1     
   - Partials      134      143       +9     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.50% <47.36%> (-0.95%)` | :arrow_down: |
   | hive | `80.26% <85.60%> (+0.13%)` | :arrow_up: |
   | javascript | `63.39% <54.88%> (+0.90%)` | :arrow_up: |
   | mysql | `80.57% <85.22%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.60%> (+0.10%)` | :arrow_up: |
   | python | `80.98% <85.85%> (+0.09%)` | :arrow_up: |
   | sqlite | `80.16% <83.05%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
   | [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
   | ... and [279 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605894672



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       in our org every dashboard might serve different set of users which basically means a separated role per dashboard.
   so managing access for every dataset on every dashboard is a cumbersome work.
   it will require managing all datasets permissions for every role.
   this problem scale when having hundreds of dashboards.
   
   additionally, dataset permission mechanism has a defect , when changing a virtual dataset name then permission name changes as well but if it is already associated to a role you'll need to remove it and then re-associate bc permission is based on the name of the dataset and not by the id 
   
   
   
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (9a1bdf4) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `4.17%`.
   > The diff coverage is `67.20%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   72.79%   -4.18%     
   ==========================================
     Files         930      934       +4     
     Lines       46278    47110     +832     
     Branches     5554     5760     +206     
   ==========================================
   - Hits        35619    34292    -1327     
   - Misses      10525    12595    +2070     
   - Partials      134      223      +89     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | hive | `80.26% <85.60%> (+0.13%)` | :arrow_up: |
   | javascript | `63.39% <54.88%> (+0.90%)` | :arrow_up: |
   | mysql | `80.57% <85.22%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.60%> (+0.10%)` | :arrow_up: |
   | python | `80.95% <85.85%> (+0.07%)` | :arrow_up: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `49.75% <0.00%> (-28.25%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `96.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `70.00% <ø> (ø)` | |
   | ... and [483 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (34fde5c) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.23%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head 34fde5c differs from pull request most recent head 51b9e71. Consider uploading reports for the commit 51b9e71 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.32%   -0.24%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47352      +51     
     Branches     5907     5911       +4     
   ==========================================
   - Hits        36685    36613      -72     
   - Misses      10472    10595     +123     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.69% <85.18%> (-0.45%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [16 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r606619065



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       In this use case we would probably just have 2 separated Dashboards
   Just bc there no sense of providing dashboard to a client and show him only have of charts, that is a very bad UX don't you think ? 💆
   
   I know Air BnB   have this portion of a dashboard use case 
   But for us it just doesnt makes sense 🙅
   
   
   Our Dashboards are for external clients , try to explain to them why they see only half 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (9a1bdf4) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `4.19%`.
   > The diff coverage is `67.20%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   72.76%   -4.20%     
   ==========================================
     Files         930      934       +4     
     Lines       46278    47110     +832     
     Branches     5554     5760     +206     
   ==========================================
   - Hits        35619    34281    -1338     
   - Misses      10525    12606    +2081     
   - Partials      134      223      +89     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | hive | `80.26% <85.60%> (+0.13%)` | :arrow_up: |
   | javascript | `63.39% <54.88%> (+0.90%)` | :arrow_up: |
   | mysql | `?` | |
   | postgres | `80.60% <85.60%> (+0.10%)` | :arrow_up: |
   | python | `80.91% <85.85%> (+0.02%)` | :arrow_up: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `49.75% <0.00%> (-28.25%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `96.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `70.00% <ø> (ø)` | |
   | ... and [486 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (34fde5c) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **increase** coverage by `0.01%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head 34fde5c differs from pull request most recent head 51b9e71. Consider uploading reports for the commit 51b9e71 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   77.55%   77.57%   +0.01%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47352      +51     
     Branches     5907     5911       +4     
   ==========================================
   + Hits        36685    36733      +48     
   - Misses      10472    10475       +3     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.05% <100.00%> (+0.01%)` | :arrow_up: |
   | hive | `80.30% <85.18%> (+0.01%)` | :arrow_up: |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `80.31% <85.18%> (+0.01%)` | :arrow_up: |
   | python | `81.15% <85.18%> (+0.01%)` | :arrow_up: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [8 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (e04084d) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.49%`.
   > The diff coverage is `64.82%`.
   
   > :exclamation: Current head e04084d differs from pull request most recent head de11299. Consider uploading reports for the commit de11299 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.46%   +0.49%     
   ==========================================
     Files         930      935       +5     
     Lines       46278    47342    +1064     
     Branches     5554     5910     +356     
   ==========================================
   + Hits        35619    36674    +1055     
   + Misses      10525    10519       -6     
   - Partials      134      149      +15     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `63.74% <59.26%> (+1.25%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [299 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...de11299](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (15d0691) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `1.49%`.
   > The diff coverage is `61.50%`.
   
   > :exclamation: Current head 15d0691 differs from pull request most recent head ff4984f. Consider uploading reports for the commit ff4984f to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   75.47%   -1.50%     
   ==========================================
     Files         930      935       +5     
     Lines       46278    47341    +1063     
     Branches     5554     5908     +354     
   ==========================================
   + Hits        35619    35729     +110     
   - Misses      10525    11432     +907     
   - Partials      134      180      +46     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `63.74% <59.28%> (+1.25%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.62% <ø> (-1.39%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `46.47% <ø> (-17.91%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [406 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...ff4984f](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (15d0691) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `1.49%`.
   > The diff coverage is `61.50%`.
   
   > :exclamation: Current head 15d0691 differs from pull request most recent head 429fa38. Consider uploading reports for the commit 429fa38 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   75.47%   -1.50%     
   ==========================================
     Files         930      935       +5     
     Lines       46278    47341    +1063     
     Branches     5554     5908     +354     
   ==========================================
   + Hits        35619    35729     +110     
   - Misses      10525    11432     +907     
   - Partials      134      180      +46     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `63.74% <59.28%> (+1.25%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.62% <ø> (-1.39%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `46.47% <ø> (-17.91%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [406 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605135223



##########
File path: superset/views/core.py
##########
@@ -1869,6 +1875,19 @@ def dashboard(  # pylint: disable=too-many-locals
             if key not in [param.value for param in utils.ReservedUrlParameters]
         }
 
+        extra_jwt = {}
+        if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):

Review comment:
       I'm also not really clear on why the jwt is needed. Some more background info would be helpful.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 closed pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #13773:
URL: https://github.com/apache/superset/pull/13773


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (9a1bdf4) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.41%`.
   > The diff coverage is `71.06%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   76.55%   -0.42%     
   ==========================================
     Files         930      937       +7     
     Lines       46278    48050    +1772     
     Branches     5554     6028     +474     
   ==========================================
   + Hits        35619    36783    +1164     
   - Misses      10525    11124     +599     
   - Partials      134      143       +9     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.38% <47.32%> (-2.06%)` | :arrow_down: |
   | hive | `80.26% <85.60%> (+0.13%)` | :arrow_up: |
   | javascript | `63.39% <54.88%> (+0.90%)` | :arrow_up: |
   | mysql | `80.57% <85.22%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.60%> (+0.10%)` | :arrow_up: |
   | python | `80.98% <85.85%> (+0.09%)` | :arrow_up: |
   | sqlite | `80.16% <83.05%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
   | [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
   | ... and [309 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (e04084d) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.49%`.
   > The diff coverage is `64.82%`.
   
   > :exclamation: Current head e04084d differs from pull request most recent head 8ac8df0. Consider uploading reports for the commit 8ac8df0 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.46%   +0.49%     
   ==========================================
     Files         930      935       +5     
     Lines       46278    47342    +1064     
     Branches     5554     5910     +356     
   ==========================================
   + Hits        35619    36674    +1055     
   + Misses      10525    10519       -6     
   - Partials      134      149      +15     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `63.74% <59.26%> (+1.25%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [299 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...8ac8df0](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (d2c98ca) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `1.38%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head d2c98ca differs from pull request most recent head 51b9e71. Consider uploading reports for the commit 51b9e71 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.48%   76.10%   -1.39%     
   ==========================================
     Files         935      946      +11     
     Lines       47301    48511    +1210     
     Branches     5907     6137     +230     
   ==========================================
   + Hits        36653    36918     +265     
   - Misses      10504    11443     +939     
   - Partials      144      150       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.02% <100.00%> (-0.02%)` | :arrow_down: |
   | hive | `?` | |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `80.31% <85.18%> (?)` | |
   | python | `80.89% <85.18%> (-0.12%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `69.06% <100.00%> (-9.55%)` | :arrow_down: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [66 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (366da54) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.37%`.
   > The diff coverage is `64.89%`.
   
   > :exclamation: Current head 366da54 differs from pull request most recent head 429fa38. Consider uploading reports for the commit 429fa38 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.34%   +0.37%     
   ==========================================
     Files         930      936       +6     
     Lines       46278    47328    +1050     
     Branches     5554     5810     +256     
   ==========================================
   + Hits        35619    36607     +988     
   - Misses      10525    10577      +52     
   - Partials      134      144      +10     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.07% <41.50%> (-1.38%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.74% <59.28%> (+1.25%)` | :arrow_up: |
   | mysql | `80.61% <88.88%> (+0.14%)` | :arrow_up: |
   | postgres | `80.64% <88.88%> (+0.14%)` | :arrow_up: |
   | python | `80.72% <88.88%> (-0.16%)` | :arrow_down: |
   | sqlite | `80.20% <88.88%> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [301 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (d2c98ca) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `1.43%`.
   > The diff coverage is `59.40%`.
   
   > :exclamation: Current head d2c98ca differs from pull request most recent head f56bf36. Consider uploading reports for the commit f56bf36 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   75.53%   -1.44%     
   ==========================================
     Files         930      939       +9     
     Lines       46278    48059    +1781     
     Branches     5554     5982     +428     
   ==========================================
   + Hits        35619    36302     +683     
   - Misses      10525    11587    +1062     
   - Partials      134      170      +36     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `57.25% <43.60%> (-0.20%)` | :arrow_down: |
   | hive | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.62% <ø> (-1.39%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `35.51% <ø> (-28.87%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [371 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...f56bf36](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605269892



##########
File path: superset/views/core.py
##########
@@ -1869,6 +1875,19 @@ def dashboard(  # pylint: disable=too-many-locals
             if key not in [param.value for param in utils.ReservedUrlParameters]
         }
 
+        extra_jwt = {}
+        if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):

Review comment:
       I'm a little bit wary of the security implication of allowing dashboard readers to have access to charts and datasets they explicitly don't have access to.
   
   What if someone creates a dashboard with charts that use datasets they don't have access to, but add themselves to the allowed list of roles? What is the access control flow look like? Would you restrict who can change dashboard roles only to those who have admin access to the underlying datasets? Because if someone has view access to a dataset or edit access to a dashboard, it doesn't mean they can just publish this dataset or the content of this dashboard to any audience.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (51b9e71) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.06%`.
   > The diff coverage is `86.20%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.49%   -0.07%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47352      +51     
     Branches     5907     5911       +4     
   ==========================================
   + Hits        36685    36696      +11     
   - Misses      10472    10512      +40     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.03% <100.00%> (-0.01%)` | :arrow_down: |
   | hive | `80.30% <85.18%> (+0.01%)` | :arrow_up: |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `81.02% <85.18%> (-0.12%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [9 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (b9bd404) into [master](https://codecov.io/gh/apache/superset/commit/f6f412b4ae784d31b81e0753792f4762ec504f1d?el=desc) (f6f412b) will **increase** coverage by `0.00%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head b9bd404 differs from pull request most recent head 308c659. Consider uploading reports for the commit 308c659 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #13773   +/-   ##
   =======================================
     Coverage   78.34%   78.34%           
   =======================================
     Files         934      935    +1     
     Lines       47395    47401    +6     
     Branches     5964     5948   -16     
   =======================================
   + Hits        37130    37137    +7     
   + Misses      10121    10120    -1     
     Partials      144      144           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.04% <100.00%> (+<0.01%)` | :arrow_up: |
   | hive | `80.28% <85.18%> (+0.01%)` | :arrow_up: |
   | javascript | `66.28% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.57% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.60% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `80.29% <85.18%> (+0.01%)` | :arrow_up: |
   | python | `81.15% <85.18%> (+<0.01%)` | :arrow_up: |
   | sqlite | `80.17% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (51b9e71) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.27%`.
   > The diff coverage is `86.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.27%   -0.28%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47322      +21     
     Branches     5907     5907              
   ==========================================
   - Hits        36685    36569     -116     
   - Misses      10472    10609     +137     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `80.61% <85.18%> (-0.53%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [25 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (366da54) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.46%`.
   > The diff coverage is `64.89%`.
   
   > :exclamation: Current head 366da54 differs from pull request most recent head 9a1bdf4. Consider uploading reports for the commit 9a1bdf4 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.43%   +0.46%     
   ==========================================
     Files         930      936       +6     
     Lines       46278    47328    +1050     
     Branches     5554     5810     +256     
   ==========================================
   + Hits        35619    36649    +1030     
   - Misses      10525    10535      +10     
   - Partials      134      144      +10     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.07% <41.50%> (-1.38%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.74% <59.28%> (+1.25%)` | :arrow_up: |
   | mysql | `80.61% <88.88%> (+0.14%)` | :arrow_up: |
   | postgres | `80.64% <88.88%> (+0.14%)` | :arrow_up: |
   | presto | `80.31% <88.88%> (?)` | |
   | python | `80.89% <88.88%> (+<0.01%)` | :arrow_up: |
   | sqlite | `80.20% <88.88%> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [300 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r606339199



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       But you could write a query selecting dashboards the user can access which use the dataset that's being requested, no?
   
   Something akin to:
   ```
   query = query(BaseDatasource).join(Slice).join(Dashboard).filter(BaseDatasource.id == datasource.id)
   query = DashboardFilter("id", SQLAInterface(Dashboard, db.session)).apply(query)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605134110



##########
File path: superset/views/core.py
##########
@@ -1869,6 +1875,19 @@ def dashboard(  # pylint: disable=too-many-locals
             if key not in [param.value for param in utils.ReservedUrlParameters]
         }
 
+        extra_jwt = {}
+        if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):

Review comment:
       There is a project underway to make Dashboards part of a single page app. This code will only work if dashboards are accessed from this route, but in a SPA that will not necessarily be the case. If you click a link to a dashboard from the dashboards list or the homepage, the routing will be done on the frontend. Maybe this code should be moved to a separate endpoint that the frontend calls to get the jwt.
   
   (see also #13306)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (9a1bdf4) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.51%`.
   > The diff coverage is `71.06%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   76.45%   -0.52%     
   ==========================================
     Files         930      937       +7     
     Lines       46278    48050    +1772     
     Branches     5554     6028     +474     
   ==========================================
   + Hits        35619    36736    +1117     
   - Misses      10525    11171     +646     
   - Partials      134      143       +9     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.12% <47.32%> (-2.33%)` | :arrow_down: |
   | hive | `80.26% <85.60%> (+0.13%)` | :arrow_up: |
   | javascript | `63.39% <54.88%> (+0.90%)` | :arrow_up: |
   | mysql | `80.57% <85.22%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.60%> (+0.10%)` | :arrow_up: |
   | python | `80.98% <85.85%> (+0.09%)` | :arrow_up: |
   | sqlite | `80.16% <83.05%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
   | [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
   | ... and [309 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (d2c98ca) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.97%`.
   > The diff coverage is `58.15%`.
   
   > :exclamation: Current head d2c98ca differs from pull request most recent head f56bf36. Consider uploading reports for the commit f56bf36 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   75.98%   -0.98%     
   ==========================================
     Files         930      945      +15     
     Lines       46278    48458    +2180     
     Branches     5554     6137     +583     
   ==========================================
   + Hits        35619    36823    +1204     
   - Misses      10525    11485     +960     
   - Partials      134      150      +16     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.02% <43.13%> (-1.42%)` | :arrow_down: |
   | hive | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `48.59% <ø> (-15.79%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [332 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...f56bf36](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (51b9e71) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `1.06%`.
   > The diff coverage is `86.20%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   76.48%   -1.07%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47351      +50     
     Branches     5907     5911       +4     
   ==========================================
   - Hits        36685    36218     -467     
   - Misses      10472    10958     +486     
   - Partials      144      175      +31     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.73% <100.00%> (-0.31%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.73% <85.18%> (-0.42%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `66.33% <100.00%> (-12.28%)` | :arrow_down: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [70 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (b9bd404) into [master](https://codecov.io/gh/apache/superset/commit/f6f412b4ae784d31b81e0753792f4762ec504f1d?el=desc) (f6f412b) will **decrease** coverage by `0.51%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head b9bd404 differs from pull request most recent head 308c659. Consider uploading reports for the commit 308c659 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   78.09%   77.58%   -0.52%     
   ==========================================
     Files         934      947      +13     
     Lines       47395    48243     +848     
     Branches     5964     6197     +233     
   ==========================================
   + Hits        37014    37430     +416     
   - Misses      10237    10668     +431     
   - Partials      144      145       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `66.28% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.57% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.60% <85.18%> (+<0.01%)` | :arrow_up: |
   | python | `80.69% <85.18%> (+<0.01%)` | :arrow_up: |
   | sqlite | `80.17% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [29 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (34fde5c) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.95%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head 34fde5c differs from pull request most recent head 51b9e71. Consider uploading reports for the commit 51b9e71 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   76.60%   -0.96%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47351      +50     
     Branches     5907     5911       +4     
   ==========================================
   - Hits        36685    36271     -414     
   - Misses      10472    10906     +434     
   - Partials      144      174      +30     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.53% <100.00%> (-0.51%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.73% <85.18%> (-0.42%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `66.33% <100.00%> (-12.28%)` | :arrow_down: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [62 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (b9bd404) into [master](https://codecov.io/gh/apache/superset/commit/f6f412b4ae784d31b81e0753792f4762ec504f1d?el=desc) (f6f412b) will **increase** coverage by `0.00%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head b9bd404 differs from pull request most recent head 308c659. Consider uploading reports for the commit 308c659 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #13773   +/-   ##
   =======================================
     Coverage   78.25%   78.26%           
   =======================================
     Files         934      935    +1     
     Lines       47395    47401    +6     
     Branches     5964     5948   -16     
   =======================================
   + Hits        37091    37098    +7     
   + Misses      10160    10159    -1     
     Partials      144      144           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.04% <100.00%> (+<0.01%)` | :arrow_up: |
   | hive | `80.28% <85.18%> (+0.01%)` | :arrow_up: |
   | javascript | `66.28% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.57% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.60% <85.18%> (+<0.01%)` | :arrow_up: |
   | python | `80.99% <85.18%> (+<0.01%)` | :arrow_up: |
   | sqlite | `80.17% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (f56bf36) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.24%`.
   > The diff coverage is `71.08%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.21%   +0.24%     
   ==========================================
     Files         930      934       +4     
     Lines       46278    47144     +866     
     Branches     5554     5713     +159     
   ==========================================
   + Hits        35619    36403     +784     
   - Misses      10525    10598      +73     
   - Partials      134      143       +9     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.47% <47.36%> (-0.98%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.39% <54.88%> (+0.90%)` | :arrow_up: |
   | mysql | `80.57% <85.22%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.60%> (+0.10%)` | :arrow_up: |
   | python | `80.68% <85.73%> (-0.20%)` | :arrow_down: |
   | sqlite | `80.16% <83.05%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
   | [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
   | ... and [284 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...f56bf36](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r603084218



##########
File path: superset/config.py
##########
@@ -1123,6 +1123,8 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
 SQLALCHEMY_DOCS_URL = "https://docs.sqlalchemy.org/en/13/core/engines.html"
 SQLALCHEMY_DISPLAY_TEXT = "SQLAlchemy docs"
 
+DASHBOARD_JWT_SECRET = "my secret key replace me"

Review comment:
       I'd rather leave this `None` and then raise if it hasn't been defined.

##########
File path: superset/security/manager.py
##########
@@ -987,15 +988,24 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+            data_source_allowed_in_dashboard = (
+                datasource.id in dashboard_data_context.dataset_ids
+            )
             if not (
-                self.can_access_schema(datasource)
+                data_source_allowed_in_dashboard
+                or self.can_access_schema(datasource)

Review comment:
       I'd rewrite this to make sure there's no way the new logic can leak into the current flow without the FF. Something like
   ```python
   data_source_allowed_in_dashboard = False
   if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
       dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
       data_source_allowed_in_dashboard = (
           datasource.id in dashboard_data_context.dataset_ids
       )
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (f56bf36) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `3.72%`.
   > The diff coverage is `85.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   80.68%   +3.72%     
   ==========================================
     Files         930      314     -616     
     Lines       46278    25199   -21079     
     Branches     5554        0    -5554     
   ==========================================
   - Hits        35619    20333   -15286     
   + Misses      10525     4866    -5659     
   + Partials      134        0     -134     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.57% <85.22%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.60%> (+0.10%)` | :arrow_up: |
   | python | `80.68% <85.73%> (-0.20%)` | :arrow_down: |
   | sqlite | `80.16% <83.05%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `81.99% <ø> (ø)` | |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `62.43% <ø> (ø)` | |
   | [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.44% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `97.46% <ø> (ø)` | |
   | [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
   | [superset/utils/data.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0YS5weQ==) | `27.94% <27.94%> (ø)` | |
   | [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `33.33% <33.33%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.10% <33.33%> (-0.01%)` | :arrow_down: |
   | [superset/views/api.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `71.42% <50.00%> (+0.51%)` | :arrow_up: |
   | ... and [576 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...f56bf36](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (366da54) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.36%`.
   > The diff coverage is `64.89%`.
   
   > :exclamation: Current head 366da54 differs from pull request most recent head 429fa38. Consider uploading reports for the commit 429fa38 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.33%   +0.36%     
   ==========================================
     Files         930      936       +6     
     Lines       46278    47300    +1022     
     Branches     5554     5810     +256     
   ==========================================
   + Hits        35619    36580     +961     
   - Misses      10525    10576      +51     
   - Partials      134      144      +10     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.07% <41.50%> (-1.38%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.74% <59.28%> (+1.25%)` | :arrow_up: |
   | mysql | `80.61% <88.88%> (+0.14%)` | :arrow_up: |
   | postgres | `80.62% <88.88%> (+0.12%)` | :arrow_up: |
   | python | `80.71% <88.88%> (-0.18%)` | :arrow_down: |
   | sqlite | `80.20% <88.88%> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [305 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (f56bf36) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `5.98%`.
   > The diff coverage is `65.11%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   70.97%   -5.99%     
   ==========================================
     Files         930      849      -81     
     Lines       46278    42069    -4209     
     Branches     5554     4396    -1158     
   ==========================================
   - Hits        35619    29860    -5759     
   - Misses      10525    12209    +1684     
   + Partials      134        0     -134     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.47% <47.36%> (-0.98%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.57% <85.22%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.60%> (+0.10%)` | :arrow_up: |
   | python | `80.68% <85.73%> (-0.20%)` | :arrow_down: |
   | sqlite | `80.16% <83.05%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `23.46% <0.00%> (-39.57%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `5.68% <0.00%> (-62.54%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.09% <0.00%> (-3.74%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `5.88% <ø> (-82.49%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...rc/common/hooks/useChangeEffect/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QvdXNlQ2hhbmdlRWZmZWN0LnRz) | `100.00% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `92.00% <ø> (ø)` | |
   | [...rontend/src/components/AsyncEsmComponent/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNFc21Db21wb25lbnQvaW5kZXgudHN4) | `76.47% <ø> (ø)` | |
   | ... and [705 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...f56bf36](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (9a1bdf4) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.52%`.
   > The diff coverage is `71.06%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   76.44%   -0.53%     
   ==========================================
     Files         930      942      +12     
     Lines       46278    48380    +2102     
     Branches     5554     6137     +583     
   ==========================================
   + Hits        35619    36983    +1364     
   - Misses      10525    11254     +729     
   - Partials      134      143       +9     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `55.49% <47.32%> (-1.95%)` | :arrow_down: |
   | hive | `80.26% <85.60%> (+0.13%)` | :arrow_up: |
   | javascript | `63.39% <54.88%> (+0.90%)` | :arrow_up: |
   | mysql | `80.57% <85.22%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.60%> (+0.10%)` | :arrow_up: |
   | python | `80.98% <85.85%> (+0.09%)` | :arrow_up: |
   | sqlite | `80.16% <83.05%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
   | [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
   | ... and [316 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (429fa38) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `3.72%`.
   > The diff coverage is `85.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   80.68%   +3.72%     
   ==========================================
     Files         930      314     -616     
     Lines       46278    25199   -21079     
     Branches     5554        0    -5554     
   ==========================================
   - Hits        35619    20333   -15286     
   + Misses      10525     4866    -5659     
   + Partials      134        0     -134     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.57% <85.14%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.53%> (+0.10%)` | :arrow_up: |
   | python | `80.68% <85.65%> (-0.20%)` | :arrow_down: |
   | sqlite | `80.16% <82.97%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `81.99% <ø> (ø)` | |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `62.43% <ø> (ø)` | |
   | [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.44% <ø> (ø)` | |
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `97.46% <ø> (ø)` | |
   | [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
   | [superset/utils/data.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0YS5weQ==) | `27.94% <27.94%> (ø)` | |
   | [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `33.33% <33.33%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.10% <33.33%> (-0.01%)` | :arrow_down: |
   | [superset/views/api.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `71.42% <50.00%> (+0.51%)` | :arrow_up: |
   | ... and [576 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605134110



##########
File path: superset/views/core.py
##########
@@ -1869,6 +1875,19 @@ def dashboard(  # pylint: disable=too-many-locals
             if key not in [param.value for param in utils.ReservedUrlParameters]
         }
 
+        extra_jwt = {}
+        if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):

Review comment:
       There is a project underway to make Dashboards part of a single page app. This code will only work if dashboards are accessed from this route, but in a SPA that will not necessarily be the case. If you click a link to a dashboard from the dashboards list or the homepage, the routing will be done on the frontend. Maybe there should be a separate endpoint that the frontend calls to get the jwt.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (b9bd404) into [master](https://codecov.io/gh/apache/superset/commit/f6f412b4ae784d31b81e0753792f4762ec504f1d?el=desc) (f6f412b) will **increase** coverage by `0.00%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head b9bd404 differs from pull request most recent head 308c659. Consider uploading reports for the commit 308c659 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #13773   +/-   ##
   =======================================
     Coverage   78.09%   78.09%           
   =======================================
     Files         934      935    +1     
     Lines       47395    47401    +6     
     Branches     5964     5948   -16     
   =======================================
   + Hits        37014    37020    +6     
     Misses      10237    10237           
     Partials      144      144           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.04% <100.00%> (-0.01%)` | :arrow_down: |
   | javascript | `66.28% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.57% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.60% <85.18%> (+<0.01%)` | :arrow_up: |
   | python | `80.69% <85.18%> (+<0.01%)` | :arrow_up: |
   | sqlite | `80.17% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (6caf77e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.24%`.
   > The diff coverage is `64.39%`.
   
   > :exclamation: Current head 6caf77e differs from pull request most recent head 9a1bdf4. Consider uploading reports for the commit 9a1bdf4 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.20%   +0.24%     
   ==========================================
     Files         930      935       +5     
     Lines       46278    47162     +884     
     Branches     5554     5760     +206     
   ==========================================
   + Hits        35619    36413     +794     
   - Misses      10525    10606      +81     
   - Partials      134      143       +9     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `80.61% <90.00%> (+0.14%)` | :arrow_up: |
   | postgres | `80.62% <90.00%> (+0.12%)` | :arrow_up: |
   | python | `80.67% <90.00%> (-0.22%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [321 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (429fa38) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `7.69%`.
   > The diff coverage is `64.32%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   69.27%   -7.70%     
   ==========================================
     Files         930      849      -81     
     Lines       46278    42069    -4209     
     Branches     5554     4396    -1158     
   ==========================================
   - Hits        35619    29144    -6475     
   - Misses      10525    12925    +2400     
   + Partials      134        0     -134     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `52.22% <46.05%> (-5.22%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.57% <85.14%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.53%> (+0.10%)` | :arrow_up: |
   | python | `80.68% <85.65%> (-0.20%)` | :arrow_down: |
   | sqlite | `80.16% <82.97%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `18.16% <0.00%> (-44.88%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `5.68% <0.00%> (-62.54%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.09% <0.00%> (-3.74%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `5.88% <ø> (-82.49%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `31.57% <0.00%> (-18.43%)` | :arrow_down: |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `90.90% <ø> (-9.10%)` | :arrow_down: |
   | [...rc/common/hooks/useChangeEffect/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QvdXNlQ2hhbmdlRWZmZWN0LnRz) | `100.00% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `84.00% <ø> (ø)` | |
   | ... and [720 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (6caf77e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.70%`.
   > The diff coverage is `62.57%`.
   
   > :exclamation: Current head 6caf77e differs from pull request most recent head 9a1bdf4. Consider uploading reports for the commit 9a1bdf4 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   76.26%   -0.71%     
   ==========================================
     Files         930      943      +13     
     Lines       46278    48459    +2181     
     Branches     5554     6152     +598     
   ==========================================
   + Hits        35619    36957    +1338     
   - Misses      10525    11352     +827     
   - Partials      134      150      +16     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | javascript | `63.71% <58.65%> (+1.21%)` | :arrow_up: |
   | mysql | `80.61% <90.00%> (+0.14%)` | :arrow_up: |
   | postgres | `80.64% <90.00%> (+0.14%)` | :arrow_up: |
   | python | `80.72% <90.00%> (-0.16%)` | :arrow_down: |
   | sqlite | `80.20% <90.00%> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.05% <ø> (-15.33%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [333 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (d2c98ca) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.97%`.
   > The diff coverage is `58.15%`.
   
   > :exclamation: Current head d2c98ca differs from pull request most recent head f56bf36. Consider uploading reports for the commit f56bf36 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   75.99%   -0.98%     
   ==========================================
     Files         930      946      +16     
     Lines       46278    48511    +2233     
     Branches     5554     6137     +583     
   ==========================================
   + Hits        35619    36867    +1248     
   - Misses      10525    11494     +969     
   - Partials      134      150      +16     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.02% <43.13%> (-1.42%)` | :arrow_down: |
   | hive | `?` | |
   | mysql | `80.61% <ø> (+0.15%)` | :arrow_up: |
   | postgres | `80.64% <ø> (+0.14%)` | :arrow_up: |
   | python | `80.69% <ø> (-0.20%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `48.59% <ø> (-15.79%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [341 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...f56bf36](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (34fde5c) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.03%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head 34fde5c differs from pull request most recent head 308c659. Consider uploading reports for the commit 308c659 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.54%   77.57%   +1.03%     
   ==========================================
     Files         934      936       +2     
     Lines       47393    47352      -41     
     Branches     5964     5911      -53     
   ==========================================
   + Hits        36276    36733     +457     
   + Misses      10939    10475     -464     
   + Partials      178      144      -34     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.05% <100.00%> (+7.68%)` | :arrow_up: |
   | hive | `80.30% <85.18%> (+0.03%)` | :arrow_up: |
   | javascript | `63.72% <25.00%> (-2.57%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+0.04%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+0.04%)` | :arrow_up: |
   | presto | `80.31% <85.18%> (?)` | |
   | python | `81.15% <85.18%> (+0.17%)` | :arrow_up: |
   | sqlite | `80.20% <85.18%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+20.00%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (+14.60%)` | :arrow_up: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [169 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (51b9e71) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.21%`.
   > The diff coverage is `86.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.34%   -0.22%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47350      +49     
     Branches     5907     5907              
   ==========================================
   - Hits        36685    36621      -64     
   - Misses      10472    10585     +113     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.73% <85.18%> (-0.42%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [13 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (366da54) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `1.38%`.
   > The diff coverage is `63.12%`.
   
   > :exclamation: Current head 366da54 differs from pull request most recent head 429fa38. Consider uploading reports for the commit 429fa38 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   75.58%   -1.39%     
   ==========================================
     Files         930      942      +12     
     Lines       46278    48373    +2095     
     Branches     5554     6065     +511     
   ==========================================
   + Hits        35619    36563     +944     
   - Misses      10525    11640    +1115     
   - Partials      134      170      +36     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `63.74% <59.28%> (+1.25%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `33.96% <ø> (-30.43%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [364 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (d2c98ca) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.95%`.
   > The diff coverage is `58.15%`.
   
   > :exclamation: Current head d2c98ca differs from pull request most recent head f56bf36. Consider uploading reports for the commit f56bf36 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   76.01%   -0.96%     
   ==========================================
     Files         930      946      +16     
     Lines       46278    48511    +2233     
     Branches     5554     6137     +583     
   ==========================================
   + Hits        35619    36876    +1257     
   - Misses      10525    11485     +960     
   - Partials      134      150      +16     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.02% <43.13%> (-1.42%)` | :arrow_down: |
   | hive | `?` | |
   | mysql | `80.61% <ø> (+0.15%)` | :arrow_up: |
   | postgres | `80.64% <ø> (+0.14%)` | :arrow_up: |
   | python | `80.73% <ø> (-0.16%)` | :arrow_down: |
   | sqlite | `80.20% <ø> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `48.59% <ø> (-15.79%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [339 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...f56bf36](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (f56bf36) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `8.62%`.
   > The diff coverage is `59.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   68.34%   -8.63%     
   ==========================================
     Files         930      840      -90     
     Lines       46278    41638    -4640     
     Branches     5554     4251    -1303     
   ==========================================
   - Hits        35619    28456    -7163     
   - Misses      10525    13182    +2657     
   + Partials      134        0     -134     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `49.41% <36.03%> (-8.04%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.57% <85.22%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.60%> (+0.10%)` | :arrow_up: |
   | python | `80.68% <85.73%> (-0.20%)` | :arrow_down: |
   | sqlite | `80.16% <83.05%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `18.16% <0.00%> (-44.88%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `5.68% <0.00%> (-62.54%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.09% <0.00%> (-3.74%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `5.88% <ø> (-82.49%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `31.57% <0.00%> (-18.43%)` | :arrow_down: |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...rc/common/hooks/useChangeEffect/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QvdXNlQ2hhbmdlRWZmZWN0LnRz) | `0.00% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `92.00% <ø> (ø)` | |
   | ... and [715 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...f56bf36](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r606032514



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       > I would be happy to do a follow up PR just to support SPA , no worries there
   
   In the SPA project we have already done the work to remove dashboard-specific bootstrap data so that the apps can be cleanly merged. I think rather than adding new bootstrap properties at this stage, it would be better to use an endpoint. That said, if you're okay with this feature breaking in the very near future, I won't stand in your way. The compatibility discussion is a relatively minor issue.
   
   I think the security concerns have already been discussed somewhat in [SIP-51](https://github.com/apache/superset/issues/10408). Anyone using the feature flag should understand that dashboard owners have the ability to grant data access to others arbitrarily. These effects should be well documented. It's an entirely different security profile for the application.
   
   I am of the opinion that the security manager should make a database query to find the information it needs, rather than using this new JWT pattern. I haven't seen anything that indicates that a JWT is actually required here, though I could be mistaken.
   
   Introducing new authorization patterns specific to a given feature flag will make it more difficult to onboard into the Superset codebase, as well as making it more complicated to change system behavior. The JWT pattern also makes it complicated to revoke or change a user's access, and introduces a new responsibility for the client to correctly manage the JWT.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (429fa38) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `7.04%`.
   > The diff coverage is `64.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   69.91%   -7.05%     
   ==========================================
     Files         930      850      -80     
     Lines       46278    43312    -2966     
     Branches     5554     4396    -1158     
   ==========================================
   - Hits        35619    30283    -5336     
   - Misses      10525    13029    +2504     
   + Partials      134        0     -134     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `52.22% <46.05%> (-5.22%)` | :arrow_down: |
   | hive | `80.55% <85.83%> (+0.41%)` | :arrow_up: |
   | javascript | `?` | |
   | mysql | `80.57% <85.14%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.53%> (+0.10%)` | :arrow_up: |
   | python | `81.20% <86.09%> (+0.31%)` | :arrow_up: |
   | sqlite | `80.16% <82.97%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `18.16% <0.00%> (-44.88%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `5.68% <0.00%> (-62.54%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.09% <0.00%> (-3.74%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `5.88% <ø> (-82.49%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `31.57% <0.00%> (-18.43%)` | :arrow_down: |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `90.90% <ø> (-9.10%)` | :arrow_down: |
   | [...rc/common/hooks/useChangeEffect/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QvdXNlQ2hhbmdlRWZmZWN0LnRz) | `100.00% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `84.00% <ø> (ø)` | |
   | ... and [723 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605874085



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       Could you elaborate more on why you need users without direct access to certain datasets to have access to that dataset through dashboards? Can you just create virtual datasets and grant them read access to the dataset instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (366da54) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.46%`.
   > The diff coverage is `64.89%`.
   
   > :exclamation: Current head 366da54 differs from pull request most recent head 429fa38. Consider uploading reports for the commit 429fa38 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.43%   +0.46%     
   ==========================================
     Files         930      936       +6     
     Lines       46278    47328    +1050     
     Branches     5554     5810     +256     
   ==========================================
   + Hits        35619    36649    +1030     
   - Misses      10525    10535      +10     
   - Partials      134      144      +10     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.07% <41.50%> (-1.38%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.74% <59.28%> (+1.25%)` | :arrow_up: |
   | mysql | `80.61% <88.88%> (+0.14%)` | :arrow_up: |
   | postgres | `80.64% <88.88%> (+0.14%)` | :arrow_up: |
   | presto | `80.31% <88.88%> (?)` | |
   | python | `80.89% <88.88%> (+<0.01%)` | :arrow_up: |
   | sqlite | `80.20% <88.88%> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [300 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-812352096


   Adding another important statement here about the final JWT lifecycle:
   1. The jwt will be consumed from the dashboard frontend component by calling dashboard API and one of the properties inside will be the extra_jwt ( similar to fetching it from the bootstrap data RIP 😜)
   
   2. the jwt is then passed on every chart data request within the form data back to the backend
   
   3. upon raise_for_access existing validation in addition to permission of dataset/schema   
   The jwt is being parsed and questioned either a dataset permission exist within 
   
   P.S
   in any other  chart data API call no jwt will exist therfore only dataset/schema permission mechanism applies
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (429fa38) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `7.51%`.
   > The diff coverage is `64.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   69.45%   -7.52%     
   ==========================================
     Files         930      849      -81     
     Lines       46278    42069    -4209     
     Branches     5554     4396    -1158     
   ==========================================
   - Hits        35619    29219    -6400     
   - Misses      10525    12850    +2325     
   + Partials      134        0     -134     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `52.22% <46.05%> (-5.22%)` | :arrow_down: |
   | hive | `80.26% <85.53%> (+0.13%)` | :arrow_up: |
   | javascript | `?` | |
   | mysql | `80.57% <85.14%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.53%> (+0.10%)` | :arrow_up: |
   | python | `80.98% <85.78%> (+0.09%)` | :arrow_up: |
   | sqlite | `80.16% <82.97%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `18.16% <0.00%> (-44.88%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `5.68% <0.00%> (-62.54%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.09% <0.00%> (-3.74%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `5.88% <ø> (-82.49%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `31.57% <0.00%> (-18.43%)` | :arrow_down: |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `90.90% <ø> (-9.10%)` | :arrow_down: |
   | [...rc/common/hooks/useChangeEffect/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QvdXNlQ2hhbmdlRWZmZWN0LnRz) | `100.00% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `84.00% <ø> (ø)` | |
   | ... and [715 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (6caf77e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.25%`.
   > The diff coverage is `64.39%`.
   
   > :exclamation: Current head 6caf77e differs from pull request most recent head 9a1bdf4. Consider uploading reports for the commit 9a1bdf4 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.21%   +0.25%     
   ==========================================
     Files         930      935       +5     
     Lines       46278    47190     +912     
     Branches     5554     5760     +206     
   ==========================================
   + Hits        35619    36440     +821     
   - Misses      10525    10607      +82     
   - Partials      134      143       +9     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `80.61% <90.00%> (+0.14%)` | :arrow_up: |
   | postgres | `80.64% <90.00%> (+0.14%)` | :arrow_up: |
   | python | `80.69% <90.00%> (-0.20%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [317 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (b9bd404) into [master](https://codecov.io/gh/apache/superset/commit/f6f412b4ae784d31b81e0753792f4762ec504f1d?el=desc) (f6f412b) will **decrease** coverage by `0.15%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head b9bd404 differs from pull request most recent head 308c659. Consider uploading reports for the commit 308c659 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   78.25%   78.10%   -0.16%     
   ==========================================
     Files         934      935       +1     
     Lines       47395    47401       +6     
     Branches     5964     5948      -16     
   ==========================================
   - Hits        37091    37021      -70     
   - Misses      10160    10236      +76     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.04% <100.00%> (+<0.01%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `66.28% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.57% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.60% <85.18%> (+<0.01%)` | :arrow_up: |
   | python | `80.69% <85.18%> (-0.30%)` | :arrow_down: |
   | sqlite | `80.17% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [13 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (34fde5c) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.28%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head 34fde5c differs from pull request most recent head 51b9e71. Consider uploading reports for the commit 51b9e71 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.27%   -0.29%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47324      +23     
     Branches     5907     5911       +4     
   ==========================================
   - Hits        36685    36570     -115     
   - Misses      10472    10610     +138     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `80.61% <85.18%> (-0.53%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [25 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605229870



##########
File path: superset/views/core.py
##########
@@ -1869,6 +1875,19 @@ def dashboard(  # pylint: disable=too-many-locals
             if key not in [param.value for param in utils.ReservedUrlParameters]
         }
 
+        extra_jwt = {}
+        if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):

Review comment:
       I'm expecting to have a PR up that removes dashboard as a standalone app this week, so I think compatibility is an important consideration now.
   
   What about adding logic to the security of the chart data and dataset endpoints, to check whether access should be granted at the time of request? Is that an option? Sorry if I'm missing something, I'd just like to fully understand the need for this JWT pattern. Is the time limit for access a feature requirement or an implementation detail?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (7047e7c) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.49%`.
   > The diff coverage is `64.82%`.
   
   > :exclamation: Current head 7047e7c differs from pull request most recent head de11299. Consider uploading reports for the commit de11299 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.46%   +0.49%     
   ==========================================
     Files         930      935       +5     
     Lines       46278    47342    +1064     
     Branches     5554     5910     +356     
   ==========================================
   + Hits        35619    36674    +1055     
   + Misses      10525    10519       -6     
   - Partials      134      149      +15     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `63.74% <59.26%> (+1.25%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [299 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...de11299](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605350358



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       @ktmud @suddjian  upon each chart data query request (legacy or v1 API) this part is being called of validating from extracting the  signed jwt if that dataset is being called from a queryContext /Viz  
   
   Only dashboard owner/admin an give dashboard access (see the video)
   
   Let's assume that daahboard access is being granted to a read only persona 
   
   And to that persona  explore chart permission is not granted as well
   
   So that type of a user can only see data under the dashboard
   He cannot edit the dataset or play around with it in the explore
   In theory he could use that jwt to query the dataset freely in SQLlab(if he permission to sqllab to begin with) 
   
   From a dashboard point of view is up to the dashboard creator to wrap data with the relevant datasets(either physical or virtual) that will restrict the readonly personas to what is relevant for them
   
   If there is a huge physical dataset that might expose sensitive data then you can always have a thiner portion of it by creating a virtual one 
   
   
   How would you suggest make that flow secure?
   
   
   
   -------------
   @suddjian I would be happy to do a follow up PR just to support SPA , no worries there 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (6caf77e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.27%`.
   > The diff coverage is `64.39%`.
   
   > :exclamation: Current head 6caf77e differs from pull request most recent head 9a1bdf4. Consider uploading reports for the commit 9a1bdf4 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.23%   +0.27%     
   ==========================================
     Files         930      935       +5     
     Lines       46278    47190     +912     
     Branches     5554     5760     +206     
   ==========================================
   + Hits        35619    36449     +830     
   - Misses      10525    10598      +73     
   - Partials      134      143       +9     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `80.61% <90.00%> (+0.14%)` | :arrow_up: |
   | postgres | `80.64% <90.00%> (+0.14%)` | :arrow_up: |
   | python | `80.72% <90.00%> (-0.16%)` | :arrow_down: |
   | sqlite | `80.20% <90.00%> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [315 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (308c659) into [master](https://codecov.io/gh/apache/superset/commit/f6f412b4ae784d31b81e0753792f4762ec504f1d?el=desc) (f6f412b) will **increase** coverage by `0.68%`.
   > The diff coverage is `86.20%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.35%   77.04%   +0.68%     
   ==========================================
     Files         934      936       +2     
     Lines       47393    47368      -25     
     Branches     5964     5911      -53     
   ==========================================
   + Hits        36189    36494     +305     
   + Misses      11026    10730     -296     
   + Partials      178      144      -34     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | postgres | `?` | |
   | python | `80.17% <85.18%> (-0.47%)` | :arrow_down: |
   | sqlite | `80.17% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+20.00%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (+14.60%)` | :arrow_up: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `81.81% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [178 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r607190697



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       I'd say even your external clients may have people with different access levels. Maybe not now, but it's possible. 
   
   Sometimes you want a single dashboard for all audience because it's easier to navigate and easier to communicate---you can share the same short link to all users and executives don't have to jump between two dashboards just to see the more sensitive data. You may also have two duplicate dashboards with 80% of the content the same, but it'd gradually become difficult to maintain.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r606090146



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       The jwt and it's data indicates that the request indeed coming from the Dashboard and with the nessecery dataset permission.
   
   Otherwise upon chart data request it would be impossible to know if the request does originates from a dashboard or not  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-815035467


   closing this one and opened a simpler solution here: https://github.com/apache/superset/pull/13992


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r607422877



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       Maybe we need a "nested dashboard" viz plugin 😁 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605212876



##########
File path: superset/views/core.py
##########
@@ -1869,6 +1875,19 @@ def dashboard(  # pylint: disable=too-many-locals
             if key not in [param.value for param in utils.ReservedUrlParameters]
         }
 
+        extra_jwt = {}
+        if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):

Review comment:
       I'm totally aware of SPA project and I plan to also support and implement the dashboard jwt feature under that as well
   
   But for now until SPA maturity I want to to be supported in the old style




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (15d0691) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `1.49%`.
   > The diff coverage is `61.50%`.
   
   > :exclamation: Current head 15d0691 differs from pull request most recent head 8c05a48. Consider uploading reports for the commit 8c05a48 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   75.47%   -1.50%     
   ==========================================
     Files         930      935       +5     
     Lines       46278    47341    +1063     
     Branches     5554     5908     +354     
   ==========================================
   + Hits        35619    35729     +110     
   - Misses      10525    11432     +907     
   - Partials      134      180      +46     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `63.74% <59.28%> (+1.25%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.62% <ø> (-1.39%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `46.47% <ø> (-17.91%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [406 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...8c05a48](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (9a1bdf4) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `4.16%`.
   > The diff coverage is `67.20%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   72.80%   -4.17%     
   ==========================================
     Files         930      934       +4     
     Lines       46278    47110     +832     
     Branches     5554     5760     +206     
   ==========================================
   - Hits        35619    34299    -1320     
   - Misses      10525    12588    +2063     
   - Partials      134      223      +89     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | hive | `80.26% <85.60%> (+0.13%)` | :arrow_up: |
   | javascript | `63.39% <54.88%> (+0.90%)` | :arrow_up: |
   | mysql | `80.57% <85.22%> (+0.11%)` | :arrow_up: |
   | postgres | `80.60% <85.60%> (+0.10%)` | :arrow_up: |
   | python | `80.98% <85.85%> (+0.09%)` | :arrow_up: |
   | sqlite | `80.16% <83.05%> (+0.04%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `49.75% <0.00%> (-28.25%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `96.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `70.00% <ø> (ø)` | |
   | ... and [480 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (51b9e71) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.21%`.
   > The diff coverage is `86.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.34%   -0.22%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47350      +49     
     Branches     5907     5907              
   ==========================================
   - Hits        36685    36621      -64     
   - Misses      10472    10585     +113     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.73% <85.18%> (-0.42%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [13 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (b9bd404) into [master](https://codecov.io/gh/apache/superset/commit/f6f412b4ae784d31b81e0753792f4762ec504f1d?el=desc) (f6f412b) will **decrease** coverage by `0.77%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head b9bd404 differs from pull request most recent head 308c659. Consider uploading reports for the commit 308c659 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   78.09%   77.32%   -0.78%     
   ==========================================
     Files         934      936       +2     
     Lines       47395    47395              
     Branches     5964     5911      -53     
   ==========================================
   - Hits        37014    36647     -367     
   - Misses      10237    10604     +367     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | mysql | `80.57% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.60% <85.18%> (+<0.01%)` | :arrow_up: |
   | python | `80.69% <85.18%> (+<0.01%)` | :arrow_up: |
   | sqlite | `80.17% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [50 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (d2c98ca) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.86%`.
   > The diff coverage is `58.15%`.
   
   > :exclamation: Current head d2c98ca differs from pull request most recent head f56bf36. Consider uploading reports for the commit f56bf36 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   76.10%   -0.87%     
   ==========================================
     Files         930      946      +16     
     Lines       46278    48511    +2233     
     Branches     5554     6137     +583     
   ==========================================
   + Hits        35619    36918    +1299     
   - Misses      10525    11443     +918     
   - Partials      134      150      +16     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.02% <43.13%> (-1.42%)` | :arrow_down: |
   | hive | `?` | |
   | mysql | `80.61% <ø> (+0.15%)` | :arrow_up: |
   | postgres | `80.64% <ø> (+0.14%)` | :arrow_up: |
   | presto | `80.31% <ø> (?)` | |
   | python | `80.89% <ø> (+<0.01%)` | :arrow_up: |
   | sqlite | `80.20% <ø> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `48.59% <ø> (-15.79%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [338 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...f56bf36](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (366da54) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `1.57%`.
   > The diff coverage is `63.12%`.
   
   > :exclamation: Current head 366da54 differs from pull request most recent head 429fa38. Consider uploading reports for the commit 429fa38 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   75.39%   -1.58%     
   ==========================================
     Files         930      943      +13     
     Lines       46278    48391    +2113     
     Branches     5554     6065     +511     
   ==========================================
   + Hits        35619    36483     +864     
   - Misses      10525    11738    +1213     
   - Partials      134      170      +36     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | javascript | `63.74% <59.28%> (+1.25%)` | :arrow_up: |
   | mysql | `80.61% <88.88%> (+0.14%)` | :arrow_up: |
   | postgres | `?` | |
   | python | `80.61% <88.88%> (-0.28%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `33.96% <ø> (-30.43%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [376 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (51b9e71) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.26%`.
   > The diff coverage is `86.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.29%   -0.27%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47322      +21     
     Branches     5907     5907              
   ==========================================
   - Hits        36685    36578     -107     
   - Misses      10472    10600     +128     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `?` | |
   | presto | `?` | |
   | python | `80.64% <85.18%> (-0.50%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [22 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (34fde5c) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.05%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head 34fde5c differs from pull request most recent head 51b9e71. Consider uploading reports for the commit 51b9e71 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.50%   -0.06%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47352      +51     
     Branches     5907     5911       +4     
   ==========================================
   + Hits        36685    36699      +14     
   - Misses      10472    10509      +37     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.05% <100.00%> (+0.01%)` | :arrow_up: |
   | hive | `80.30% <85.18%> (+0.01%)` | :arrow_up: |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `81.02% <85.18%> (-0.12%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [10 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (34fde5c) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.06%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head 34fde5c differs from pull request most recent head 51b9e71. Consider uploading reports for the commit 51b9e71 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.49%   -0.07%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47352      +51     
     Branches     5907     5911       +4     
   ==========================================
   + Hits        36685    36696      +11     
   - Misses      10472    10512      +40     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | presto | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [9 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (34fde5c) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.24%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head 34fde5c differs from pull request most recent head 51b9e71. Consider uploading reports for the commit 51b9e71 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.30%   -0.25%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47324      +23     
     Branches     5907     5911       +4     
   ==========================================
   - Hits        36685    36586      -99     
   - Misses      10472    10594     +122     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.62% <85.18%> (-0.01%)` | :arrow_down: |
   | presto | `?` | |
   | python | `80.67% <85.18%> (-0.47%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [22 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (6caf77e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.20%`.
   > The diff coverage is `64.39%`.
   
   > :exclamation: Current head 6caf77e differs from pull request most recent head 9a1bdf4. Consider uploading reports for the commit 9a1bdf4 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.17%   +0.20%     
   ==========================================
     Files         930      935       +5     
     Lines       46278    47162     +884     
     Branches     5554     5760     +206     
   ==========================================
   + Hits        35619    36397     +778     
   - Misses      10525    10622      +97     
   - Partials      134      143       +9     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `80.61% <90.00%> (+0.14%)` | :arrow_up: |
   | postgres | `?` | |
   | python | `80.61% <90.00%> (-0.28%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [323 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...9a1bdf4](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (51b9e71) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.31%`.
   > The diff coverage is `85.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.24%   -0.32%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47416     +115     
     Branches     5907     5932      +25     
   ==========================================
   - Hits        36685    36625      -60     
   - Misses      10472    10642     +170     
   - Partials      144      149       +5     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.73% <85.18%> (-0.42%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.21% <50.00%> (-0.39%)` | :arrow_down: |
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `50.00% <100.00%> (-34.27%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [13 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (6caf77e) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.55%`.
   > The diff coverage is `62.57%`.
   
   > :exclamation: Current head 6caf77e differs from pull request most recent head f56bf36. Consider uploading reports for the commit f56bf36 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   76.41%   -0.56%     
   ==========================================
     Files         930      943      +13     
     Lines       46278    48459    +2181     
     Branches     5554     6152     +598     
   ==========================================
   + Hits        35619    37031    +1412     
   - Misses      10525    11278     +753     
   - Partials      134      150      +16     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `80.30% <90.00%> (+0.17%)` | :arrow_up: |
   | javascript | `63.71% <58.65%> (+1.21%)` | :arrow_up: |
   | mysql | `80.61% <90.00%> (+0.14%)` | :arrow_up: |
   | postgres | `80.64% <90.00%> (+0.14%)` | :arrow_up: |
   | python | `81.02% <90.00%> (+0.13%)` | :arrow_up: |
   | sqlite | `80.20% <90.00%> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.05% <ø> (-15.33%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [331 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...f56bf36](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605894672



##########
File path: superset/security/manager.py
##########
@@ -987,15 +989,28 @@ def raise_for_access(  # pylint: disable=too-many-arguments,too-many-branches
                 )
 
         if datasource or query_context or viz:
+            extra_jwt = None
             if query_context:
                 datasource = query_context.datasource
+                extra_jwt = query_context.extra_jwt
             elif viz:
                 datasource = viz.datasource
+                extra_jwt = viz.extra_jwt
 
             assert datasource
 
+            ds_allowed_in_dashboard = False
+            if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):
+                dashboard_data_context = dashboard_jwt_manager.parse_jwt(extra_jwt)
+
+                if dashboard_data_context:
+                    ds_allowed_in_dashboard = (
+                        datasource.id in dashboard_data_context.dataset_ids
+                    )
+
             if not (
-                self.can_access_schema(datasource)
+                ds_allowed_in_dashboard

Review comment:
       in our org every dashboard might serve different set of users which basically means a separated role per dashboard.
   so managing access for every dataset on every dashboard is a cumbersome work.
   it will require managing all datasets permissions for every role.
   this problem scale when having hundreds of dashboards.
   
   additionally, dataset permission mechanism has a defect , when changing a virtual dataset name then permission name changes as well but if it is already associated to a role you'll need to remove it and then remove and re-associate bc permission is based on the name of the dataset and not by the id 
   
   
   
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (b9bd404) into [master](https://codecov.io/gh/apache/superset/commit/f6f412b4ae784d31b81e0753792f4762ec504f1d?el=desc) (f6f412b) will **increase** coverage by `0.94%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head b9bd404 differs from pull request most recent head 308c659. Consider uploading reports for the commit 308c659 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.35%   77.30%   +0.94%     
   ==========================================
     Files         934      936       +2     
     Lines       47393    47395       +2     
     Branches     5964     5911      -53     
   ==========================================
   + Hits        36189    36637     +448     
   + Misses      11026    10614     -412     
   + Partials      178      144      -34     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | postgres | `80.61% <85.18%> (+0.01%)` | :arrow_up: |
   | python | `80.65% <85.18%> (+<0.01%)` | :arrow_up: |
   | sqlite | `80.17% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+20.00%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (+14.60%)` | :arrow_up: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [153 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [f6f412b...308c659](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (34fde5c) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.21%`.
   > The diff coverage is `86.20%`.
   
   > :exclamation: Current head 34fde5c differs from pull request most recent head 51b9e71. Consider uploading reports for the commit 51b9e71 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.34%   -0.22%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47352      +51     
     Branches     5907     5911       +4     
   ==========================================
   - Hits        36685    36625      -60     
   - Misses      10472    10583     +111     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.05% <100.00%> (+0.01%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.73% <85.18%> (-0.42%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [14 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (e04084d) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **increase** coverage by `0.49%`.
   > The diff coverage is `64.82%`.
   
   > :exclamation: Current head e04084d differs from pull request most recent head ff4984f. Consider uploading reports for the commit ff4984f to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   + Coverage   76.96%   77.46%   +0.49%     
   ==========================================
     Files         930      935       +5     
     Lines       46278    47342    +1064     
     Branches     5554     5910     +356     
   ==========================================
   + Hits        35619    36674    +1055     
   + Misses      10525    10519       -6     
   - Partials      134      149      +15     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `63.74% <59.26%> (+1.25%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [299 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...ff4984f](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (51b9e71) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.21%`.
   > The diff coverage is `86.20%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   77.55%   77.33%   -0.22%     
   ==========================================
     Files         935      936       +1     
     Lines       47301    47352      +51     
     Branches     5907     5911       +4     
   ==========================================
   - Hits        36685    36622      -63     
   - Misses      10472    10586     +114     
     Partials      144      144              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.03% <100.00%> (-0.01%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.72% <25.00%> (-0.01%)` | :arrow_down: |
   | mysql | `80.61% <85.18%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.64% <85.18%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.73% <85.18%> (-0.42%)` | :arrow_down: |
   | sqlite | `80.20% <85.18%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <70.00%> (-0.62%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.09% <83.33%> (-0.09%)` | :arrow_down: |
   | [superset/utils/dashboard\_jwt\_manager.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2p3dF9tYW5hZ2VyLnB5) | `84.00% <84.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.71% <100.00%> (+0.10%)` | :arrow_up: |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `100.00% <100.00%> (ø)` | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `84.26% <100.00%> (ø)` | |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.35% <100.00%> (+0.19%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.33% <100.00%> (+0.18%)` | :arrow_up: |
   | ... and [13 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [9d6832d...51b9e71](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (ff4984f) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `3.73%`.
   > The diff coverage is `61.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   73.22%   -3.74%     
   ==========================================
     Files         930      620     -310     
     Lines       46278    21945   -24333     
     Branches     5554     5713     +159     
   ==========================================
   - Hits        35619    16070   -19549     
   + Misses      10525     5732    -4793     
   - Partials      134      143       +9     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.50% <47.36%> (-0.94%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.39% <54.88%> (+0.90%)` | :arrow_up: |
   | mysql | `?` | |
   | postgres | `?` | |
   | python | `?` | |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `90.32% <ø> (ø)` | |
   | [...end/src/dashboard/components/StickyVerticalBar.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1N0aWNreVZlcnRpY2FsQmFyLnRzeA==) | `100.00% <ø> (ø)` | |
   | ... and [454 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...ff4984f](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605210362



##########
File path: superset/views/core.py
##########
@@ -1869,6 +1875,19 @@ def dashboard(  # pylint: disable=too-many-locals
             if key not in [param.value for param in utils.ReservedUrlParameters]
         }
 
+        extra_jwt = {}
+        if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):

Review comment:
       Ok so the jwt is being used to manage read data access of charts that exists on a dashboard implicitly just by having a access to the dashboard
   
   This really upgrade the dashboard access RBAC mechanism by also giving Temporary access to datasets that are being used within the dash lard without the need to explicitly giving permission to those datasets
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13773:
URL: https://github.com/apache/superset/pull/13773#issuecomment-809384651


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=h1) Report
   > Merging [#13773](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=desc) (366da54) into [master](https://codecov.io/gh/apache/superset/commit/375797f6496e0098f145bb4a4ca8282418c8db89?el=desc) (375797f) will **decrease** coverage by `0.46%`.
   > The diff coverage is `64.89%`.
   
   > :exclamation: Current head 366da54 differs from pull request most recent head 429fa38. Consider uploading reports for the commit 429fa38 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13773/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13773      +/-   ##
   ==========================================
   - Coverage   76.96%   76.50%   -0.47%     
   ==========================================
     Files         930      936       +6     
     Lines       46278    47300    +1022     
     Branches     5554     5810     +256     
   ==========================================
   + Hits        35619    36186     +567     
   - Misses      10525    10955     +430     
   - Partials      134      159      +25     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `52.61% <40.09%> (-4.83%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `63.74% <59.28%> (+1.25%)` | :arrow_up: |
   | mysql | `80.61% <88.88%> (+0.14%)` | :arrow_up: |
   | postgres | `?` | |
   | python | `80.61% <88.88%> (-0.28%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `56.01% <ø> (ø)` | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `88.37% <ø> (ø)` | |
   | [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `46.47% <ø> (-17.91%)` | :arrow_down: |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [superset-frontend/src/components/Badge/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQmFkZ2UvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `54.54% <0.00%> (-5.46%)` | :arrow_down: |
   | ... and [343 more](https://codecov.io/gh/apache/superset/pull/13773/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=footer). Last update [b21d2cf...429fa38](https://codecov.io/gh/apache/superset/pull/13773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605134110



##########
File path: superset/views/core.py
##########
@@ -1869,6 +1875,19 @@ def dashboard(  # pylint: disable=too-many-locals
             if key not in [param.value for param in utils.ReservedUrlParameters]
         }
 
+        extra_jwt = {}
+        if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):

Review comment:
       There is a project underway to make Dashboards part of a single page app. This code will only work if dashboards are accessed from this route, but in a SPA that will not necessarily be the case. If you click a link to a dashboard from the dashboards list or the homepage, the routing will be done on the frontend. Maybe this code should be moved to a separate endpoint that the frontend calls to get the jwt.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org