[jira] [Commented] (WICKET-4964) Rename Component#renderHead(HtmlHeaderContainer)

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549711#comment-13549711 ] 

Martin Grigorov commented on WICKET-4964:
-----------------------------------------

It would be even clearer if the method name starts with internal**().
                
> Rename Component#renderHead(HtmlHeaderContainer)
> ------------------------------------------------
>
>                 Key: WICKET-4964
>                 URL: https://issues.apache.org/jira/browse/WICKET-4964
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.4.0
>            Reporter: Carl-Eric Menzel
>            Priority: Minor
>             Fix For: 7.0
>
>
> It seems it happens somewhat often that users mistakenly override renderHead(HtmlHeaderContainer) rather than renderHead(IHeaderResponse). Code completion makes this a very easy mistake.
> I propose renaming the somewhat-internal method renderHead(HtmlHeaderContainer) to renderIntoPageHeaderContainer or something like that. We can't just make the method package private, since it is needed by Panel, Border and FormComponentPanel to render the header sections of their associated markup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira