[GitHub] [logging-log4cxx] rm5248 commented on pull request #62: GZCompressAction: leave file uncompressed if fork of gzip fails

[GitBox <gi...@apache.org>]

rm5248 commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-921343014


   > Sorry; been busy. Yes, @rm5248, if I use a configuration like the example in LOGCXX-523, logging appears to continue. That approach results in a more complex configuration (2x the number of appenders) and the failure behavior isn't as graceful.
   > 
   > Since the specific conditions where fork() is likely to fail are pretty well understood and the appropriate behavior in the context of GZCompressAction is pretty straightforward, I think I'll stick with the approach in this PR in my own local builds of log4cxx. Perhaps it's not good enough for upstream -- that's fine. :)
   
   Thanks for the input.  Unfortunately, the code as it exists today is somewhat resistant to changing the current behavior, and really needs better error handling in general(but that's a major change).
   
   I think what you have provided is good in certain circumstances, so I haven't closed this for that reason.  I've been thinking about adding in what you have as a configuration option, but I really want to get better error handling working first before changing the default behavior.
   
   For reference, this has spawned 3 issues:
   https://issues.apache.org/jira/browse/LOGCXX-523
   https://issues.apache.org/jira/browse/LOGCXX-524
   https://issues.apache.org/jira/browse/LOGCXX-525
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org