You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/03/06 00:42:16 UTC
[Impala-ASF-CR] Fix code coverage argument to bin/run-all-tests.sh
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12673
Change subject: Fix code coverage argument to bin/run-all-tests.sh
......................................................................
Fix code coverage argument to bin/run-all-tests.sh
The run-all-tests.sh "-c" argument was accidentally changed
to expect an argument (i.e. getopts "c:"). Change it back to
take no argument.
Change-Id: I0244cae9f67b184c931616c58c42c62cabeb0627
---
M bin/run-all-tests.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/12673/1
--
To view, visit http://gerrit.cloudera.org:8080/12673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0244cae9f67b184c931616c58c42c62cabeb0627
Gerrit-Change-Number: 12673
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Fix code coverage argument to bin/run-all-tests.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12673 )
Change subject: Fix code coverage argument to bin/run-all-tests.sh
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3879/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/12673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0244cae9f67b184c931616c58c42c62cabeb0627
Gerrit-Change-Number: 12673
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 00:52:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix code coverage argument to bin/run-all-tests.sh
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12673 )
Change subject: Fix code coverage argument to bin/run-all-tests.sh
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0244cae9f67b184c931616c58c42c62cabeb0627
Gerrit-Change-Number: 12673
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 00:50:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix code coverage argument to bin/run-all-tests.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12673 )
Change subject: Fix code coverage argument to bin/run-all-tests.sh
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0244cae9f67b184c931616c58c42c62cabeb0627
Gerrit-Change-Number: 12673
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 04:56:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix code coverage argument to bin/run-all-tests.sh
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12673 )
Change subject: Fix code coverage argument to bin/run-all-tests.sh
......................................................................
Fix code coverage argument to bin/run-all-tests.sh
The run-all-tests.sh "-c" argument was accidentally changed
to expect an argument (i.e. getopts "c:"). Change it back to
take no argument.
Change-Id: I0244cae9f67b184c931616c58c42c62cabeb0627
Reviewed-on: http://gerrit.cloudera.org:8080/12673
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-all-tests.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Philip Zeyliger: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0244cae9f67b184c931616c58c42c62cabeb0627
Gerrit-Change-Number: 12673
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] Fix code coverage argument to bin/run-all-tests.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12673 )
Change subject: Fix code coverage argument to bin/run-all-tests.sh
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2365/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0244cae9f67b184c931616c58c42c62cabeb0627
Gerrit-Change-Number: 12673
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 01:11:52 +0000
Gerrit-HasComments: No