You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metron.apache.org by ottobackwards <gi...@git.apache.org> on 2017/04/07 00:05:21 UTC

[GitHub] incubator-metron issue #516: METRON-830 Adding StringFunctions to Stellar - ...

Github user ottobackwards commented on the issue:

    https://github.com/apache/incubator-metron/pull/516
  
    Thanks for the contribution!
    
    Quick review, first thing please follow the style guide for naming classes.  You can see from the other stellar function classes.
    
    It would be good to have some tests that aren't with string or null, to verify the behavior.
    
    What happens if I pass in a number literal?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---