You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/01/22 15:12:44 UTC

[GitHub] flink pull request #5334: [FLINK-8471] [flip6] Introduce configuration switc...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5334

    [FLINK-8471] [flip6] Introduce configuration switch for Flip-6

    ## What is the purpose of the change
    
    Add `mode` configuration parameter which enables and disables the Flip-6
    code paths. Per default this is set to the old code path.
    
    This PR is based on #5321.
    
    ## Brief change log
    
    - Introduce `mode` configuration parameter with values `flip6` and `old`.
    - Updated `config.md`
    - Changed `CustomCommandLine` instantiation in `CliFrontend` to respect `mode` configuration parameter
    - Changed `YarnClusterDescriptor` instantiation in `FlinkYarnSessionCli` to respect `mode` configuration parameter
    - Adapted start-up scripts `start-cluster.sh`, `stop-cluster.sh`, `taskmanager.sh` and `jobmanager.sh`
    - Merged Flip-6 and old Mesos start-up scripts into one: `mesos-appmaster-flip6-job.sh` -> `mesos-appmaster-job.sh`, `mesos-appmaster-flip6-session.sh` -> `mesos-appmaster-session.sh` and `mesos-taskmanager-flip6.sh` -> `mesos-taskmanager.sh`
    
    ## Verifying this change
    
    This change is already covered by existing tests and I tested it manually.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink flip6ConfigurationSwitch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5334
    
----
commit aacf28506b855d515dc16a92edc814811ad050e5
Author: Till Rohrmann <tr...@...>
Date:   2018-01-19T21:18:35Z

    [FLINK-8465] [flip6] Retrieve correct leader component address in ClusterClient
    
    Rename ClusterClient#getJobManagerAddress into #getClusterConnectionInfo. The
    returned LeaderConnectionInfo contains the address of the leading cluster
    component. In the old code this is the JobManager whereas in Flip-6 it is the
    Dispatcher.

commit e84e90e2ea25502408040461bf732ec27d6c526f
Author: Till Rohrmann <tr...@...>
Date:   2018-01-19T22:08:24Z

    [FLINK-8471] [flip6] Introduce configuration switch for Flip-6
    
    Add 'mode' configuration parameter which enables and disables the Flip-6
    code paths. Per default this is set to the old code path.

commit 1f8007efcb6cec666554aafbfe2be9c232455e96
Author: Till Rohrmann <tr...@...>
Date:   2018-01-22T15:05:47Z

    Merge Flip-6 and old Mesos start up scripts into one

----


---

[GitHub] flink pull request #5334: [FLINK-8471] [flip6] Introduce configuration switc...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5334


---

[GitHub] flink issue #5334: [FLINK-8471] [flip6] Introduce configuration switch for F...

Posted by GJL <gi...@git.apache.org>.

Github user GJL commented on the issue:

    https://github.com/apache/flink/pull/5334
  
    I have a usability concern.
    It's possible to run
    ```
    FLINK_MODE=flip6 bin/start-cluster.sh
    ```
    This will start a cluster in flilp6 mode.
    
    However,
    ```
    FLINK_MODE=flip6 bin/flink list
    ```
    won't work.
    
    If the first way is not intended, then it doesn't matter.


---

[GitHub] flink issue #5334: [FLINK-8471] [flip6] Introduce configuration switch for F...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5334
  
    Thanks for the review @GJL. The former is not an intended feature but we can guard against it by overwriting `FLINK_MODE`. I'll change it and then merge the PR.


---