You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/04 17:20:31 UTC

[GitHub] [flink] MartijnVisser opened a new pull request, #19642: [hotfix] Ignore Hugo Module files

MartijnVisser opened a new pull request, #19642:
URL: https://github.com/apache/flink/pull/19642

   ## What is the purpose of the change
   
   * Make sure that Hugo Modules files (which can be created while working on the current `master` branch) will be ignored when working with the currently support `release-1.15` and `release-1.14` branches
   
   ## Brief change log
   
   * Updated .gitignore
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #19642: [hotfix] Ignore Hugo Module files

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19642:
URL: https://github.com/apache/flink/pull/19642#issuecomment-1118255775

   > maybe remove leading slash (because it's a bit weird even if it works...)
   
   We also have those in for other ignores in the `docs` folder:
   
   ```
   /docs/api
   /docs/.bundle
   /docs/.rubydeps
   /docs/ruby2/.bundle
   /docs/ruby2/.rubydeps
   /docs/.jekyll-metadata
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser merged pull request #19642: [hotfix] Ignore Hugo Module files

Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #19642:
URL: https://github.com/apache/flink/pull/19642


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #19642: [hotfix] Ignore Hugo Module files

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19642:
URL: https://github.com/apache/flink/pull/19642#issuecomment-1118258460

   > I saw that; it's still weird :P
   
   OK, fixed them all in one go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #19642: [hotfix] Ignore Hugo Module files

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19642:
URL: https://github.com/apache/flink/pull/19642#issuecomment-1118256037

   I saw that; it's still weird :P


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19642: [hotfix] Ignore Hugo Module files

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19642:
URL: https://github.com/apache/flink/pull/19642#issuecomment-1117612746

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1497c41d25520ec11e9207e7dadd92c9adcea19f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1497c41d25520ec11e9207e7dadd92c9adcea19f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1497c41d25520ec11e9207e7dadd92c9adcea19f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org