You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Guanghao Zhang (JIRA)" <ji...@apache.org> on 2016/10/20 06:51:58 UTC
[jira] [Comment Edited] (HBASE-16870) Add the metrics of
replication sources which were transformed from other dead rs to
ReplicationLoad
[ https://issues.apache.org/jira/browse/HBASE-16870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591010#comment-15591010 ]
Guanghao Zhang edited comment on HBASE-16870 at 10/20/16 6:51 AM:
------------------------------------------------------------------
The Hadoop QA result for HBASE-16870-v1.patch seems not right. TestReplicationSmallTests failed in unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/4107/artifact/patchprocess/patch-unit-hbase-server.txt. But the Tests matrix didn't show it......
was (Author: zghaobac):
The Hadoop QA result for HBASE-16870-v1.patch seems not region. TestReplicationSmallTests failed in unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/4107/artifact/patchprocess/patch-unit-hbase-server.txt. But the Tests matrix didn't show it......
> Add the metrics of replication sources which were transformed from other dead rs to ReplicationLoad
> ---------------------------------------------------------------------------------------------------
>
> Key: HBASE-16870
> URL: https://issues.apache.org/jira/browse/HBASE-16870
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-16870-ADDENDUM.patch, HBASE-16870-branch-1.1.patch, HBASE-16870-branch-1.3.patch, HBASE-16870-branch-1.patch, HBASE-16870-v1.patch, HBASE-16870.patch
>
>
> {code}
> private void buildReplicationLoad() {
> // get source
> List<ReplicationSourceInterface> sources = this.replicationManager.getSources();
> List<MetricsSource> sourceMetricsList = new ArrayList<MetricsSource>();
> for (ReplicationSourceInterface source : sources) {
> if (source instanceof ReplicationSource) {
> sourceMetricsList.add(((ReplicationSource) source).getSourceMetrics());
> }
> }
> // get sink
> MetricsSink sinkMetrics = this.replicationSink.getSinkMetrics();
> this.replicationLoad.buildReplicationLoad(sourceMetricsList, sinkMetrics);
> }
> {code}
> The buildReplicationLoad method in o.a.h.h.r.r.Replication didn't consider the replication source which were transformed from other died rs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)