You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2014/11/21 01:15:40 UTC
[GitHub] couchdb-fauxton pull request: Nightwatch test to test lookahead co...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/160
Nightwatch test to test lookahead component
Hi @michellephung, mind taking a glance at this test when you get a second? Lowering it beneath a 5 second pause makes it fail.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton lookahead-tray-nightwatch-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit 031e66cc8954bcdb157a2a5f69cd3f38af5602cf
Author: Benjamin Keen <be...@gmail.com>
Date: 2014-11-21T00:10:29Z
Nightwatch test to test lookahead component
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Nightwatch test to test lookahead co...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: [WIP] Nightwatch test to test lookah...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/160#issuecomment-64005081
Ahhhh, that was it! Thanks @michellephung. You or Robert mentioned that - but I assumed it was for actual hidden/not visible DOM elements - not just obscured ones. Neat.
I'd like to see a "x" on all notification messages so they could be closed manually. I find they can get in the way of the nav header and I get frustrated waiting for it to disappear. This would be handy for the tests too... maybe I'll create a ticket for it.
And great tips! I'll update the code. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: [WIP] Nightwatch test to test lookah...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/160#issuecomment-64229463
@michellephung, all fixed. I also added a `closeNotification()` helper function. Seems like it'll be handy going forward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Nightwatch test to test lookahead co...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/160#issuecomment-64243336
+1
good call on the .closeNotification() command!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Nightwatch test to test lookahead co...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/160#issuecomment-64246281
Merged as 155d898
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: [WIP] Nightwatch test to test lookah...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/160#issuecomment-64123588
Hey @michellephung, the "x" in the global notifications is now merged into master. But on further examination I'm not sure the header getting obscured that was the original cause: I'm just using a plain `url()` to redirect after creating the dbs - the header shouldn't be involved at any point. Let's discuss tomorrow!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: [WIP] Nightwatch test to test lookah...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/160#issuecomment-63933602
Finally found it. I'm so sorry.
The clickable part is hidden behind the 'You are now logged in.' banner.
In loginToGUI.js, I used a jQuery injection to dismiss the modal (line 13), but I left out a line.
The solution is to add
> .waitForElementVisible("#global-notifications", 8000, false)
before the jQuery injection (to line 13, in loginToGUI.js). With this change, your test passes without the 5-second pause.
I can add this tomorrow.
It will let me use a .click() event instead of an using .execute() on the page in one of my other tests, so I'm excited.
However, it did remind me about the concerns about injecting javascript into the page. As I was testing the script, I wondered if having .execute('$(button).click();') functions in the tests would be a bad example for future coders. We would have to wait an extra 5 seconds on every test unless we bring back the 'close modal' button.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: [WIP] Nightwatch test to test lookah...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/160#issuecomment-63937497
Also:
1. The first database you deleted/created happens by default with the global beforeEach/afterEach in helpers.js. (Sort of, as I have it reversed right now. Still debating whether we are going with deleteDB-test-createDB or createDB-test-deleteDB, I like the latter, but I'd also like you to weigh in about which order works better.)
2. You may want to use .deleteDatabase(secondDatabaseName) at the end of the test to clean up the second db.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---