You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/19 03:08:08 UTC
[GitHub] [pulsar] lordcheng10 opened a new pull request, #18100: [improve][broker] modify the default value of loadBalancerLoadPlacementStrategy to LeastResourceUsageWithWeight
lordcheng10 opened a new pull request, #18100:
URL: https://github.com/apache/pulsar/pull/18100
### Motivation
The default value of loadBalancerLoadSheddingStrategy is ThresholdShedder, but the default value of loadBalancerLoadPlacementStrategy is LeastLongTermMessageRate.
In order to match the default value of loadBalancerLoadSheddingStrategy and loadBalancerLoadPlacementStrategy, modify the default value of loadBalancerLoadPlacementStrategy to LeastResourceUsageWithWeight:
```
private String loadBalancerLoadPlacementStrategy =
"org.apache.pulsar.broker.loadbalance.impl.LeastResourceUsageWithWeight";
```
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #18100: [improve][broker] modify the default value of loadBalancerLoadPlacementStrategy to LeastResourceUsageWithWeight
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #18100:
URL: https://github.com/apache/pulsar/pull/18100#discussion_r998956982
##########
conf/broker.conf:
##########
@@ -1281,8 +1281,8 @@ defaultNamespaceBundleSplitAlgorithm=range_equally_divide
# load shedding strategy, support OverloadShedder and ThresholdShedder, default is ThresholdShedder since 2.10.0
loadBalancerLoadSheddingStrategy=org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder
-# load balance placement strategy, support LeastLongTermMessageRate and LeastResourceUsageWithWeight
-loadBalancerLoadPlacementStrategy=org.apache.pulsar.broker.loadbalance.impl.LeastLongTermMessageRate
+# load balance placement strategy, support LeastLongTermMessageRate and LeastLongTermMessageRate
Review Comment:
yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #18100: [improve][broker] modify the default value of loadBalancerLoadPlacementStrategy to LeastResourceUsageWithWeight
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #18100:
URL: https://github.com/apache/pulsar/pull/18100#issuecomment-1320751071
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #18100: [improve][broker] modify the default value of loadBalancerLoadPlacementStrategy to LeastResourceUsageWithWeight
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #18100:
URL: https://github.com/apache/pulsar/pull/18100#discussion_r999207389
##########
conf/broker.conf:
##########
@@ -1281,8 +1281,8 @@ defaultNamespaceBundleSplitAlgorithm=range_equally_divide
# load shedding strategy, support OverloadShedder and ThresholdShedder, default is ThresholdShedder since 2.10.0
loadBalancerLoadSheddingStrategy=org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder
-# load balance placement strategy, support LeastLongTermMessageRate and LeastResourceUsageWithWeight
-loadBalancerLoadPlacementStrategy=org.apache.pulsar.broker.loadbalance.impl.LeastLongTermMessageRate
+# load balance placement strategy, support LeastLongTermMessageRate and LeastLongTermMessageRate
Review Comment:
OK , I will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on a diff in pull request #18100: [improve][broker] modify the default value of loadBalancerLoadPlacementStrategy to LeastResourceUsageWithWeight
Posted by GitBox <gi...@apache.org>.
HQebupt commented on code in PR #18100:
URL: https://github.com/apache/pulsar/pull/18100#discussion_r998910445
##########
conf/broker.conf:
##########
@@ -1281,8 +1281,8 @@ defaultNamespaceBundleSplitAlgorithm=range_equally_divide
# load shedding strategy, support OverloadShedder and ThresholdShedder, default is ThresholdShedder since 2.10.0
loadBalancerLoadSheddingStrategy=org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder
-# load balance placement strategy, support LeastLongTermMessageRate and LeastResourceUsageWithWeight
-loadBalancerLoadPlacementStrategy=org.apache.pulsar.broker.loadbalance.impl.LeastLongTermMessageRate
+# load balance placement strategy, support LeastLongTermMessageRate and LeastLongTermMessageRate
Review Comment:
This line needs to keep the same as the original
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org