You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by JunHe77 <gi...@git.apache.org> on 2018/10/03 15:44:29 UTC

[GitHub] bigtop pull request #401: BIGTOP-3088: provisioner failed to run puppet depl...

GitHub user JunHe77 opened a pull request:

    https://github.com/apache/bigtop/pull/401

    BIGTOP-3088: provisioner failed to run puppet deployment on CentOS-7

    Deploy with puppet on centos-7 failed.
    The root cause is puppet-stdlib (4.25) in distro is not compatible with
    puppet <4. Pin stdlib to 4.12.0 should fix this problem.
    
    Change-Id: I8ec557412b660cc51399da3c81014b47aa366d6a
    Signed-off-by: Jun He <ju...@linaro.org>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JunHe77/bigtop BIGTOP-3088

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bigtop/pull/401.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #401
    
----
commit bafa153d404fec04bfae3d600905f6f740bd5d3e
Author: Jun He <ju...@...>
Date:   2018-10-03T12:00:02Z

    BIGTOP-3088: provisioner failed to run puppet deployment on CentOS-7
    
    Deploy with puppet on centos-7 failed.
    The root cause is puppet-stdlib (4.25) in distro is not compatible with
    puppet <4. Pin stdlib to 4.12.0 should fix this problem.
    
    Change-Id: I8ec557412b660cc51399da3c81014b47aa366d6a
    Signed-off-by: Jun He <ju...@linaro.org>

----


---

[GitHub] bigtop issue #401: BIGTOP-3088: provisioner failed to run puppet deployment ...

Posted by JunHe77 <gi...@git.apache.org>.
Github user JunHe77 commented on the issue:

    https://github.com/apache/bigtop/pull/401
  
    Close this as it has been merged by upstream.


---

[GitHub] bigtop pull request #401: BIGTOP-3088: provisioner failed to run puppet depl...

Posted by JunHe77 <gi...@git.apache.org>.
Github user JunHe77 closed the pull request at:

    https://github.com/apache/bigtop/pull/401


---

[GitHub] bigtop pull request #401: BIGTOP-3088: provisioner failed to run puppet depl...

Posted by evans-ye <gi...@git.apache.org>.
Github user evans-ye commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/401#discussion_r222415905
  
    --- Diff: bigtop_toolchain/bin/puppetize.sh ---
    @@ -40,7 +40,9 @@ case ${ID}-${VERSION_ID} in
             ;;
         centos-7*)
             rpm -ivh https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm
    -        yum -y install hostname curl sudo unzip wget puppet puppetlabs-stdlib
    +        yum updateinfo
    +        yum -y install hostname curl sudo unzip wget puppet
    +        puppet module install puppetlabs-stdlib --version 4.12.0
    --- End diff --
    
    Mind to add a comment here to link to BIGTOP-3088? 
    This tells future developer that this line is for special case and can be removed if obstacle removed.


---

[GitHub] bigtop pull request #401: BIGTOP-3088: provisioner failed to run puppet depl...

Posted by JunHe77 <gi...@git.apache.org>.
Github user JunHe77 commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/401#discussion_r222516374
  
    --- Diff: bigtop_toolchain/bin/puppetize.sh ---
    @@ -40,7 +40,9 @@ case ${ID}-${VERSION_ID} in
             ;;
         centos-7*)
             rpm -ivh https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm
    -        yum -y install hostname curl sudo unzip wget puppet puppetlabs-stdlib
    +        yum updateinfo
    +        yum -y install hostname curl sudo unzip wget puppet
    +        puppet module install puppetlabs-stdlib --version 4.12.0
    --- End diff --
    
    Thanks. The suggestion reaaly helps. I used to run into similar case without knowing the code block's context.
    Will update soon.


---