You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Martin Hauner <ha...@web.de> on 2003/06/22 15:25:48 UTC
[PATCH] issue #787: Wildcards not expanded in filename arguments
on Windows.
Hi,
here is a small patch for #787, so the * wilcard works without cygwin.
--------------------------------------------------------------------------
Fix issue #787: Wildcards not expanded in filename arguments on Windows.
* build/generator/gen_win.py
(get_win_libs): added support of * wildcard expansion on Windows by
adding setargv.obj as linker input for the svn command line client.
--
Martin
Re: [PATCH] issue #787: Wildcards not expanded in filename arguments on Windows.
Posted by Russell Yanofsky <re...@columbia.edu>.
Branko Cibej wrote:
> Martin Hauner wrote:
>> ...
>> * build/generator/gen_win.py
>> (get_win_libs): added support of * wildcard expansion on
>> Windows by adding setargv.obj as linker input for the svn
>> command line client.
>
> I disagree with this change. The problem is that globbing can't be
> turned off now. On Unix, the shell does the globbing, and correct
> quoting will turn it off.
The caller can "turn off" globbing by simply not putting wildcard characters on
the subversion command line. The question mark and asterisk don't appear in
windows filenames or in subversion commands and options so there is no
ambiguity.
- Russ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] issue #787: Wildcards not expanded in filename arguments
on Windows.
Posted by Branko Čibej <br...@xbc.nu>.
Martin Hauner wrote:
> Hi,
>
> here is a small patch for #787, so the * wilcard works without cygwin.
>
> --------------------------------------------------------------------------
>
>
> Fix issue #787: Wildcards not expanded in filename arguments on Windows.
>
> * build/generator/gen_win.py
> (get_win_libs): added support of * wildcard expansion on Windows by
> adding setargv.obj as linker input for the svn command line client.
I disagree with this change. The problem is that globbing can't be
turned off now. On Unix, the shell does the globbing, and correct
quoting will turn it off.
We need a better solution that will be useful on both Unix and Windows.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org