You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Xuefu Zhang <xz...@cloudera.com> on 2014/03/30 20:27:54 UTC

Review Request 19830: HIVE-6694: Beeline should provide a way to execute shell command as Hive CLI does

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19830/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-6694
    https://issues.apache.org/jira/browse/HIVE-6694


Repository: hive-git


Description
-------

Introduce the new requested feature.


Diffs
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java 5773109 
  beeline/src/java/org/apache/hive/beeline/Commands.java 493f963 
  beeline/src/main/resources/BeeLine.properties 697c29a 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 32d367a 
  itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 741cc47 
  itests/util/pom.xml e9720df 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 25dbde9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 429f6f2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 326654f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 55ce0fc 

Diff: https://reviews.apache.org/r/19830/diff/


Testing
-------

New test cases are added. 


Thanks,

Xuefu Zhang

Re: Review Request 19830: HIVE-6694: Beeline should provide a way to execute shell command as Hive CLI does

Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19830/
-----------------------------------------------------------

(Updated June 18, 2014, 5:34 a.m.)


Review request for hive.


Bugs: HIVE-6694
    https://issues.apache.org/jira/browse/HIVE-6694


Repository: hive-git


Description
-------

Introduce the new requested feature.


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java dcdd6f2 
  beeline/src/java/org/apache/hive/beeline/Commands.java 94f74d2 
  beeline/src/main/resources/BeeLine.properties 697c29a 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 3357414 
  common/src/java/org/apache/hadoop/hive/common/cli/ShellCmdExecutor.java PRE-CREATION 
  common/src/java/org/apache/hive/common/util/StreamPrinter.java PRE-CREATION 
  itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 4d15e3c 
  itests/util/pom.xml b38c55b 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 2974327 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5e5cf97 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 2ce4dbd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java d2e122d 

Diff: https://reviews.apache.org/r/19830/diff/


Testing
-------

New test cases are added. 


Thanks,

Xuefu Zhang

Re: Review Request 19830: HIVE-6694: Beeline should provide a way to execute shell command as Hive CLI does

Posted by Swarnim Kulkarni <ku...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19830/#review46006
-----------------------------------------------------------



beeline/src/java/org/apache/hive/beeline/Commands.java
<https://reviews.apache.org/r/19830/#comment81167>

    Should we be returning a "false" at this point since the command failed?



itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
<https://reviews.apache.org/r/19830/#comment81168>

    Is it possible to test a failed command as well?


- Swarnim Kulkarni


On June 17, 2014, 1:49 a.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19830/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 1:49 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6694
>     https://issues.apache.org/jira/browse/HIVE-6694
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Introduce the new requested feature.
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java dcdd6f2 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 94f74d2 
>   beeline/src/main/resources/BeeLine.properties 697c29a 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 3357414 
>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 4d15e3c 
>   itests/util/pom.xml b38c55b 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 2974327 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 32c2fb0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 2ce4dbd 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java d2e122d 
> 
> Diff: https://reviews.apache.org/r/19830/diff/
> 
> 
> Testing
> -------
> 
> New test cases are added. 
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>

Re: Review Request 19830: HIVE-6694: Beeline should provide a way to execute shell command as Hive CLI does

Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19830/#review46038
-----------------------------------------------------------



itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
<https://reviews.apache.org/r/19830/#comment81204>

    Okay. Will create a followup JIRA for this.


- Xuefu Zhang


On June 17, 2014, 1:49 a.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19830/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 1:49 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6694
>     https://issues.apache.org/jira/browse/HIVE-6694
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Introduce the new requested feature.
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java dcdd6f2 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 94f74d2 
>   beeline/src/main/resources/BeeLine.properties 697c29a 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 3357414 
>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 4d15e3c 
>   itests/util/pom.xml b38c55b 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 2974327 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 32c2fb0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 2ce4dbd 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java d2e122d 
> 
> Diff: https://reviews.apache.org/r/19830/diff/
> 
> 
> Testing
> -------
> 
> New test cases are added. 
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>

Re: Review Request 19830: HIVE-6694: Beeline should provide a way to execute shell command as Hive CLI does

Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19830/
-----------------------------------------------------------

(Updated June 17, 2014, 1:49 a.m.)


Review request for hive.


Bugs: HIVE-6694
    https://issues.apache.org/jira/browse/HIVE-6694


Repository: hive-git


Description
-------

Introduce the new requested feature.


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java dcdd6f2 
  beeline/src/java/org/apache/hive/beeline/Commands.java 94f74d2 
  beeline/src/main/resources/BeeLine.properties 697c29a 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 3357414 
  itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 4d15e3c 
  itests/util/pom.xml b38c55b 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 2974327 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 32c2fb0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 2ce4dbd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java d2e122d 

Diff: https://reviews.apache.org/r/19830/diff/


Testing
-------

New test cases are added. 


Thanks,

Xuefu Zhang

Re: Review Request 19830: HIVE-6694: Beeline should provide a way to execute shell command as Hive CLI does

Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19830/
-----------------------------------------------------------

(Updated March 30, 2014, 11:20 p.m.)


Review request for hive.


Bugs: HIVE-6694
    https://issues.apache.org/jira/browse/HIVE-6694


Repository: hive-git


Description
-------

Introduce the new requested feature.


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java 5773109 
  beeline/src/java/org/apache/hive/beeline/Commands.java 493f963 
  beeline/src/main/resources/BeeLine.properties 697c29a 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 32d367a 
  common/src/java/org/apache/hadoop/hive/common/cli/ShellCmdExecutor.java PRE-CREATION 
  common/src/java/org/apache/hive/common/util/StreamPrinter.java PRE-CREATION 
  itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 741cc47 
  itests/util/pom.xml e9720df 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 25dbde9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 429f6f2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 326654f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 55ce0fc 

Diff: https://reviews.apache.org/r/19830/diff/


Testing
-------

New test cases are added. 


Thanks,

Xuefu Zhang