You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by mice xia <mi...@tcloudcomputing.com> on 2012/07/31 10:08:36 UTC
Review Request: Failed to show any shared guest networks on infrastructure
page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6226/
-----------------------------------------------------------
Review request for cloudstack, Brian Federle, Jessica Wang, and Alena Prokharchyk.
Description
-------
fix two issues:
1) advanced zone, admin user, zone-->specified zone-->physical network-->guest network-->network, this pages failed to show any direct tagged network
2) API listNetworks with parameter domainId does not work as document specified
changes:
-NetworkManagerImpl.java
add domainId filter in the end of method searchForNetworks
use Set to remove potentially duplicate returning elements
remove line 'sc.addAnd("id", SearchCriteria.Op.SC, accountSC);' in method listAccountSpecificNetworksByDomainPath, this line caused issue 1)
-instanceWizard.js
remove parameter 'domainId' of listNetworks
Diffs
-----
server/src/com/cloud/network/NetworkManagerImpl.java 4dd5eab
ui/scripts/instanceWizard.js 3cf6694
Diff: https://reviews.apache.org/r/6226/diff/
Testing
-------
following scenarios are tested?
login as admin, zone-->specified zone-->physical network-->guest network-->network, can view all networks.
login as a user, create vm from wizard, can see zone-wide,domain-wide and this account-specific direct tagged networks.
listNetworks API, specficied domainID, listAll=true, return networks belong to this domain and visible to caller.
Thanks,
mice xia
答复: Review Request: Failed to show any shared guest networks on infrastructure page
Posted by Mice Xia <mi...@tcloudcomputing.com>.
Hi Alena,
test 721d3ef3dcd773d3e5b638f703e91456915393e6 with following setup, D for domain, acct for account, N for network.
ROOT （N0, zone wide)
----D1 (N1, domain wide)
----acct1a
----acct1u (N4, account-specific)
----D2 (N2, domain wide)
----acct2a
----acct2u (N5, account-specific)
----D3 (N3, domain wide)
with acct2a (which is a domain admin), call api 'command=listNetworks&listAll=true', it returns N0, N1
should listAll=true allow acct2a to view N2,N3,N4 and N5 as well? i assume domainAdmin should be authorized to see the resource under its domain and subdomain.
Regards
Mice
-----Original Message-----
From: Alena Prokharchyk 代表 Alena Prokharchyk
Sent: 2012-8-1 (星期三) 2:52
To: Jessica Wang; Alena Prokharchyk; Brian Federle
Cc: cloudstack; Mice Xia
Subject: Re: Review Request: Failed to show any shared guest networks on infrastructure page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6226/#review9655
-----------------------------------------------------------
This bug is already fixed with 721d3ef3dcd773d3e5b638f703e91456915393e6. There is one more fix expected to be done in the UI code - http://bugs.cloudstack.org/browse/CS-15756
- Alena Prokharchyk
On July 31, 2012, 8:08 a.m., mice xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6226/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 8:08 a.m.)
>
>
> Review request for cloudstack, Brian Federle, Jessica Wang, and Alena Prokharchyk.
>
>
> Description
> -------
>
> fix two issues:
> 1) advanced zone, admin user, zone-->specified zone-->physical network-->guest network-->network, this pages failed to show any direct tagged network
> 2) API listNetworks with parameter domainId does not work as document specified
>
> changes:
> -NetworkManagerImpl.java
> add domainId filter in the end of method searchForNetworks
> use Set to remove potentially duplicate returning elements
> remove line 'sc.addAnd("id", SearchCriteria.Op.SC, accountSC);' in method listAccountSpecificNetworksByDomainPath, this line caused issue 1)
>
> -instanceWizard.js
> remove parameter 'domainId' of listNetworks
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkManagerImpl.java 4dd5eab
> ui/scripts/instanceWizard.js 3cf6694
>
> Diff: https://reviews.apache.org/r/6226/diff/
>
>
> Testing
> -------
>
> following scenarios are tested?
> login as admin, zone-->specified zone-->physical network-->guest network-->network, can view all networks.
> login as a user, create vm from wizard, can see zone-wide,domain-wide and this account-specific direct tagged networks.
> listNetworks API, specficied domainID, listAll=true, return networks belong to this domain and visible to caller.
>
>
> Thanks,
>
> mice xia
>
>
Re: Review Request: Failed to show any shared guest networks on
infrastructure page
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6226/#review9655
-----------------------------------------------------------
This bug is already fixed with 721d3ef3dcd773d3e5b638f703e91456915393e6. There is one more fix expected to be done in the UI code - http://bugs.cloudstack.org/browse/CS-15756
- Alena Prokharchyk
On July 31, 2012, 8:08 a.m., mice xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6226/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 8:08 a.m.)
>
>
> Review request for cloudstack, Brian Federle, Jessica Wang, and Alena Prokharchyk.
>
>
> Description
> -------
>
> fix two issues:
> 1) advanced zone, admin user, zone-->specified zone-->physical network-->guest network-->network, this pages failed to show any direct tagged network
> 2) API listNetworks with parameter domainId does not work as document specified
>
> changes:
> -NetworkManagerImpl.java
> add domainId filter in the end of method searchForNetworks
> use Set to remove potentially duplicate returning elements
> remove line 'sc.addAnd("id", SearchCriteria.Op.SC, accountSC);' in method listAccountSpecificNetworksByDomainPath, this line caused issue 1)
>
> -instanceWizard.js
> remove parameter 'domainId' of listNetworks
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkManagerImpl.java 4dd5eab
> ui/scripts/instanceWizard.js 3cf6694
>
> Diff: https://reviews.apache.org/r/6226/diff/
>
>
> Testing
> -------
>
> following scenarios are tested?
> login as admin, zone-->specified zone-->physical network-->guest network-->network, can view all networks.
> login as a user, create vm from wizard, can see zone-wide,domain-wide and this account-specific direct tagged networks.
> listNetworks API, specficied domainID, listAll=true, return networks belong to this domain and visible to caller.
>
>
> Thanks,
>
> mice xia
>
>