You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by fmazoyer <gi...@git.apache.org> on 2014/12/09 11:20:44 UTC
[GitHub] storm pull request: Performance improvement: Fix for https://issue...
GitHub user fmazoyer opened a pull request:
https://github.com/apache/storm/pull/343
Performance improvement: Fix for https://issues.apache.org/jira/browse/STORM-585
Hello, this fix helped us gain a sizable amount of performances in none:grouping.
Details are in JIRA https://issues.apache.org/jira/browse/STORM-585
Thanks a lot for your help :-)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fmazoyer/storm STORM-585
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/343.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #343
----
commit 6270fc02938393eba91dbe6f313ad28d09fb92a1
Author: Frantz Mazoyer <fr...@altran.com>
Date: 2014-12-09T10:07:53Z
Fix for https://issues.apache.org/jira/browse/STORM-585
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Performance improvement: Fix for https://issue...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/343#issuecomment-66322504
git commit --amend, should allow you to modify last commit message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Performance improvement: Fix for https://issue...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/343#issuecomment-66316526
Can you add STORM-585 in the begining of your commit message so it gets mapped to the jira?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Performance improvement: Fix for https://issue...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Performance improvement: Fix for https://issue...
Posted by fmazoyer <gi...@git.apache.org>.
Github user fmazoyer commented on the pull request:
https://github.com/apache/storm/pull/343#issuecomment-66322250
Could you help me with a simple way to do that, please? Thanks for your help :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Performance improvement: Fix for https://issue...
Posted by fmazoyer <gi...@git.apache.org>.
Github user fmazoyer commented on the pull request:
https://github.com/apache/storm/pull/343#issuecomment-66430140
Ok thanks a lot, this is done and ready for review.
Sorry for the delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Performance improvement: Fix for https://issue...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/343#issuecomment-66830696
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Performance improvement: Fix for https://issue...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/343#issuecomment-67349245
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---