You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/04/06 12:03:51 UTC
[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3636: [ISSUE #3503]Replace this call to "replaceAll()" by a call to the "replace()" method.[PravegaClient]
harshithasudhakar opened a new pull request, #3636:
URL: https://github.com/apache/eventmesh/pull/3636
Fixes #3503
### Motivation
When String::replaceAll is used, the first argument should be a real regular expression. If it’s not the case, String::replace does exactly the same thing as String::replaceAll without the performance drawback of the regex.
### Modifications
Replaced "replaceAll()" with "replace()" at line 191
### Documentation
- Does this pull request introduce a new feature? (yes / no)
No
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
Not Applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #3503]Replace this call to "replaceAll()" by a call to the "replace()" method.[PravegaClient] (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3636:
URL: https://github.com/apache/eventmesh/pull/3636#issuecomment-1818109205
Fixed in #3967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] harshithasudhakar commented on pull request #3636: [ISSUE #3503]Replace this call to "replaceAll()" by a call to the "replace()" method.[PravegaClient]
Posted by "harshithasudhakar (via GitHub)" <gi...@apache.org>.
harshithasudhakar commented on PR #3636:
URL: https://github.com/apache/eventmesh/pull/3636#issuecomment-1508132933
The PR hasn't been merged yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3636: [ISSUE #3503]Replace this call to "replaceAll()" by a call to the "replace()" method.[PravegaClient]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3636:
URL: https://github.com/apache/eventmesh/pull/3636#issuecomment-1499857242
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3636?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3636](https://codecov.io/gh/apache/eventmesh/pull/3636?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7786830) into [master](https://codecov.io/gh/apache/eventmesh/commit/7f005243389d5c6a7942a35bbf6c5eb306cd9f01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f00524) will **not change** coverage.
> The diff coverage is `0.00%`.
> :exclamation: Current head 7786830 differs from pull request most recent head 3240494. Consider uploading reports for the commit 3240494 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3636 +/- ##
=========================================
Coverage 13.76% 13.76%
Complexity 1291 1291
=========================================
Files 571 571
Lines 29239 29239
Branches 2885 2885
=========================================
Hits 4024 4024
Misses 24841 24841
Partials 374 374
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3636?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ventmesh/storage/pravega/client/PravegaClient.java](https://codecov.io/gh/apache/eventmesh/pull/3636?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXByYXZlZ2Evc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3ByYXZlZ2EvY2xpZW50L1ByYXZlZ2FDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3503]Replace this call to "replaceAll()" by a call to the "replace()" method.[PravegaClient] (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo closed pull request #3636: [ISSUE #3503]Replace this call to "replaceAll()" by a call to the "replace()" method.[PravegaClient]
URL: https://github.com/apache/eventmesh/pull/3636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org