You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by jo...@apache.org on 2010/02/09 23:53:48 UTC

svn commit: r908266 - /shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java

Author: johnh
Date: Tue Feb  9 22:53:47 2010
New Revision: 908266

URL: http://svn.apache.org/viewvc?rev=908266&view=rev
Log:
Added guard code to prevent StringIndexOutOfBoundsException on empty charset.



Modified:
    shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java

Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java?rev=908266&r1=908265&r2=908266&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java Tue Feb  9 22:53:47 2010
@@ -468,7 +468,7 @@
           String charset = parts[1].substring(offset + 8).toUpperCase();
           // Some servers include quotes around the charset:
           //   Content-Type: text/html; charset="UTF-8"
-          if (charset.charAt(0) == '"') {
+          if (charset.length() >= 2 && charset.startsWith("\"") && charset.endsWith("\"")) {
             charset = charset.substring(1, charset.length() - 1);
           }