[jira] [Commented] (METRON-1577) Solr searches don't include the index of the result

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489631#comment-16489631 ] 

ASF GitHub Bot commented on METRON-1577:
----------------------------------------

GitHub user merrimanr opened a pull request:

    https://github.com/apache/metron/pull/1031

    METRON-1577: Solr searches don't include the index of the result

    ## Contributor Comments
    This PR adds a document's index or collection to search results.  Previously when using Solr, the index field would always be null.  An indexSupplier was recently added to the AccessConfig and is now used in the Solr Daos to get the index from a sensor type and populate that field.  
    
    I had to fix a bug in the IndexingCacheUtil class where the index field was being retrieved directly instead of for a specific writer.  I think this wasn't caught before because sensor types always equal index in the various index configs and this class returns sensor type by default.  I added a unit test for this class that should cover the different cases and verify that this does default to sensor type.
    
    I also adjusted unit and integration tests to accommodate this change.  Testing in full dev is still pending and I should have that done today.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-1577

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1031
    
----
commit 0344ce44ee2b1ba735b3abbf08f4e35f0bdc8eca
Author: merrimanr <me...@...>
Date:   2018-05-24T19:08:08Z

    initial commit

----


> Solr searches don't include the index of the result
> ---------------------------------------------------
>
>                 Key: METRON-1577
>                 URL: https://issues.apache.org/jira/browse/METRON-1577
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Ryan Merriman
>            Assignee: Ryan Merriman
>            Priority: Major
>
> For example
> {code:java}
> { 
>   "total": 370, 
>   "results": [
>     { 
>       "id": "1dcf6e7e-9d16-477b-990e-e734bd400101",
>       "source": 
>         { 
>           "guid": "1dcf6e7e-9d16-477b-990e-e734bd400101" 
>         }, 
>       "score": 0, 
>       "index": null 
>     } 
>   ], 
>   "facetCounts": null 
> }{code}
> We should also make sure that any other endpoints (if there are any) that return index, are populated properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)