You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/08/19 07:15:21 UTC
[native-toolchain-CR] IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17791
Change subject: IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
......................................................................
IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
ORC 1.7 is not released yet. This patch adds a snapshot version to
native-toolchain to unblock some works in improving the orc scanner
performance.
The top commit of ORC 1.7 is 36349d535089412b58f99c72af9bf7dcf7444aee.
It contains all the patches we applied on ORC 1.6.2, also contains some
new features and improvements like ORC-751 and ORC-614.
Tests
- Build ORC locally
- Build Impala with the patch of IMPALA-6505 that depends on the
predicate push down feature (ORC-751).
Change-Id: Icbff0ed325bee3128d2a2aed060390d59bd4ca22
---
M buildall.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/91/17791/1
--
To view, visit http://gerrit.cloudera.org:8080/17791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbff0ed325bee3128d2a2aed060390d59bd4ca22
Gerrit-Change-Number: 17791
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[native-toolchain-CR] IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17791
to look at the new patch set (#2).
Change subject: IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
......................................................................
IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
ORC 1.7 is not released yet. This patch adds a snapshot version to
native-toolchain to unblock some works in improving the orc scanner
performance.
The top commit of ORC 1.7 is a49dd6a7cbf1550650a46f5744a76bd0ff53707a.
It contains all the patches we applied on ORC 1.6.2, also contains some
new features, improvements, and bug fixes like ORC-751, ORC-614,
ORC-959, ORC-960 and ORC-971.
Tests
- Build ORC locally
- Build Impala with the patch of IMPALA-6505 that depends on the
predicate push down feature (ORC-751).
Change-Id: Icbff0ed325bee3128d2a2aed060390d59bd4ca22
---
M buildall.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/91/17791/2
--
To view, visit http://gerrit.cloudera.org:8080/17791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icbff0ed325bee3128d2a2aed060390d59bd4ca22
Gerrit-Change-Number: 17791
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17791 )
Change subject: IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbff0ed325bee3128d2a2aed060390d59bd4ca22
Gerrit-Change-Number: 17791
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 16:25:00 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17791 )
Change subject: IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbff0ed325bee3128d2a2aed060390d59bd4ca22
Gerrit-Change-Number: 17791
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 28 Aug 2021 00:12:51 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17791 )
Change subject: IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbff0ed325bee3128d2a2aed060390d59bd4ca22
Gerrit-Change-Number: 17791
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Aug 2021 11:40:49 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17791 )
Change subject: IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
......................................................................
Patch Set 2: Verified+1
Verified in https://gerrit.cloudera.org/c/15403/
--
To view, visit http://gerrit.cloudera.org:8080/17791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbff0ed325bee3128d2a2aed060390d59bd4ca22
Gerrit-Change-Number: 17791
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Aug 2021 11:57:22 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17791 )
Change subject: IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
......................................................................
Patch Set 1:
Thank Wenzhe for having a look! I'm going to pick ORC-959 and ORC-960 which will also be helpful.
--
To view, visit http://gerrit.cloudera.org:8080/17791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbff0ed325bee3128d2a2aed060390d59bd4ca22
Gerrit-Change-Number: 17791
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 13:35:23 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17791 )
Change subject: IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
......................................................................
IMPALA-10872: Add a snapshot version of ORC-1.7 to native-toolchain
ORC 1.7 is not released yet. This patch adds a snapshot version to
native-toolchain to unblock some works in improving the orc scanner
performance.
The top commit of ORC 1.7 is a49dd6a7cbf1550650a46f5744a76bd0ff53707a.
It contains all the patches we applied on ORC 1.6.2, also contains some
new features, improvements, and bug fixes like ORC-751, ORC-614,
ORC-959, ORC-960 and ORC-971.
Tests
- Build ORC locally
- Build Impala with the patch of IMPALA-6505 that depends on the
predicate push down feature (ORC-751).
Change-Id: Icbff0ed325bee3128d2a2aed060390d59bd4ca22
Reviewed-on: http://gerrit.cloudera.org:8080/17791
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M buildall.sh
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Wenzhe Zhou: Looks good to me, but someone else must approve
Csaba Ringhofer: Looks good to me, approved
Quanlong Huang: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbff0ed325bee3128d2a2aed060390d59bd4ca22
Gerrit-Change-Number: 17791
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>