You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Maxim Solodovnik <so...@gmail.com> on 2018/04/03 14:36:35 UTC
[DISCUSSION] Wicket 8 Release
Hello All,
I believe it is time to release :)
Do we have any blockers?
Some non-technical blockers should be already resolved :)))
--
WBR
Maxim aka solomax
Re: [DISCUSSION] Wicket 8 Release
Posted by Emond Papegaaij <em...@topicus.nl>.
On dinsdag 10 april 2018 14:22:21 CEST Martijn Dashorst wrote:
> On Tue, Apr 10, 2018 at 2:09 PM, Maxim Solodovnik <so...@gmail.com>
wrote:
> > Current version is Java 10 (non LTS)
> > Maybe we can release 8.0.0 and add this to Wicket 9 ?
>
> The issue is that you can't upgrade to Java 11 when you are running
> CGLIB due to its use of sun.misc.Unsafe.
>
> This will cause problems. I'd rather ensure we have a good path
> forward, and Java 11 is in september. We can't break API in 8.x so we
> are stuck with CGLIB apis we expose.
We can still keep the CGLIB API and add a Byte Buddy variant. This would not
break compatibility for everyone running on 8.x. For users running on 11.x it
would break at runtime, but that will happen anyway.
IMHO this is not a blocker for a 8.0.0 release, but it should be fixed soon.
Also note that this will also break 6.x and 7.x, so we will need the same fix
for those versions.
Best regards,
Emond
Re: [DISCUSSION] Wicket 8 Release
Posted by Andrea Del Bene <an...@gmail.com>.
I agree. Releasing Wicket 8 is mandatory in any case.
On 16/04/2018 16:40, Martin Grigorov wrote:
> Let's release Wicket 8.0.0 first and then start adding/removing features
> for Wicket 9!
>
>
> On Mon, Apr 16, 2018 at 3:27 PM, Emond Papegaaij <emond.papegaaij@topicus.nl
>> wrote:
>> I think the issue is related to the very old version of cdi-unit and weld
>> that
>> are being used. cdi-1.1 is the current implementation. If we want to drop
>> one,
>> wich should drop the wicket-cdi artifact (which is for cdi-1.0). In any
>> case,
>> we can upgrade to cdi-1.2 I guess, but we should also upgrade cdi-unit and
>> weld-se-core. Unfortunately I don't have the time to do that at the moment.
>>
>> Emond
>>
>> On maandag 16 april 2018 11:40:08 CEST Andrea Del Bene wrote:
>>> It's not an answer to your question, but I've create a sort of
>>> "proof-of-concept" for Wicket 9 (branch wicket9 of Apache repo). I've
>>> successfully built a 9.0.0-SNAPSHOT version axing module wicket-cdi-1.1
>>> which had the same cast exception reported here for Spring:
>>> https://github.com/spring-projects/spring-boot/issues/7565. I've also
>>> removed testing/wicket-arquillian as it depends on jconsole.jar which
>>> seems to be not part anymore of the jdk (but i might be wrong).
>>>
>>> PS: In any case, I don't even know if cdi-1.1 ca be used with Java > 8
>>>
>>> Andrea.
>>>
>>> On 16/04/2018 10:37, Martijn Dashorst wrote:
>>>> On Sun, Apr 15, 2018 at 12:25 PM, Andrea Del Bene <
>> an.delbene@gmail.com>
>> wrote:
>>>>> I've also tried to build master branch with Java 9 and I've found the
>>>>> following issues:
>>>>>
>>>>> wicket-util: it seems that java 9 has changed date formats to be
>> closer
>>>>> to
>>>>> the Unicode standard: https://www.infoq.com/news/201
>> 7/02/java9-cldr-ldml.
>>>>> This breaks some unit tests
>>>>> wicket-extentions: import javax.annotation.Resource is not used and
>> not
>>>>> available in the new jdk
>>>>> wicket-cdi-1.1: there are some cast exceptions during tests
>> execution. At
>>>>> the moment I can't be more specific.
>>>>>
>>>>> I've created a branch for Wicket with java 9 here:
>>>>> https://github.com/bitstorm/wicket/tree/wicket9. I've solved the
>> issues
>>>>> for
>>>>> wicket-util and wicket-extentions
>>>> How can we make it such that Wicket 8 builds on all Java 8-10?
>>>>
>>>> Martijn
>>
>>
Re: [DISCUSSION] Wicket 8 Release
Posted by Andrea Del Bene <an...@gmail.com>.
So in the end, why NOT releasing Wicket 8 ?
On 16/04/2018 20:10, Sven Meier wrote:
> +1 fully agreed
>
> Sven
>
> Am 16. April 2018 16:40:35 MESZ schrieb Martin Grigorov <mg...@apache.org>:
>> Let's release Wicket 8.0.0 first and then start adding/removing
>> features
>> for Wicket 9!
>>
>>
>> On Mon, Apr 16, 2018 at 3:27 PM, Emond Papegaaij
>> <emond.papegaaij@topicus.nl
>>> wrote:
>>> I think the issue is related to the very old version of cdi-unit and
>> weld
>>> that
>>> are being used. cdi-1.1 is the current implementation. If we want to
>> drop
>>> one,
>>> wich should drop the wicket-cdi artifact (which is for cdi-1.0). In
>> any
>>> case,
>>> we can upgrade to cdi-1.2 I guess, but we should also upgrade
>> cdi-unit and
>>> weld-se-core. Unfortunately I don't have the time to do that at the
>> moment.
>>> Emond
>>>
>>> On maandag 16 april 2018 11:40:08 CEST Andrea Del Bene wrote:
>>>> It's not an answer to your question, but I've create a sort of
>>>> "proof-of-concept" for Wicket 9 (branch wicket9 of Apache repo).
>> I've
>>>> successfully built a 9.0.0-SNAPSHOT version axing module
>> wicket-cdi-1.1
>>>> which had the same cast exception reported here for Spring:
>>>> https://github.com/spring-projects/spring-boot/issues/7565. I've
>> also
>>>> removed testing/wicket-arquillian as it depends on jconsole.jar
>> which
>>>> seems to be not part anymore of the jdk (but i might be wrong).
>>>>
>>>> PS: In any case, I don't even know if cdi-1.1 ca be used with Java
>>> 8
>>>> Andrea.
>>>>
>>>> On 16/04/2018 10:37, Martijn Dashorst wrote:
>>>>> On Sun, Apr 15, 2018 at 12:25 PM, Andrea Del Bene <
>>> an.delbene@gmail.com>
>>> wrote:
>>>>>> I've also tried to build master branch with Java 9 and I've
>> found the
>>>>>> following issues:
>>>>>>
>>>>>> wicket-util: it seems that java 9 has changed date formats to be
>>> closer
>>>>>> to
>>>>>> the Unicode standard: https://www.infoq.com/news/201
>>> 7/02/java9-cldr-ldml.
>>>>>> This breaks some unit tests
>>>>>> wicket-extentions: import javax.annotation.Resource is not used
>> and
>>> not
>>>>>> available in the new jdk
>>>>>> wicket-cdi-1.1: there are some cast exceptions during tests
>>> execution. At
>>>>>> the moment I can't be more specific.
>>>>>>
>>>>>> I've created a branch for Wicket with java 9 here:
>>>>>> https://github.com/bitstorm/wicket/tree/wicket9. I've solved the
>>> issues
>>>>>> for
>>>>>> wicket-util and wicket-extentions
>>>>> How can we make it such that Wicket 8 builds on all Java 8-10?
>>>>>
>>>>> Martijn
>>>
>>>
Re: [DISCUSSION] Wicket 8 Release
Posted by Sven Meier <sv...@meiers.net>.
+1 fully agreed
Sven
Am 16. April 2018 16:40:35 MESZ schrieb Martin Grigorov <mg...@apache.org>:
>Let's release Wicket 8.0.0 first and then start adding/removing
>features
>for Wicket 9!
>
>
>On Mon, Apr 16, 2018 at 3:27 PM, Emond Papegaaij
><emond.papegaaij@topicus.nl
>> wrote:
>
>> I think the issue is related to the very old version of cdi-unit and
>weld
>> that
>> are being used. cdi-1.1 is the current implementation. If we want to
>drop
>> one,
>> wich should drop the wicket-cdi artifact (which is for cdi-1.0). In
>any
>> case,
>> we can upgrade to cdi-1.2 I guess, but we should also upgrade
>cdi-unit and
>> weld-se-core. Unfortunately I don't have the time to do that at the
>moment.
>>
>> Emond
>>
>> On maandag 16 april 2018 11:40:08 CEST Andrea Del Bene wrote:
>> > It's not an answer to your question, but I've create a sort of
>> > "proof-of-concept" for Wicket 9 (branch wicket9 of Apache repo).
>I've
>> > successfully built a 9.0.0-SNAPSHOT version axing module
>wicket-cdi-1.1
>> > which had the same cast exception reported here for Spring:
>> > https://github.com/spring-projects/spring-boot/issues/7565. I've
>also
>> > removed testing/wicket-arquillian as it depends on jconsole.jar
>which
>> > seems to be not part anymore of the jdk (but i might be wrong).
>> >
>> > PS: In any case, I don't even know if cdi-1.1 ca be used with Java
>> 8
>> >
>> > Andrea.
>> >
>> > On 16/04/2018 10:37, Martijn Dashorst wrote:
>> > > On Sun, Apr 15, 2018 at 12:25 PM, Andrea Del Bene <
>> an.delbene@gmail.com>
>> wrote:
>> > >> I've also tried to build master branch with Java 9 and I've
>found the
>> > >> following issues:
>> > >>
>> > >> wicket-util: it seems that java 9 has changed date formats to be
>> closer
>> > >> to
>> > >> the Unicode standard: https://www.infoq.com/news/201
>> 7/02/java9-cldr-ldml.
>> > >> This breaks some unit tests
>> > >> wicket-extentions: import javax.annotation.Resource is not used
>and
>> not
>> > >> available in the new jdk
>> > >> wicket-cdi-1.1: there are some cast exceptions during tests
>> execution. At
>> > >> the moment I can't be more specific.
>> > >>
>> > >> I've created a branch for Wicket with java 9 here:
>> > >> https://github.com/bitstorm/wicket/tree/wicket9. I've solved the
>> issues
>> > >> for
>> > >> wicket-util and wicket-extentions
>> > >
>> > > How can we make it such that Wicket 8 builds on all Java 8-10?
>> > >
>> > > Martijn
>>
>>
>>
Re: [DISCUSSION] Wicket 8 Release
Posted by Martin Grigorov <mg...@apache.org>.
Let's release Wicket 8.0.0 first and then start adding/removing features
for Wicket 9!
On Mon, Apr 16, 2018 at 3:27 PM, Emond Papegaaij <emond.papegaaij@topicus.nl
> wrote:
> I think the issue is related to the very old version of cdi-unit and weld
> that
> are being used. cdi-1.1 is the current implementation. If we want to drop
> one,
> wich should drop the wicket-cdi artifact (which is for cdi-1.0). In any
> case,
> we can upgrade to cdi-1.2 I guess, but we should also upgrade cdi-unit and
> weld-se-core. Unfortunately I don't have the time to do that at the moment.
>
> Emond
>
> On maandag 16 april 2018 11:40:08 CEST Andrea Del Bene wrote:
> > It's not an answer to your question, but I've create a sort of
> > "proof-of-concept" for Wicket 9 (branch wicket9 of Apache repo). I've
> > successfully built a 9.0.0-SNAPSHOT version axing module wicket-cdi-1.1
> > which had the same cast exception reported here for Spring:
> > https://github.com/spring-projects/spring-boot/issues/7565. I've also
> > removed testing/wicket-arquillian as it depends on jconsole.jar which
> > seems to be not part anymore of the jdk (but i might be wrong).
> >
> > PS: In any case, I don't even know if cdi-1.1 ca be used with Java > 8
> >
> > Andrea.
> >
> > On 16/04/2018 10:37, Martijn Dashorst wrote:
> > > On Sun, Apr 15, 2018 at 12:25 PM, Andrea Del Bene <
> an.delbene@gmail.com>
> wrote:
> > >> I've also tried to build master branch with Java 9 and I've found the
> > >> following issues:
> > >>
> > >> wicket-util: it seems that java 9 has changed date formats to be
> closer
> > >> to
> > >> the Unicode standard: https://www.infoq.com/news/201
> 7/02/java9-cldr-ldml.
> > >> This breaks some unit tests
> > >> wicket-extentions: import javax.annotation.Resource is not used and
> not
> > >> available in the new jdk
> > >> wicket-cdi-1.1: there are some cast exceptions during tests
> execution. At
> > >> the moment I can't be more specific.
> > >>
> > >> I've created a branch for Wicket with java 9 here:
> > >> https://github.com/bitstorm/wicket/tree/wicket9. I've solved the
> issues
> > >> for
> > >> wicket-util and wicket-extentions
> > >
> > > How can we make it such that Wicket 8 builds on all Java 8-10?
> > >
> > > Martijn
>
>
>
Re: [DISCUSSION] Wicket 8 Release
Posted by Emond Papegaaij <em...@topicus.nl>.
I think the issue is related to the very old version of cdi-unit and weld that
are being used. cdi-1.1 is the current implementation. If we want to drop one,
wich should drop the wicket-cdi artifact (which is for cdi-1.0). In any case,
we can upgrade to cdi-1.2 I guess, but we should also upgrade cdi-unit and
weld-se-core. Unfortunately I don't have the time to do that at the moment.
Emond
On maandag 16 april 2018 11:40:08 CEST Andrea Del Bene wrote:
> It's not an answer to your question, but I've create a sort of
> "proof-of-concept" for Wicket 9 (branch wicket9 of Apache repo). I've
> successfully built a 9.0.0-SNAPSHOT version axing module wicket-cdi-1.1
> which had the same cast exception reported here for Spring:
> https://github.com/spring-projects/spring-boot/issues/7565. I've also
> removed testing/wicket-arquillian as it depends on jconsole.jar which
> seems to be not part anymore of the jdk (but i might be wrong).
>
> PS: In any case, I don't even know if cdi-1.1 ca be used with Java > 8
>
> Andrea.
>
> On 16/04/2018 10:37, Martijn Dashorst wrote:
> > On Sun, Apr 15, 2018 at 12:25 PM, Andrea Del Bene <an...@gmail.com>
wrote:
> >> I've also tried to build master branch with Java 9 and I've found the
> >> following issues:
> >>
> >> wicket-util: it seems that java 9 has changed date formats to be closer
> >> to
> >> the Unicode standard: https://www.infoq.com/news/2017/02/java9-cldr-ldml.
> >> This breaks some unit tests
> >> wicket-extentions: import javax.annotation.Resource is not used and not
> >> available in the new jdk
> >> wicket-cdi-1.1: there are some cast exceptions during tests execution. At
> >> the moment I can't be more specific.
> >>
> >> I've created a branch for Wicket with java 9 here:
> >> https://github.com/bitstorm/wicket/tree/wicket9. I've solved the issues
> >> for
> >> wicket-util and wicket-extentions
> >
> > How can we make it such that Wicket 8 builds on all Java 8-10?
> >
> > Martijn
Re: [DISCUSSION] Wicket 8 Release
Posted by Andrea Del Bene <an...@gmail.com>.
It's not an answer to your question, but I've create a sort of
"proof-of-concept" for Wicket 9 (branch wicket9 of Apache repo). I've
successfully built a 9.0.0-SNAPSHOT version axing module wicket-cdi-1.1
which had the same cast exception reported here for Spring:
https://github.com/spring-projects/spring-boot/issues/7565. I've also
removed testing/wicket-arquillian as it depends on jconsole.jar which
seems to be not part anymore of the jdk (but i might be wrong).
PS: In any case, I don't even know if cdi-1.1 ca be used with Java > 8
Andrea.
On 16/04/2018 10:37, Martijn Dashorst wrote:
> On Sun, Apr 15, 2018 at 12:25 PM, Andrea Del Bene <an...@gmail.com> wrote:
>> I've also tried to build master branch with Java 9 and I've found the
>> following issues:
>>
>> wicket-util: it seems that java 9 has changed date formats to be closer to
>> the Unicode standard: https://www.infoq.com/news/2017/02/java9-cldr-ldml.
>> This breaks some unit tests
>> wicket-extentions: import javax.annotation.Resource is not used and not
>> available in the new jdk
>> wicket-cdi-1.1: there are some cast exceptions during tests execution. At
>> the moment I can't be more specific.
>>
>> I've created a branch for Wicket with java 9 here:
>> https://github.com/bitstorm/wicket/tree/wicket9. I've solved the issues for
>> wicket-util and wicket-extentions
>>
> How can we make it such that Wicket 8 builds on all Java 8-10?
>
> Martijn
Re: [DISCUSSION] Wicket 8 Release
Posted by Martijn Dashorst <ma...@gmail.com>.
On Sun, Apr 15, 2018 at 12:25 PM, Andrea Del Bene <an...@gmail.com> wrote:
> I've also tried to build master branch with Java 9 and I've found the
> following issues:
>
> wicket-util: it seems that java 9 has changed date formats to be closer to
> the Unicode standard: https://www.infoq.com/news/2017/02/java9-cldr-ldml.
> This breaks some unit tests
> wicket-extentions: import javax.annotation.Resource is not used and not
> available in the new jdk
> wicket-cdi-1.1: there are some cast exceptions during tests execution. At
> the moment I can't be more specific.
>
> I've created a branch for Wicket with java 9 here:
> https://github.com/bitstorm/wicket/tree/wicket9. I've solved the issues for
> wicket-util and wicket-extentions
>
How can we make it such that Wicket 8 builds on all Java 8-10?
Martijn
Re: [DISCUSSION] Wicket 8 Release
Posted by Andrea Del Bene <an...@gmail.com>.
I've also tried to build master branch with Java 9 and I've found the
following issues:
wicket-util: it seems that java 9 has changed date formats to be closer
to the Unicode standard:
https://www.infoq.com/news/2017/02/java9-cldr-ldml. This breaks some
unit tests
wicket-extentions: import javax.annotation.Resource is not used and not
available in the new jdk
wicket-cdi-1.1: there are some cast exceptions during tests execution.
At the moment I can't be more specific.
I've created a branch for Wicket with java 9 here:
https://github.com/bitstorm/wicket/tree/wicket9. I've solved the issues
for wicket-util and wicket-extentions
On 12/04/2018 04:58, Maxim Solodovnik wrote:
> Our build was not successful on Java9
> I have migration in plans, but not right now ....
>
> Wicket itself was not buildable for me with Java9 when I tried last time
>
> On Thu, Apr 12, 2018 at 12:06 AM, Martin Grigorov <martin.grigorov@gmail.com
>> wrote:
>> Does any of you use Java 9/10 ?
>>
>> I have the feeling that Java 11 will be postponed. Some bigger
>> libraries/frameworks will have issues upgrading to 11.
>>
>> On Wed, Apr 11, 2018, 18:43 Andrea Del Bene <an...@gmail.com> wrote:
>>
>>> Java itself has moved to a faster//release cycle so I also think we
>>> might speed up a little bit //
>>>
>>> //
>>> On 10/04/2018 16:00, Maxim Solodovnik wrote:
>>>> Browser versions topic seems to be popular so here are some stats
>>>>
>>>> Wicket 8.0.0M1 was release Jul 2016 [1]
>>>>
>>>> Since then Google Chrome has changed 15 major releases [2]
>>>>
>>>> This seems to be common practice right now ...
>>>>
>>>> Maybe it worth to release more often?
>>>>
>>>> [1] http://mvnrepository.com/artifact/org.apache.wicket/wicket-core
>>>> [2] https://en.wikipedia.org/wiki/Google_Chrome_version_history
>>>>
>>>>
>>>> On Tue, Apr 10, 2018 at 7:48 PM, Andrea Del Bene <an.delbene@gmail.com
>>> wrote:
>>>>> The issue with CGLIB looks serious, but I don't think we should
>> postpone
>>>>> Wicket 8 because of it. Wicket 8 has already a lot of API changes and
>>> new
>>>>> features and moving away from CGLIB would further complicate the
>>> migration
>>>>> path. In addition, I guess it won't be a simple task to get rid of
>>> CGLIB,
>>>>> so I don't see any reason to not release Wicket 8 while we work on
>> this
>>>>> delicate issue.
>>>>>
>>>>> My 2 cents.
>>>>>
>>>>> On Tue, Apr 10, 2018 at 2:22 PM, Martijn Dashorst <
>>>>> martijn.dashorst@gmail.com> wrote:
>>>>>
>>>>>> On Tue, Apr 10, 2018 at 2:09 PM, Maxim Solodovnik <
>>> solomax666@gmail.com>
>>>>>> wrote:
>>>>>>> Current version is Java 10 (non LTS)
>>>>>>> Maybe we can release 8.0.0 and add this to Wicket 9 ?
>>>>>>>
>>>>>> The issue is that you can't upgrade to Java 11 when you are running
>>>>>> CGLIB due to its use of sun.misc.Unsafe.
>>>>>>
>>>>>> This will cause problems. I'd rather ensure we have a good path
>>>>>> forward, and Java 11 is in september. We can't break API in 8.x so we
>>>>>> are stuck with CGLIB apis we expose.
>>>>>>
>>>>>> Unfortunately CGLIB usage is not private/internal to wicket itself
>> but
>>>>>> is exposed in a couple public APIs.
>>>>>>
>>>>>> Of course, if we had relesed Wicket 8 with CGLIB in it, this problem
>>>>>> would still exist, and perhaps Wicket 8 would be a short lived
>>>>>> maintained version if we were forced to remove our dependency on
>> CGLIB
>>>>>> (which is unclear at the moment)
>>>>>>
>>>>>> Martijn
>>>>>>
>>>>
>>>
>
>
Re: [DISCUSSION] Wicket 8 Release
Posted by Maxim Solodovnik <so...@gmail.com>.
Our build was not successful on Java9
I have migration in plans, but not right now ....
Wicket itself was not buildable for me with Java9 when I tried last time
On Thu, Apr 12, 2018 at 12:06 AM, Martin Grigorov <martin.grigorov@gmail.com
> wrote:
> Does any of you use Java 9/10 ?
>
> I have the feeling that Java 11 will be postponed. Some bigger
> libraries/frameworks will have issues upgrading to 11.
>
> On Wed, Apr 11, 2018, 18:43 Andrea Del Bene <an...@gmail.com> wrote:
>
> > Java itself has moved to a faster//release cycle so I also think we
> > might speed up a little bit //
> >
> > //
> > On 10/04/2018 16:00, Maxim Solodovnik wrote:
> > > Browser versions topic seems to be popular so here are some stats
> > >
> > > Wicket 8.0.0M1 was release Jul 2016 [1]
> > >
> > > Since then Google Chrome has changed 15 major releases [2]
> > >
> > > This seems to be common practice right now ...
> > >
> > > Maybe it worth to release more often?
> > >
> > > [1] http://mvnrepository.com/artifact/org.apache.wicket/wicket-core
> > > [2] https://en.wikipedia.org/wiki/Google_Chrome_version_history
> > >
> > >
> > > On Tue, Apr 10, 2018 at 7:48 PM, Andrea Del Bene <an.delbene@gmail.com
> >
> > wrote:
> > >> The issue with CGLIB looks serious, but I don't think we should
> postpone
> > >> Wicket 8 because of it. Wicket 8 has already a lot of API changes and
> > new
> > >> features and moving away from CGLIB would further complicate the
> > migration
> > >> path. In addition, I guess it won't be a simple task to get rid of
> > CGLIB,
> > >> so I don't see any reason to not release Wicket 8 while we work on
> this
> > >> delicate issue.
> > >>
> > >> My 2 cents.
> > >>
> > >> On Tue, Apr 10, 2018 at 2:22 PM, Martijn Dashorst <
> > >> martijn.dashorst@gmail.com> wrote:
> > >>
> > >>> On Tue, Apr 10, 2018 at 2:09 PM, Maxim Solodovnik <
> > solomax666@gmail.com>
> > >>> wrote:
> > >>>> Current version is Java 10 (non LTS)
> > >>>> Maybe we can release 8.0.0 and add this to Wicket 9 ?
> > >>>>
> > >>> The issue is that you can't upgrade to Java 11 when you are running
> > >>> CGLIB due to its use of sun.misc.Unsafe.
> > >>>
> > >>> This will cause problems. I'd rather ensure we have a good path
> > >>> forward, and Java 11 is in september. We can't break API in 8.x so we
> > >>> are stuck with CGLIB apis we expose.
> > >>>
> > >>> Unfortunately CGLIB usage is not private/internal to wicket itself
> but
> > >>> is exposed in a couple public APIs.
> > >>>
> > >>> Of course, if we had relesed Wicket 8 with CGLIB in it, this problem
> > >>> would still exist, and perhaps Wicket 8 would be a short lived
> > >>> maintained version if we were forced to remove our dependency on
> CGLIB
> > >>> (which is unclear at the moment)
> > >>>
> > >>> Martijn
> > >>>
> > >
> > >
> >
> >
>
--
WBR
Maxim aka solomax
Re: [DISCUSSION] Wicket 8 Release
Posted by Martin Grigorov <ma...@gmail.com>.
Does any of you use Java 9/10 ?
I have the feeling that Java 11 will be postponed. Some bigger
libraries/frameworks will have issues upgrading to 11.
On Wed, Apr 11, 2018, 18:43 Andrea Del Bene <an...@gmail.com> wrote:
> Java itself has moved to a faster//release cycle so I also think we
> might speed up a little bit //
>
> //
> On 10/04/2018 16:00, Maxim Solodovnik wrote:
> > Browser versions topic seems to be popular so here are some stats
> >
> > Wicket 8.0.0M1 was release Jul 2016 [1]
> >
> > Since then Google Chrome has changed 15 major releases [2]
> >
> > This seems to be common practice right now ...
> >
> > Maybe it worth to release more often?
> >
> > [1] http://mvnrepository.com/artifact/org.apache.wicket/wicket-core
> > [2] https://en.wikipedia.org/wiki/Google_Chrome_version_history
> >
> >
> > On Tue, Apr 10, 2018 at 7:48 PM, Andrea Del Bene <an...@gmail.com>
> wrote:
> >> The issue with CGLIB looks serious, but I don't think we should postpone
> >> Wicket 8 because of it. Wicket 8 has already a lot of API changes and
> new
> >> features and moving away from CGLIB would further complicate the
> migration
> >> path. In addition, I guess it won't be a simple task to get rid of
> CGLIB,
> >> so I don't see any reason to not release Wicket 8 while we work on this
> >> delicate issue.
> >>
> >> My 2 cents.
> >>
> >> On Tue, Apr 10, 2018 at 2:22 PM, Martijn Dashorst <
> >> martijn.dashorst@gmail.com> wrote:
> >>
> >>> On Tue, Apr 10, 2018 at 2:09 PM, Maxim Solodovnik <
> solomax666@gmail.com>
> >>> wrote:
> >>>> Current version is Java 10 (non LTS)
> >>>> Maybe we can release 8.0.0 and add this to Wicket 9 ?
> >>>>
> >>> The issue is that you can't upgrade to Java 11 when you are running
> >>> CGLIB due to its use of sun.misc.Unsafe.
> >>>
> >>> This will cause problems. I'd rather ensure we have a good path
> >>> forward, and Java 11 is in september. We can't break API in 8.x so we
> >>> are stuck with CGLIB apis we expose.
> >>>
> >>> Unfortunately CGLIB usage is not private/internal to wicket itself but
> >>> is exposed in a couple public APIs.
> >>>
> >>> Of course, if we had relesed Wicket 8 with CGLIB in it, this problem
> >>> would still exist, and perhaps Wicket 8 would be a short lived
> >>> maintained version if we were forced to remove our dependency on CGLIB
> >>> (which is unclear at the moment)
> >>>
> >>> Martijn
> >>>
> >
> >
>
>
Re: [DISCUSSION] Wicket 8 Release
Posted by Andrea Del Bene <an...@gmail.com>.
Java itself has moved to a faster//release cycle so I also think we
might speed up a little bit //
//
On 10/04/2018 16:00, Maxim Solodovnik wrote:
> Browser versions topic seems to be popular so here are some stats
>
> Wicket 8.0.0M1 was release Jul 2016 [1]
>
> Since then Google Chrome has changed 15 major releases [2]
>
> This seems to be common practice right now ...
>
> Maybe it worth to release more often?
>
> [1] http://mvnrepository.com/artifact/org.apache.wicket/wicket-core
> [2] https://en.wikipedia.org/wiki/Google_Chrome_version_history
>
>
> On Tue, Apr 10, 2018 at 7:48 PM, Andrea Del Bene <an...@gmail.com> wrote:
>> The issue with CGLIB looks serious, but I don't think we should postpone
>> Wicket 8 because of it. Wicket 8 has already a lot of API changes and new
>> features and moving away from CGLIB would further complicate the migration
>> path. In addition, I guess it won't be a simple task to get rid of CGLIB,
>> so I don't see any reason to not release Wicket 8 while we work on this
>> delicate issue.
>>
>> My 2 cents.
>>
>> On Tue, Apr 10, 2018 at 2:22 PM, Martijn Dashorst <
>> martijn.dashorst@gmail.com> wrote:
>>
>>> On Tue, Apr 10, 2018 at 2:09 PM, Maxim Solodovnik <so...@gmail.com>
>>> wrote:
>>>> Current version is Java 10 (non LTS)
>>>> Maybe we can release 8.0.0 and add this to Wicket 9 ?
>>>>
>>> The issue is that you can't upgrade to Java 11 when you are running
>>> CGLIB due to its use of sun.misc.Unsafe.
>>>
>>> This will cause problems. I'd rather ensure we have a good path
>>> forward, and Java 11 is in september. We can't break API in 8.x so we
>>> are stuck with CGLIB apis we expose.
>>>
>>> Unfortunately CGLIB usage is not private/internal to wicket itself but
>>> is exposed in a couple public APIs.
>>>
>>> Of course, if we had relesed Wicket 8 with CGLIB in it, this problem
>>> would still exist, and perhaps Wicket 8 would be a short lived
>>> maintained version if we were forced to remove our dependency on CGLIB
>>> (which is unclear at the moment)
>>>
>>> Martijn
>>>
>
>
Re: [DISCUSSION] Wicket 8 Release
Posted by Maxim Solodovnik <so...@gmail.com>.
Browser versions topic seems to be popular so here are some stats
Wicket 8.0.0M1 was release Jul 2016 [1]
Since then Google Chrome has changed 15 major releases [2]
This seems to be common practice right now ...
Maybe it worth to release more often?
[1] http://mvnrepository.com/artifact/org.apache.wicket/wicket-core
[2] https://en.wikipedia.org/wiki/Google_Chrome_version_history
On Tue, Apr 10, 2018 at 7:48 PM, Andrea Del Bene <an...@gmail.com> wrote:
> The issue with CGLIB looks serious, but I don't think we should postpone
> Wicket 8 because of it. Wicket 8 has already a lot of API changes and new
> features and moving away from CGLIB would further complicate the migration
> path. In addition, I guess it won't be a simple task to get rid of CGLIB,
> so I don't see any reason to not release Wicket 8 while we work on this
> delicate issue.
>
> My 2 cents.
>
> On Tue, Apr 10, 2018 at 2:22 PM, Martijn Dashorst <
> martijn.dashorst@gmail.com> wrote:
>
>> On Tue, Apr 10, 2018 at 2:09 PM, Maxim Solodovnik <so...@gmail.com>
>> wrote:
>> > Current version is Java 10 (non LTS)
>> > Maybe we can release 8.0.0 and add this to Wicket 9 ?
>> >
>>
>> The issue is that you can't upgrade to Java 11 when you are running
>> CGLIB due to its use of sun.misc.Unsafe.
>>
>> This will cause problems. I'd rather ensure we have a good path
>> forward, and Java 11 is in september. We can't break API in 8.x so we
>> are stuck with CGLIB apis we expose.
>>
>> Unfortunately CGLIB usage is not private/internal to wicket itself but
>> is exposed in a couple public APIs.
>>
>> Of course, if we had relesed Wicket 8 with CGLIB in it, this problem
>> would still exist, and perhaps Wicket 8 would be a short lived
>> maintained version if we were forced to remove our dependency on CGLIB
>> (which is unclear at the moment)
>>
>> Martijn
>>
--
WBR
Maxim aka solomax
Re: [DISCUSSION] Wicket 8 Release
Posted by Andrea Del Bene <an...@gmail.com>.
The issue with CGLIB looks serious, but I don't think we should postpone
Wicket 8 because of it. Wicket 8 has already a lot of API changes and new
features and moving away from CGLIB would further complicate the migration
path. In addition, I guess it won't be a simple task to get rid of CGLIB,
so I don't see any reason to not release Wicket 8 while we work on this
delicate issue.
My 2 cents.
On Tue, Apr 10, 2018 at 2:22 PM, Martijn Dashorst <
martijn.dashorst@gmail.com> wrote:
> On Tue, Apr 10, 2018 at 2:09 PM, Maxim Solodovnik <so...@gmail.com>
> wrote:
> > Current version is Java 10 (non LTS)
> > Maybe we can release 8.0.0 and add this to Wicket 9 ?
> >
>
> The issue is that you can't upgrade to Java 11 when you are running
> CGLIB due to its use of sun.misc.Unsafe.
>
> This will cause problems. I'd rather ensure we have a good path
> forward, and Java 11 is in september. We can't break API in 8.x so we
> are stuck with CGLIB apis we expose.
>
> Unfortunately CGLIB usage is not private/internal to wicket itself but
> is exposed in a couple public APIs.
>
> Of course, if we had relesed Wicket 8 with CGLIB in it, this problem
> would still exist, and perhaps Wicket 8 would be a short lived
> maintained version if we were forced to remove our dependency on CGLIB
> (which is unclear at the moment)
>
> Martijn
>
Re: [DISCUSSION] Wicket 8 Release
Posted by Martijn Dashorst <ma...@gmail.com>.
On Tue, Apr 10, 2018 at 2:09 PM, Maxim Solodovnik <so...@gmail.com> wrote:
> Current version is Java 10 (non LTS)
> Maybe we can release 8.0.0 and add this to Wicket 9 ?
>
The issue is that you can't upgrade to Java 11 when you are running
CGLIB due to its use of sun.misc.Unsafe.
This will cause problems. I'd rather ensure we have a good path
forward, and Java 11 is in september. We can't break API in 8.x so we
are stuck with CGLIB apis we expose.
Unfortunately CGLIB usage is not private/internal to wicket itself but
is exposed in a couple public APIs.
Of course, if we had relesed Wicket 8 with CGLIB in it, this problem
would still exist, and perhaps Wicket 8 would be a short lived
maintained version if we were forced to remove our dependency on CGLIB
(which is unclear at the moment)
Martijn
Re: [DISCUSSION] Wicket 8 Release
Posted by Maxim Solodovnik <so...@gmail.com>.
Current version is Java 10 (non LTS)
Maybe we can release 8.0.0 and add this to Wicket 9 ?
On Tue, Apr 10, 2018 at 7:06 PM, Martijn Dashorst
<ma...@gmail.com> wrote:
> Ehm,
>
> While perfect is the enemy of shipping, I came across the stuff below.
>
> This article has a good description of the forthcoming issues with
> sun.misc.Unsafe and JDK 11:
>
> https://mydailyjava.blogspot.nl/2018/04/jdk-11-and-proxies-in-world-past.html
>
> As we use CGLIB for our proxy generation in wicket-ioc (and hence
> wicket-spring and wicket-guice), this will affect users of Wicket
> running on JDK 11 in the future.
>
> IMO we should at least make our dependency on CGLIB optional, and add
> support for byte buddy or such, to remove our dependency on
> sun.misc.Unsafe.
>
> As we expose some CGLIB APIs as public in Wicket IOC, this might be a
> breaking change if we opt to remove our dependency on CGLIB
> completely.
>
> I'm working on using Byte Buddy as an alternative IOC implementation.
> However I don't know if I will be able to cover all use cases (not
> sure how good our unit tests are).
>
> Martijn
--
WBR
Maxim aka solomax
Re: [DISCUSSION] Wicket 8 Release
Posted by Martijn Dashorst <ma...@gmail.com>.
Ehm,
While perfect is the enemy of shipping, I came across the stuff below.
This article has a good description of the forthcoming issues with
sun.misc.Unsafe and JDK 11:
https://mydailyjava.blogspot.nl/2018/04/jdk-11-and-proxies-in-world-past.html
As we use CGLIB for our proxy generation in wicket-ioc (and hence
wicket-spring and wicket-guice), this will affect users of Wicket
running on JDK 11 in the future.
IMO we should at least make our dependency on CGLIB optional, and add
support for byte buddy or such, to remove our dependency on
sun.misc.Unsafe.
As we expose some CGLIB APIs as public in Wicket IOC, this might be a
breaking change if we opt to remove our dependency on CGLIB
completely.
I'm working on using Byte Buddy as an alternative IOC implementation.
However I don't know if I will be able to cover all use cases (not
sure how good our unit tests are).
Martijn
Re: [DISCUSSION] Wicket 8 Release
Posted by Tobias Soloschenko <to...@googlemail.com>.
+1 :-)
kind regards
Tobias
> Am 10.04.2018 um 12:36 schrieb Korbinian Bachl <ko...@whiskyworld.de>:
>
> +1 to release
>
>
>
> ----- Ursprüngliche Mail -----
>> Von: "Maxim Solodovnik" <so...@gmail.com>
>> An: dev@wicket.apache.org
>> Gesendet: Dienstag, 3. April 2018 16:36:35
>> Betreff: [DISCUSSION] Wicket 8 Release
>
>> Hello All,
>>
>> I believe it is time to release :)
>> Do we have any blockers?
>>
>> Some non-technical blockers should be already resolved :)))
>>
>> --
>> WBR
>> Maxim aka solomax
Re: [DISCUSSION] Wicket 8 Release
Posted by Korbinian Bachl <ko...@whiskyworld.de>.
+1 to release
----- Ursprüngliche Mail -----
> Von: "Maxim Solodovnik" <so...@gmail.com>
> An: dev@wicket.apache.org
> Gesendet: Dienstag, 3. April 2018 16:36:35
> Betreff: [DISCUSSION] Wicket 8 Release
> Hello All,
>
> I believe it is time to release :)
> Do we have any blockers?
>
> Some non-technical blockers should be already resolved :)))
>
> --
> WBR
> Maxim aka solomax
Re: [DISCUSSION] Wicket 8 Release
Posted by Martin Grigorov <mg...@apache.org>.
+1 to release 8.0.0!
On Wed, Apr 4, 2018 at 12:19 PM, Andrea Del Bene <an...@gmail.com>
wrote:
> I'd like to :))). I think we just need a good announcement and than we can
> go ahead with the release.
>
> PS: since some users have asked for it, I've almost completed a short
> introduction presentation for Wicket. You can find it here:
> https://www.dropbox.com/s/qxt1r2uawffgh8a/quickstart.odp?dl=0
>
> It's not finished yet so you might find some typo or inaccuracy, but I
> think it's nearly completed.
>
> On Tue, Apr 3, 2018 at 4:36 PM, Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > Hello All,
> >
> > I believe it is time to release :)
> > Do we have any blockers?
> >
> > Some non-technical blockers should be already resolved :)))
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
Re: [DISCUSSION] Wicket 8 Release
Posted by Andrea Del Bene <an...@gmail.com>.
I'd like to :))). I think we just need a good announcement and than we can
go ahead with the release.
PS: since some users have asked for it, I've almost completed a short
introduction presentation for Wicket. You can find it here:
https://www.dropbox.com/s/qxt1r2uawffgh8a/quickstart.odp?dl=0
It's not finished yet so you might find some typo or inaccuracy, but I
think it's nearly completed.
On Tue, Apr 3, 2018 at 4:36 PM, Maxim Solodovnik <so...@gmail.com>
wrote:
> Hello All,
>
> I believe it is time to release :)
> Do we have any blockers?
>
> Some non-technical blockers should be already resolved :)))
>
> --
> WBR
> Maxim aka solomax
>