You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/27 19:12:01 UTC

[GitHub] [incubator-mxnet] access2rohit opened a new pull request #17450: skipping tests that cannot fit in nightly CI machine

access2rohit opened a new pull request #17450: skipping tests that cannot fit in nightly CI machine
URL: https://github.com/apache/incubator-mxnet/pull/17450
 
 
   ## Description ##
   skipping following tests as they require memory more than present in nightly CI.
   The main reason is that sacked run of these tests along with other ops doesn't free up memory on time
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ## Tests ##
   ```
   ubuntu@ip-172-31-82-110 ~/incubator-mxnet (array_grouping) $ MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/nightly/test_large_array.py:test_tensor
   /home/ubuntu/anaconda3/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.
   dtype(float).type`.
     from ._conv import register_converters as _register_converters
   test_large_array.test_tensor ... [DEBUG] Setting test np/mx/python random seeds, use MXNET_TEST_SEED=693754677 to reproduce.
   SKIP: Randint flaky, tracked at https://github.com/apache/incubator-mxnet/issues/16172
   
   ----------------------------------------------------------------------
   Ran 1 test in 126.783s
   
   OK (SKIP=1)
   
   MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose
    -s tests/nightly/test_large_array.py:test_nn
   
   /home/ubuntu/anaconda3/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.
   dtype(float).type`.
     from ._conv import register_converters as _register_converters
   test_large_array.test_nn ... [00:18:13] src/executor/graph_executor.cc:2062: Subgraph backend MKLDNN is activated.
   [00:18:17] src/executor/graph_executor.cc:2062: Subgraph backend MKLDNN is activated.
   SKIP: log_softmax flaky, tracked at https://github.com/apache/incubator-mxnet/issues/17397
   
   ----------------------------------------------------------------------
   Ran 1 test in 444.270s
   
   OK (SKIP=1)
   
   MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/nightly/test_large_array.py:test_basic
   
   /home/ubuntu/anaconda3/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.
   dtype(float).type`.
     from ._conv import register_converters as _register_converters
   test_large_array.test_basic ... SKIP: argsort takes lot of memory!, tracked at https://github.com/apache/incubator-mxnet/issues/17411
   
   ----------------------------------------------------------------------
   Ran 1 test in 260.579s
   
   OK (SKIP=1)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] access2rohit commented on issue #17450: skipping tests that cannot fit in nightly CI machine

Posted by GitBox <gi...@apache.org>.
access2rohit commented on issue #17450: skipping tests that cannot fit in nightly CI machine
URL: https://github.com/apache/incubator-mxnet/pull/17450#issuecomment-579123741
 
 
   @mxnet-label-bot add [pr-awaiting-review]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] apeforest merged pull request #17450: skipping tests that cannot fit in nightly CI machine

Posted by GitBox <gi...@apache.org>.
apeforest merged pull request #17450: skipping tests that cannot fit in nightly CI machine
URL: https://github.com/apache/incubator-mxnet/pull/17450
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] access2rohit commented on issue #17450: skipping tests that cannot fit in nightly CI machine

Posted by GitBox <gi...@apache.org>.
access2rohit commented on issue #17450: skipping tests that cannot fit in nightly CI machine
URL: https://github.com/apache/incubator-mxnet/pull/17450#issuecomment-579544830
 
 
   @mxnet-label-bot update [pr-awaiting-merge]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #17450: skipping tests that cannot fit in nightly CI machine

Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #17450: skipping tests that cannot fit in nightly CI machine
URL: https://github.com/apache/incubator-mxnet/pull/17450#discussion_r371992195
 
 

 ##########
 File path: tests/nightly/test_large_array.py
 ##########
 @@ -689,6 +693,7 @@ def check_pick():
         res = mx.nd.pick(a, b)
         assert res.shape == b.shape
 
+    @unittest.skip("Memory doesn't free up after stacked execution with other ops, tracked at https://github.com/apache/incubator-mxnet/issues/17411")
 
 Review comment:
   aah ... got it ! Will do

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #17450: skipping tests that cannot fit in nightly CI machine

Posted by GitBox <gi...@apache.org>.
apeforest commented on a change in pull request #17450: skipping tests that cannot fit in nightly CI machine
URL: https://github.com/apache/incubator-mxnet/pull/17450#discussion_r371991483
 
 

 ##########
 File path: tests/nightly/test_large_array.py
 ##########
 @@ -689,6 +693,7 @@ def check_pick():
         res = mx.nd.pick(a, b)
         assert res.shape == b.shape
 
+    @unittest.skip("Memory doesn't free up after stacked execution with other ops, tracked at https://github.com/apache/incubator-mxnet/issues/17411")
 
 Review comment:
   this line is too long. please break it to meet PEP8 style

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] access2rohit commented on issue #17450: skipping tests that cannot fit in nightly CI machine

Posted by GitBox <gi...@apache.org>.
access2rohit commented on issue #17450: skipping tests that cannot fit in nightly CI machine
URL: https://github.com/apache/incubator-mxnet/pull/17450#issuecomment-579123848
 
 
   @apeforest @ChaiBapchya PR ready for review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services