You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/21 12:59:51 UTC

[GitHub] [cloudstack] Pearl1594 opened a new pull request, #6296: xen: Fix volume snapshot deletion when it has child snapshots

Pearl1594 opened a new pull request, #6296:
URL: https://github.com/apache/cloudstack/pull/6296

   ### Description
   
   This PR fixes the constant test failure noticed on test_list_ids_parameter.py on xenserver :
   https://github.com/apache/cloudstack/pull/5811#issuecomment-1104053583
   The reason for the failure is that on 4.17, when attempting to delete a snapshot that has child snapshots, it fails deletion of the snapshot altogether. In addition to this, an NPE occurs when displaying the details of the child snapshot due to incorrect snapshot id used to get the details.
   
   ```
   2022-04-21 04:47:42,145 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-47:ctx-ef3948e6 job-63 ctx-144c6c26) (logid:a43f2bcd) Deleting SnapshotTO[datastore=com.cloud.agent.api.to.NfsTO@75866c9d|volume=volumeTO[uuid=c1aaba2a-396e-4979-9793-8d54b906ecf5|path=7e848981-a142-4b6f-8ed8-ec8ab4f84f26|datastore=PrimaryDataStoreTO[uuid=637af10e-5a12-32a8-a2cb-47d34d1e710a|name=ref-trl-2887-x-M7-pearl-dsilva-xs-pri2|id=2|pooltype=NetworkFilesystem]]|pathsnapshots/5/5/7136e5ad-971e-41c3-8166-cddebdf7554a.vhd] chain of snapshots.
   2022-04-21 04:47:42,147 ERROR [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-47:ctx-ef3948e6 job-63 ctx-144c6c26) (logid:a43f2bcd) Failed to delete snapshot [SnapshotTO[datastore=com.cloud.agent.api.to.NfsTO@75866c9d|volume=volumeTO[uuid=c1aaba2a-396e-4979-9793-8d54b906ecf5|path=7e848981-a142-4b6f-8ed8-ec8ab4f84f26|datastore=PrimaryDataStoreTO[uuid=637af10e-5a12-32a8-a2cb-47d34d1e710a|name=ref-trl-2887-x-M7-pearl-dsilva-xs-pri2|id=2|pooltype=NetworkFilesystem]]|pathsnapshots/5/5/7136e5ad-971e-41c3-8166-cddebdf7554a.vhd]] on storage [secondary storage {uuid: "5b3f46d0-4185-4144-9d3d-0ca6f4232d39", name: "NFS://10.0.32.4/acs/secondary/ref-trl-2887-x-M7-pearl-dsilva/ref-trl-2887-x-M7-pearl-dsilva-sec1"}] due to [null].
   java.lang.NullPointerException
           at org.apache.cloudstack.storage.snapshot.SnapshotObject.getId(SnapshotObject.java:192)
           at org.apache.cloudstack.storage.datastore.ObjectInDataStoreManagerImpl.findObject(ObjectInDataStoreManagerImpl.java:354)
           at org.apache.cloudstack.storage.snapshot.SnapshotObject.getPath(SnapshotObject.java:251)
           at org.apache.cloudstack.storage.to.SnapshotObjectTO.<init>(SnapshotObjectTO.java:52)
           at org.apache.cloudstack.storage.snapshot.SnapshotObject.getTO(SnapshotObject.java:327)
           at org.apache.cloudstack.storage.snapshot.DefaultSnapshotStrategy.deleteSnapshotChain(DefaultSnapshotStrategy.java:193)
           at org.apache.cloudstack.storage.snapshot.DefaultSnapshotStrategy.deleteSnapshotInfo(DefaultSnapshotStrategy.java:331)
           at org.apache.cloudstack.storage.snapshot.DefaultSnapshotStrategy.deleteSnapshotInfos(DefaultSnapshotStrategy.java:306)
           at org.apache.cloudstack.storage.snapshot.DefaultSnapshotStrategy.destroySnapshotEntriesAndFiles(DefaultSnapshotStrategy.java:285)
           at org.apache.cloudstack.storage.snapshot.DefaultSnapshotStrategy.deleteSnapshot(DefaultSnapshotStrategy.java:277)
           at com.cloud.storage.snapshot.SnapshotManagerImpl.deleteSnapshot(SnapshotManagerImpl.java:606)
           at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
           at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
           at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
           at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   
   ```
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   1. Successfully run the smoke test - test_list_ids_parameter.py
   2. Created 2 snapshots from the same volume, and attempted to delete the parent snapshot, while it fails (as expected) - it no longer throws an NPE.
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105221581

   ## PR Coverage Report
   |**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
   |-----|-----|-----|-----|-----|-----|-----|
   |SnapshotObject|748|30|64|0|151|11|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105352637

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3261


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez merged pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105937395

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] Pearl1594 commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105987329

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105988478

   @Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105968119

   @Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105207511

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] Pearl1594 commented on a diff in pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on code in PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#discussion_r855191469


##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotObject.java:
##########
@@ -127,7 +127,7 @@ public SnapshotInfo getChild() {
         if (vo == null) {
             return null;
         }
-        return snapshotFactory.getSnapshot(vo.getId(), store);
+        return snapshotFactory.getSnapshot(vo.getSnapshotId(), store);

Review Comment:
   Actually Yes , however, it's usage comes into play only cleanup logic :
   1. where in it decides whether to cleanup the snapshot on the secondary store or not 
   2. When there are snapshots in destroyed state and the garbage collector kicks in, so the impact of this hasn't been big.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105415405

   <b>Trillian Build Failed (tid-3971)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105297971

   @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez closed pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots
URL: https://github.com/apache/cloudstack/pull/6296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1106705097

   <b>Trillian test result (tid-3983)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45013 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6296-t3983-vmware-65u2.zip
   Smoke tests completed. 96 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1106664622

   <b>Trillian test result (tid-3981)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41593 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6296-t3981-xenserver-71.zip
   Smoke tests completed. 96 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105363869

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] Pearl1594 commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105967529

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#discussion_r855162285


##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotObject.java:
##########
@@ -127,7 +127,7 @@ public SnapshotInfo getChild() {
         if (vo == null) {
             return null;
         }
-        return snapshotFactory.getSnapshot(vo.getId(), store);
+        return snapshotFactory.getSnapshot(vo.getSnapshotId(), store);

Review Comment:
   @Pearl1594 
   this looks like a critical issue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105366798

   @nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105983703

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 3266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105990880

   <b>Trillian Build Failed (tid-3982)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105951098

   @nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] Pearl1594 commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105180178

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1106670002

   <b>Trillian test result (tid-3984)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41161 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6296-t3984-kvm-centos7.zip
   Smoke tests completed. 96 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6296: xen: Fix volume snapshot deletion when it has child snapshots

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6296:
URL: https://github.com/apache/cloudstack/pull/6296#issuecomment-1105294864

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org