You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Isaac Hebsh (JIRA)" <ji...@apache.org> on 2013/07/11 20:33:51 UTC

[jira] [Created] (SOLR-5035) decouple grouping functionality from the query component

Isaac Hebsh created SOLR-5035:
---------------------------------

             Summary: decouple grouping functionality from the query component
                 Key: SOLR-5035
                 URL: https://issues.apache.org/jira/browse/SOLR-5035
             Project: Solr
          Issue Type: Improvement
          Components: search
    Affects Versions: 4.3.1
            Reporter: Isaac Hebsh


Currently, all of the grouping work is coupled into the QueryComponent. It seems that we can split the component into two different components, without writing even one extra line of code.

Best example is, in method 'prepare' of the QueryComponent:
{code:java}
boolean grouping = params.getBool(GroupParams.GROUP, false);
if (!grouping) {
    return;
}
{code}

This is clearly unnecessary coupling...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org