You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Brandon Li (JIRA)" <ji...@apache.org> on 2012/09/16 04:28:07 UTC
[jira] [Created] (HADOOP-8815) RandomDatum overrides equals(Object)
but no hashCode()
Brandon Li created HADOOP-8815:
----------------------------------
Summary: RandomDatum overrides equals(Object) but no hashCode()
Key: HADOOP-8815
URL: https://issues.apache.org/jira/browse/HADOOP-8815
Project: Hadoop Common
Issue Type: Improvement
Components: test
Affects Versions: 3.0.0
Reporter: Brandon Li
Assignee: Brandon Li
Priority: Minor
Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8815) RandomDatum overrides
equals(Object) but no hashCode()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462746#comment-13462746 ]
Hudson commented on HADOOP-8815:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1207 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1207/])
HADOOP-8815. RandomDatum needs to override hashCode(). Contributed by Brandon Li. (Revision 1389661)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389661
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/RandomDatum.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8815.patch, HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8815) RandomDatum overrides
equals(Object) but no hashCode()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456600#comment-13456600 ]
Hadoop QA commented on HADOOP-8815:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545299/HADOOP-8815.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1473//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1473//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1473//console
This message is automatically generated.
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8815) RandomDatum overrides equals(Object)
but no hashCode()
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8815:
-------------------------------
Status: Patch Available (was: Open)
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8815) RandomDatum overrides
equals(Object) but no hashCode()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462334#comment-13462334 ]
Hudson commented on HADOOP-8815:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2787 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2787/])
HADOOP-8815. RandomDatum needs to override hashCode(). Contributed by Brandon Li. (Revision 1389661)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389661
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/RandomDatum.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8815.patch, HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8815) RandomDatum overrides
equals(Object) but no hashCode()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462413#comment-13462413 ]
Hudson commented on HADOOP-8815:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2828 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2828/])
HADOOP-8815. RandomDatum needs to override hashCode(). Contributed by Brandon Li. (Revision 1389661)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389661
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/RandomDatum.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8815.patch, HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8815) RandomDatum overrides
equals(Object) but no hashCode()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462714#comment-13462714 ]
Hudson commented on HADOOP-8815:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1176 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1176/])
HADOOP-8815. RandomDatum needs to override hashCode(). Contributed by Brandon Li. (Revision 1389661)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389661
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/RandomDatum.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8815.patch, HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8815) RandomDatum overrides equals(Object)
but no hashCode()
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8815:
------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I committed the patch. Thank you Brandon.
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8815.patch, HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8815) RandomDatum overrides equals(Object)
but no hashCode()
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8815:
-------------------------------
Attachment: HADOOP-8815.patch
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8815.patch, HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8815) RandomDatum overrides
equals(Object) but no hashCode()
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462018#comment-13462018 ]
Brandon Li commented on HADOOP-8815:
------------------------------------
Thanks! Uploaded a new patch with recommended hashcode implementation.
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8815.patch, HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8815) RandomDatum overrides
equals(Object) but no hashCode()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462417#comment-13462417 ]
Hudson commented on HADOOP-8815:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2765 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2765/])
HADOOP-8815. RandomDatum needs to override hashCode(). Contributed by Brandon Li. (Revision 1389661)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389661
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/RandomDatum.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-8815.patch, HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8815) RandomDatum overrides
equals(Object) but no hashCode()
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461951#comment-13461951 ]
Suresh Srinivas commented on HADOOP-8815:
-----------------------------------------
Why are you returning 0 in hashcode? Why not Arrays.hashcode(this.data)?
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8815) RandomDatum overrides
equals(Object) but no hashCode()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462047#comment-13462047 ]
Hadoop QA commented on HADOOP-8815:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12546362/HADOOP-8815.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1509//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1509//console
This message is automatically generated.
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8815.patch, HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8815) RandomDatum overrides equals(Object)
but no hashCode()
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8815:
-------------------------------
Attachment: HADOOP-8815.patch
> RandomDatum overrides equals(Object) but no hashCode()
> ------------------------------------------------------
>
> Key: HADOOP-8815
> URL: https://issues.apache.org/jira/browse/HADOOP-8815
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8815.patch
>
>
> Override equal() but not hashCode() is a violation of the general contract for Object.hashCode will occur, which can have unexpected repercussions when this class is in conjunction with all hash-based collections.
> This test class is used in multiple places, so it may be worth fixing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira