[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #5938: Move error check from pipeline fixer to pipeline checker

["comphead (via GitHub)" <gi...@apache.org>]

comphead commented on code in PR #5938:
URL: https://github.com/apache/arrow-datafusion/pull/5938#discussion_r1161878997


##########
datafusion/core/src/physical_optimizer/pipeline_checker.rs:
##########
@@ -314,7 +314,7 @@ mod sql_tests {
                   FROM test
                   LIMIT 5".to_string(),
             cases: vec![Arc::new(test1), Arc::new(test2)],
-            error_operator: "Window Error".to_string()
+            error_operator: "Sort Error".to_string()

Review Comment:
   lgtm, thanks for taking this, why the error message changed to Sort Error, I dont see the respective logic change..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org