[GitHub] [rocketmq] TheR1sing3un commented on a diff in pull request #6122: [ISSUE #6121]: optimize some code style in store module

["TheR1sing3un (via GitHub)" <gi...@apache.org>]

TheR1sing3un commented on code in PR #6122:
URL: https://github.com/apache/rocketmq/pull/6122#discussion_r1111408432


##########
store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAClient.java:
##########
@@ -35,11 +35,26 @@
 
 public class DefaultHAClient extends ServiceThread implements HAClient {
 
+    /**
+     * Report header buffer size. Schema: slaveMaxOffset. Format:
+     *
+     * <pre>
+     * ┌───────────────────────┬───────────────────────┐
+     * │                  slaveMaxOffset               │
+     * │                    (8bytes)                   │
+     * ├───────────────────────┴───────────────────────┤
+     * │                                               │
+     * │                  Report Header                │
+     * </pre>
+     * <p>
+     */
+    public static final int REPORT_HEADER = 8;

Review Comment:
   seems better!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org