[GitHub] [hive] miklosgergely commented on a change in pull request #866: HIVE-22536 Improve return path enabling/disabling

[GitBox <gi...@apache.org>]

miklosgergely commented on a change in pull request #866: HIVE-22536 Improve return path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357652794
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
 ##########
 @@ -464,7 +464,7 @@ Operator genOPTree(ASTNode ast, PlannerContext plannerCtx) throws SemanticExcept
           // 0. Gen Optimized Plan
           RelNode newPlan = logicalPlan();
 
-          if (this.conf.getBoolVar(HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP)) {
+          if (ReturnPathManager.shouldUse()) {
             if (cboCtx.type == PreCboCtx.Type.VIEW && !materializedView) {
 
 Review comment:
   I don't understand this, the line here is to decide if we'd use the "return path way" or the "non return path way". What are your referring to here as failing?
   
   My concept was that in case of "supported" we decide between these two by applying some logic that decides whether the actual command is in the supported set of commands that are already handled properly with return path, or not. If it is in it, then it works the same way as "true", if it is not, then it works the same way as "false".
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org