You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2015/08/14 05:12:59 UTC
[GitHub] tajo pull request: TAJO-1761: Separate an integration unit test ki...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/690
TAJO-1761: Separate an integration unit test kit into an independent module.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1761
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #690
----
commit 44f5b341c3ce54cd1e88b9033a1d8a2f3b29582f
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-08-14T01:45:41Z
add maven module for cluster tests.
commit 4d52eea781e09a5caff40a283cf9b59861bb0b93
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-08-14T03:10:52Z
TAJO-1761: Separate an integration unit test kit into an independent module.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1761: Separate an integration unit test ki...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/690#issuecomment-131028793
+1 LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1761: Separate an integration unit test ki...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/690#issuecomment-130996807
Thanks @hyunsik. This patch is simple and good. I have two comments.
* Please fix the indent of BackendTestingUtil.
* core/pom.xml should not include dependencies on packages required for tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1761: Separate an integration unit test ki...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/690#issuecomment-130952114
rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1761: Separate an integration unit test ki...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/690
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---