You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/10 11:30:00 UTC

[jira] [Commented] (IGNITE-7203) Java 8 by default

    [ https://issues.apache.org/jira/browse/IGNITE-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320107#comment-16320107 ] 

ASF GitHub Bot commented on IGNITE-7203:
----------------------------------------

GitHub user vveider opened a pull request:

    https://github.com/apache/ignite/pull/3348

    IGNITE-7203 Java 8 by default

     * further improved AOP test behaviour by moving javaagent call into pom.xml
    .NET: Fix WindowsServiceTest - pass JVM path to the service
    .NET: Another attempt to fix WindowsServiceTest, adding logger, no idea what the problem is
    .NET: Another attempt to fix WindowsServiceTest
    .NET: Another attempt to fix WindowsServiceTest
    .NET: Another attempt to fix WindowsServiceTest
    IGNITE-7203 Java 8 by default
     * replaced aspectj dependency with newest one for attempt to fix AOP tests
    Attempty to fix AOP failure.
    .NET: Fix TestStopFromJava
    .NET: Fix ExecutableTest
    IGNITE-7203 Java 8 by default
    IGNITE-7216 Refactor examples project
     * fixed notes from review
    IGNITE-7203 Java 8 by default
    IGNITE-7216 Refactor examples project
     * refactored examples module and ml part of other modules: merged java8 and java packages
    IGNITE-7203 Java 8 by default
     * got rid of java-1.8 related profiles
     * remove ml profile and included ml build into main reactor
     * added master properties to maven-compiler-plugin for whole project to be compiled only by java-1.8
     * refactored met properties + gathered them in parent module

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-7203-review

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/3348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3348
    
----
commit 5d40edbdb6b4b8a5d84485b474e88a03660a21cb
Author: Ivanov Petr <pi...@...>
Date:   2018-01-10T11:27:15Z

    IGNITE-7203 Java 8 by default
     * further improved AOP test behaviour by moving javaagent call into pom.xml
    .NET: Fix WindowsServiceTest - pass JVM path to the service
    .NET: Another attempt to fix WindowsServiceTest, adding logger, no idea what the problem is
    .NET: Another attempt to fix WindowsServiceTest
    .NET: Another attempt to fix WindowsServiceTest
    .NET: Another attempt to fix WindowsServiceTest
    IGNITE-7203 Java 8 by default
     * replaced aspectj dependency with newest one for attempt to fix AOP tests
    Attempty to fix AOP failure.
    .NET: Fix TestStopFromJava
    .NET: Fix ExecutableTest
    IGNITE-7203 Java 8 by default
    IGNITE-7216 Refactor examples project
     * fixed notes from review
    IGNITE-7203 Java 8 by default
    IGNITE-7216 Refactor examples project
     * refactored examples module and ml part of other modules: merged java8 and java packages
    IGNITE-7203 Java 8 by default
     * got rid of java-1.8 related profiles
     * remove ml profile and included ml build into main reactor
     * added master properties to maven-compiler-plugin for whole project to be compiled only by java-1.8
     * refactored met properties + gathered them in parent module

----


> Java 8 by default
> -----------------
>
>                 Key: IGNITE-7203
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7203
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Anton Vinogradov
>            Assignee: Peter Ivanov
>              Labels: important
>             Fix For: 2.4
>
>
> We should drop Java 7 support.
> 1) We should 
> - get rid of java8 profiles
> - relocate tests and sources with *.java8.* package to regular sources
> - set 
> {noformat}
>  <source>1.8</source>
>  <target>1.8</target>
> {noformat} 
> by default
> 2) Release process
> https://ci.ignite.apache.org/project.html?projectId=AssemblyAndRelease
> should be updated if necessary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)