You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "egalpin (via GitHub)" <gi...@apache.org> on 2023/04/27 16:11:58 UTC
[GitHub] [pinot] egalpin opened a new pull request, #10693: Fixes partial upsert not reflecting multiple comparison column values
egalpin opened a new pull request, #10693:
URL: https://github.com/apache/pinot/pull/10693
cc: @KKcorps @Jackie-Jiang
Without this fix, if using multiple comparison columns it's likely that any server restart will result in an overall different representation of data.
Presently, comparison columns are skipped in partial upsert handler. This behaviour needs to be changed in order to support merging of any prior comparison column value which is null for the inbound record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10693: Fixes partial upsert not reflecting multiple comparison column values
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10693:
URL: https://github.com/apache/pinot/pull/10693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10693: Fixes partial upsert not reflecting multiple comparison column values
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10693:
URL: https://github.com/apache/pinot/pull/10693#issuecomment-1526052730
## [Codecov](https://codecov.io/gh/apache/pinot/pull/10693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10693](https://codecov.io/gh/apache/pinot/pull/10693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6a7452a) into [master](https://codecov.io/gh/apache/pinot/commit/d806b5f8f2750fa5611584537ae1451b332f649f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d806b5f) will **increase** coverage by `1.79%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 6a7452a differs from pull request most recent head 35a4883. Consider uploading reports for the commit 35a4883 to get more accurate results
```diff
@@ Coverage Diff @@
## master #10693 +/- ##
============================================
+ Coverage 68.44% 70.24% +1.79%
- Complexity 6421 6429 +8
============================================
Files 2107 2107
Lines 113792 113793 +1
Branches 17199 17200 +1
============================================
+ Hits 77887 79930 +2043
+ Misses 30369 28271 -2098
- Partials 5536 5592 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.31% <0.00%> (-0.12%)` | :arrow_down: |
| integration2 | `23.94% <0.00%> (?)` | |
| unittests1 | `67.75% <100.00%> (+0.01%)` | :arrow_up: |
| unittests2 | `13.86% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/10693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...not/segment/local/upsert/PartialUpsertHandler.java](https://codecov.io/gh/apache/pinot/pull/10693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC91cHNlcnQvUGFydGlhbFVwc2VydEhhbmRsZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
... and [171 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10693/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org