You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flink.apache.org by Jingsong Li <ji...@gmail.com> on 2022/04/29 02:24:09 UTC

[VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Hi everyone,

Please review and vote on the release candidate #2 for the version 0.1.0 of
Apache Flink Table Store, as follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

**Release Overview**

As an overview, the release consists of the following:
a) Table Store canonical source distribution, to be deployed to the
release repository at dist.apache.org
b) Maven artifacts to be deployed to the Maven Central Repository

**Staging Areas to Review**

The staging areas containing the above mentioned artifacts are as follows,
for your review:
* All artifacts for a) and b) can be found in the corresponding dev
repository at dist.apache.org [2]
* All artifacts for c) can be found at the Apache Nexus Repository [3]
* Pre Bundled Binaries Jar can work fine with quick start [4][5]

All artifacts are signed with the key
2C2B6A653B07086B65E4369F7C76245E0A318150 [6]

Other links for your review:
* JIRA release notes [7]
* source code tag "release-0.1.0-rc2" [8]
* PR to update the website Downloads page to include Table Store
links [9]

**Vote Duration**

The voting time will run for at least 72 hours.
It is adopted by majority approval, with at least 3 PMC affirmative votes.

Best,
Jingsong Lee

[1] https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
[2] https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
[3] https://repository.apache.org/content/repositories/orgapacheflink-1502/
[4] https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
[5] https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
[6] https://dist.apache.org/repos/dist/release/flink/KEYS
[7] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
[8] https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
[9] https://github.com/apache/flink-web/pull/531

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Jingsong Li <ji...@gmail.com>.

Hi all,

Thanks for your review on flink-web PR.
I have resolved comments, please take a look if you have time~

Hi Becket and Yu,
About quick-start, I created a JIRA to improve:
https://issues.apache.org/jira/browse/FLINK-27548

Hi Yun, thanks for your PR, I have merged it.

Best,
Jingsong

On Mon, May 9, 2022 at 12:22 PM Jark Wu <im...@gmail.com> wrote:
>
> Thank Jingsong for the explanation.
>
> +1(binding) from my side.
>
> Best,
> Jark
>
> On Mon, 9 May 2022 at 11:37, Jingsong Li <ji...@gmail.com> wrote:
>
> > Hi Jark,
> >
> > > I have checked the LICENSE and NOTICE files but found that the uber jar
> > (flink-table-store-dist) doesn't provide an appropriate NOTICE file to
> > list the bundled
> > dependencies.
> >
> > Because the dependencies typed in by flink-table-store-dist are all
> > dependencies of flink-sql-jar, they already contain NOTICE files, and
> > all dependent NOTICE files will be merged during the shade process, so
> > the final dist-jar is the one containing NOTICE dependencies.
> >
> > Best,
> > Jingsong
> >
> > On Sun, May 8, 2022 at 12:50 AM Jark Wu <im...@gmail.com> wrote:
> > >
> > > Hi all,
> > >
> > > I have checked the LICENSE and NOTICE files but found that the uber jar
> > > (flink-table-store-dist)
> > >  doesn't provide an appropriate NOTICE file to list the bundled
> > > dependencies.
> > >
> > > I checked the license guideline [1], and it says:
> > > > For Maven artifacts that DO bundle (usually through the
> > > maven-shade-plugin)
> > > > any dependencies the NOTICE file can be found in the
> > > src/main/resources/META-INF
> > > > directory of the respective module. If the module does not have a
> > NOTICE
> > > file yet,
> > > > then add one under src/main/resources/META-INF.
> > > and
> > > > All bundled dependencies must be listed in NOTICE, grouped by license
> > > type,
> > > > using standard maven syntax (groupId:artifactId:version).
> > > > This DOES include ASLv2 dependencies
> > >
> > > This DOES include ASLv2 dependencies (for maintainability reasons, as it
> > > simplifies matching of entries in the dependency-tree and NOTICE files)
> > >
> > > I'm not sure whether this would block the release or not.
> > > It would be great if @Chesnay Schepler <ch...@apache.org> could help
> > to
> > > check this.
> > >
> > > Others look good to me:
> > > - build and compile the source code locally. OK
> > > - checked/verified signatures and hashes, OK
> > > - no missing artifacts in the release staging area. OK
> > > - reviewed the release PR. OK
> > > - ran the quick start in local. looks good
> > >
> > > Best,
> > > Jark
> > >
> > > [1]: https://cwiki.apache.org/confluence/display/FLINK/Licensing
> > >
> > > On Sat, 7 May 2022 at 17:30, Yun Tang <my...@live.com> wrote:
> > >
> > > > First of all, thanks for Jinsong to drive this. I checked the
> > following:
> > > >
> > > >
> > > >   *   Reviewed the PR of release note.
> > > >   *   Build the package from the scratch: OK
> > > >   *   Check that the README.md file does not have anything unexpected:
> > > > *seems not OK*
> > > >
> > > > I noticed that current README actually does not give correct
> > description
> > > > of how to build and get the expected jar package, and I created a PR
> > [1] to
> > > > resolve this.
> > > >
> > > > [1] https://github.com/apache/flink-table-store/pull/112
> > > >
> > > > Best
> > > > Yun Tang
> > > > ________________________________
> > > > From: Yu Li <ca...@gmail.com>
> > > > Sent: Saturday, May 7, 2022 17:20
> > > > To: dev <de...@flink.apache.org>
> > > > Subject: Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate
> > #2
> > > >
> > > > +1 (binding)
> > > >
> > > > - Checked release notes: *OK*
> > > > - Checked sums and signatures: *OK*
> > > > - Checked the jars in the staging repo: *OK*
> > > > - Checked source distribution doesn't include binaries: *OK*
> > > > - Maven clean install from source: *OK*
> > > > - Checked version consistency in pom files: *OK*
> > > > - Went through the quick start: *OK*
> > > >    - Minor: the set 'table-store.path' was not fully cleaned up after
> > > > dropping the table and exiting the sql client shell, please check
> > whether
> > > > this is expected behavior.
> > > > - Checked the website updates: *OK*
> > > >   - Note: left some suggestions, please check.
> > > >
> > > > Thanks for driving this release, Jingsong!
> > > >
> > > > Best Regards,
> > > > Yu
> > > >
> > > >
> > > > On Sat, 7 May 2022 at 15:30, Becket Qin <be...@gmail.com> wrote:
> > > >
> > > > > Hi Jingsong,
> > > > >
> > > > > Thanks for driving the very first release of the flink-table-store!
> > > > >
> > > > > +1 (binding) for the RC.
> > > > >
> > > > > I verified the following:
> > > > > - the signature of the artifacts
> > > > > - the source jar does not contain binary files
> > > > > - no accidental distribution of other projects is included in the
> > dist
> > > > jar
> > > > > - went through the quick start
> > > > > - compiled the code locally
> > > > >
> > > > > There were two things that are not blockers but might worth noting:
> > > > > 1. Running the verification requires docker installation. It happens
> > > > that I
> > > > > do not have that installed on my new laptop.
> > > > > 2. In the quick start, after dropping the word_count table, the
> > Flink job
> > > > > that inserts data into the word_count table will keep failover. And
> > this
> > > > > job won't exit after SQL Client exits. It is not a problem of
> > > > > flink-table-store, but it might be non-intuitive for some of the
> > users.
> > > > >
> > > > > I also left some comment in the PR of release announcement.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Jiangjie (Becket) Qin
> > > > >
> > > > > On Thu, May 5, 2022 at 5:39 PM Jingsong Li <ji...@gmail.com>
> > > > wrote:
> > > > >
> > > > > > Hi, Konstantin and OpenInx,
> > > > > >
> > > > > > I have updated https://github.com/apache/flink-web/pull/531 , you
> > can
> > > > > > take a review~
> > > > > >
> > > > > > Best,
> > > > > > Jingsong
> > > > > >
> > > > > > On Thu, May 5, 2022 at 3:07 PM OpenInx <op...@gmail.com> wrote:
> > > > > > >
> > > > > > > +1 ( non-binding) for the release. I agree with Konstantin that
> > we
> > > > can
> > > > > > add
> > > > > > > more materials about the table-store for the voting.
> > > > > > >
> > > > > > >
> > > > > > >    1. Download the source tarball, signature (.asc), and checksum
> > > > > > >    (.sha512):   OK
> > > > > > >    2. Import gpg keys: download KEYS and run gpg --import
> > > > > > >    /path/to/downloaded/KEYS (optional if this hasn’t changed) :
> > OK
> > > > > > >    3. Verify the signature by running: gpg --verify
> > > > > > >    flink-table-store-0.1.0-src.tgz.asc:  OK
> > > > > > >    4. Verify the checksum by running: shasum -a 256 -c
> > > > > > >    flink-table-store-0.1.0-src.tgz.sha512
> > > > > > flink-table-store-0.1.0-src.tgz :  OK
> > > > > > >    5. Untar the archive and go into the source directory: tar xzf
> > > > > > >    flink-table-store-0.1.0-src.tgz && cd
> > flink-table-store-0.1.0:  OK
> > > > > > >    6. Build and test the project: mvn clean package (use Java 8)
> > :
> > > > >  All
> > > > > > >    unit tests passed, except the e2e tests. Seems we will need
> > to set
> > > > > up
> > > > > > a
> > > > > > >    docker environment to run those e2e tests successfully.
> > > > > > >    7. Verify the apache flink access table store:
> > > > > > >
> > > > > > > ./bin/sql-client.sh -j
> > > > > > >
> > > > > >
> > > > >
> > > >
> > /Users/openinx/Downloads/flink-table-store-0.1.0/flink-table-store-dist/target/flink-table-store-dist-0.1.0.jar
> > > > > > > embedded shell
> > > > > > >
> > > > > > > SET 'table-store.path' = '/Users/openinx/test/table-store' ;
> > > > > > >
> > > > > > > SET 'execution.runtime-mode'='batch';
> > > > > > >
> > > > > > > SET 'sql-client.execution.result-mode' = 'tableau';
> > > > > > >
> > > > > > > CREATE TABLE MyTable (
> > > > > > >
> > > > > > > user_id BIGINT,
> > > > > > >
> > > > > > > item_id BIGINT,
> > > > > > >
> > > > > > > behavior STRING,
> > > > > > >
> > > > > > > dt STRING,
> > > > > > >
> > > > > > > PRIMARY KEY (dt, user_id) NOT ENFORCED
> > > > > > >
> > > > > > > ) PARTITIONED BY (dt) WITH (
> > > > > > >
> > > > > > > 'bucket' = '4'
> > > > > > >
> > > > > > > );
> > > > > > >
> > > > > > > INSERT INTO MyTable VALUES
> > > > > > >
> > > > > > > (100, 200, 'buy', '2022-05-04'),
> > > > > > >
> > > > > > > (101, 201, 'save', '2022-05-04'),
> > > > > > >
> > > > > > > (101, 201, 'purchase', '2022-05-04');
> > > > > > >
> > > > > > >
> > > > > > > SELECT * FROM MyTable;
> > > > > > >
> > > > > > > +---------+---------+----------+------------+
> > > > > > >
> > > > > > > | user_id | item_id | behavior | dt |
> > > > > > >
> > > > > > > +---------+---------+----------+------------+
> > > > > > >
> > > > > > > | 100 | 200 | buy | 2022-05-04 |
> > > > > > >
> > > > > > > | 101 | 201 | purchase | 2022-05-04 |
> > > > > > >
> > > > > > > +---------+---------+----------+------------+
> > > > > > >
> > > > > > > 2 rows in set
> > > > > > >
> > > > > > > On Thu, May 5, 2022 at 2:39 PM Nicholas Jiang <
> > > > > nicholasjiang@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hi everyone,
> > > > > > > >
> > > > > > > > +1 for the release (non-binding).
> > > > > > > >
> > > > > > > > - Built and compiled source codes [PASSED]
> > > > > > > > - Went through quick start guide [PASSED]
> > > > > > > > - Checked README.md [PASSED]
> > > > > > > > - Checked that use the table store jar to build query table
> > > > > application
> > > > > > > > [PASSED]
> > > > > > > >
> > > > > > > > Best regards,
> > > > > > > >
> > > > > > > > Nicholas Jiang
> > > > > > > >
> > > > > > > > On 2022/04/29 02:24:09 Jingsong Li wrote:
> > > > > > > > > Hi everyone,
> > > > > > > > >
> > > > > > > > > Please review and vote on the release candidate #2 for the
> > > > version
> > > > > > 0.1.0
> > > > > > > > of
> > > > > > > > > Apache Flink Table Store, as follows:
> > > > > > > > >
> > > > > > > > > [ ] +1, Approve the release
> > > > > > > > > [ ] -1, Do not approve the release (please provide specific
> > > > > comments)
> > > > > > > > >
> > > > > > > > > **Release Overview**
> > > > > > > > >
> > > > > > > > > As an overview, the release consists of the following:
> > > > > > > > > a) Table Store canonical source distribution, to be deployed
> > to
> > > > the
> > > > > > > > > release repository at dist.apache.org
> > > > > > > > > b) Maven artifacts to be deployed to the Maven Central
> > Repository
> > > > > > > > >
> > > > > > > > > **Staging Areas to Review**
> > > > > > > > >
> > > > > > > > > The staging areas containing the above mentioned artifacts
> > are as
> > > > > > > > follows,
> > > > > > > > > for your review:
> > > > > > > > > * All artifacts for a) and b) can be found in the
> > corresponding
> > > > dev
> > > > > > > > > repository at dist.apache.org [2]
> > > > > > > > > * All artifacts for c) can be found at the Apache Nexus
> > > > Repository
> > > > > > [3]
> > > > > > > > > * Pre Bundled Binaries Jar can work fine with quick start
> > [4][5]
> > > > > > > > >
> > > > > > > > > All artifacts are signed with the key
> > > > > > > > > 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> > > > > > > > >
> > > > > > > > > Other links for your review:
> > > > > > > > > * JIRA release notes [7]
> > > > > > > > > * source code tag "release-0.1.0-rc2" [8]
> > > > > > > > > * PR to update the website Downloads page to include Table
> > Store
> > > > > > > > > links [9]
> > > > > > > > >
> > > > > > > > > **Vote Duration**
> > > > > > > > >
> > > > > > > > > The voting time will run for at least 72 hours.
> > > > > > > > > It is adopted by majority approval, with at least 3 PMC
> > > > affirmative
> > > > > > > > votes.
> > > > > > > > >
> > > > > > > > > Best,
> > > > > > > > > Jingsong Lee
> > > > > > > > >
> > > > > > > > > [1]
> > > > > > > >
> > > > > >
> > > > >
> > > >
> > https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> > > > > > > > > [2]
> > > > > > > >
> > > > > >
> > > > >
> > > >
> > https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> > > > > > > > > [3]
> > > > > > > >
> > > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1502/
> > > > > > > > > [4]
> > > > > > > >
> > > > > >
> > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> > > > > > > > > [5]
> > > > > > > >
> > > > > >
> > > > >
> > > >
> > https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> > > > > > > > > [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > > > > > > [7]
> > > > > > > >
> > > > > >
> > > > >
> > > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> > > > > > > > > [8]
> > > > > > https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> > > > > > > > > [9] https://github.com/apache/flink-web/pull/531
> > > > > > > > >
> > > > > > > >
> > > > > >
> > > > >
> > > >
> >

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Jark Wu <im...@gmail.com>.

Thank Jingsong for the explanation.

+1(binding) from my side.

Best,
Jark

On Mon, 9 May 2022 at 11:37, Jingsong Li <ji...@gmail.com> wrote:

> Hi Jark,
>
> > I have checked the LICENSE and NOTICE files but found that the uber jar
> (flink-table-store-dist) doesn't provide an appropriate NOTICE file to
> list the bundled
> dependencies.
>
> Because the dependencies typed in by flink-table-store-dist are all
> dependencies of flink-sql-jar, they already contain NOTICE files, and
> all dependent NOTICE files will be merged during the shade process, so
> the final dist-jar is the one containing NOTICE dependencies.
>
> Best,
> Jingsong
>
> On Sun, May 8, 2022 at 12:50 AM Jark Wu <im...@gmail.com> wrote:
> >
> > Hi all,
> >
> > I have checked the LICENSE and NOTICE files but found that the uber jar
> > (flink-table-store-dist)
> >  doesn't provide an appropriate NOTICE file to list the bundled
> > dependencies.
> >
> > I checked the license guideline [1], and it says:
> > > For Maven artifacts that DO bundle (usually through the
> > maven-shade-plugin)
> > > any dependencies the NOTICE file can be found in the
> > src/main/resources/META-INF
> > > directory of the respective module. If the module does not have a
> NOTICE
> > file yet,
> > > then add one under src/main/resources/META-INF.
> > and
> > > All bundled dependencies must be listed in NOTICE, grouped by license
> > type,
> > > using standard maven syntax (groupId:artifactId:version).
> > > This DOES include ASLv2 dependencies
> >
> > This DOES include ASLv2 dependencies (for maintainability reasons, as it
> > simplifies matching of entries in the dependency-tree and NOTICE files)
> >
> > I'm not sure whether this would block the release or not.
> > It would be great if @Chesnay Schepler <ch...@apache.org> could help
> to
> > check this.
> >
> > Others look good to me:
> > - build and compile the source code locally. OK
> > - checked/verified signatures and hashes, OK
> > - no missing artifacts in the release staging area. OK
> > - reviewed the release PR. OK
> > - ran the quick start in local. looks good
> >
> > Best,
> > Jark
> >
> > [1]: https://cwiki.apache.org/confluence/display/FLINK/Licensing
> >
> > On Sat, 7 May 2022 at 17:30, Yun Tang <my...@live.com> wrote:
> >
> > > First of all, thanks for Jinsong to drive this. I checked the
> following:
> > >
> > >
> > >   *   Reviewed the PR of release note.
> > >   *   Build the package from the scratch: OK
> > >   *   Check that the README.md file does not have anything unexpected:
> > > *seems not OK*
> > >
> > > I noticed that current README actually does not give correct
> description
> > > of how to build and get the expected jar package, and I created a PR
> [1] to
> > > resolve this.
> > >
> > > [1] https://github.com/apache/flink-table-store/pull/112
> > >
> > > Best
> > > Yun Tang
> > > ________________________________
> > > From: Yu Li <ca...@gmail.com>
> > > Sent: Saturday, May 7, 2022 17:20
> > > To: dev <de...@flink.apache.org>
> > > Subject: Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate
> #2
> > >
> > > +1 (binding)
> > >
> > > - Checked release notes: *OK*
> > > - Checked sums and signatures: *OK*
> > > - Checked the jars in the staging repo: *OK*
> > > - Checked source distribution doesn't include binaries: *OK*
> > > - Maven clean install from source: *OK*
> > > - Checked version consistency in pom files: *OK*
> > > - Went through the quick start: *OK*
> > >    - Minor: the set 'table-store.path' was not fully cleaned up after
> > > dropping the table and exiting the sql client shell, please check
> whether
> > > this is expected behavior.
> > > - Checked the website updates: *OK*
> > >   - Note: left some suggestions, please check.
> > >
> > > Thanks for driving this release, Jingsong!
> > >
> > > Best Regards,
> > > Yu
> > >
> > >
> > > On Sat, 7 May 2022 at 15:30, Becket Qin <be...@gmail.com> wrote:
> > >
> > > > Hi Jingsong,
> > > >
> > > > Thanks for driving the very first release of the flink-table-store!
> > > >
> > > > +1 (binding) for the RC.
> > > >
> > > > I verified the following:
> > > > - the signature of the artifacts
> > > > - the source jar does not contain binary files
> > > > - no accidental distribution of other projects is included in the
> dist
> > > jar
> > > > - went through the quick start
> > > > - compiled the code locally
> > > >
> > > > There were two things that are not blockers but might worth noting:
> > > > 1. Running the verification requires docker installation. It happens
> > > that I
> > > > do not have that installed on my new laptop.
> > > > 2. In the quick start, after dropping the word_count table, the
> Flink job
> > > > that inserts data into the word_count table will keep failover. And
> this
> > > > job won't exit after SQL Client exits. It is not a problem of
> > > > flink-table-store, but it might be non-intuitive for some of the
> users.
> > > >
> > > > I also left some comment in the PR of release announcement.
> > > >
> > > > Thanks,
> > > >
> > > > Jiangjie (Becket) Qin
> > > >
> > > > On Thu, May 5, 2022 at 5:39 PM Jingsong Li <ji...@gmail.com>
> > > wrote:
> > > >
> > > > > Hi, Konstantin and OpenInx,
> > > > >
> > > > > I have updated https://github.com/apache/flink-web/pull/531 , you
> can
> > > > > take a review~
> > > > >
> > > > > Best,
> > > > > Jingsong
> > > > >
> > > > > On Thu, May 5, 2022 at 3:07 PM OpenInx <op...@gmail.com> wrote:
> > > > > >
> > > > > > +1 ( non-binding) for the release. I agree with Konstantin that
> we
> > > can
> > > > > add
> > > > > > more materials about the table-store for the voting.
> > > > > >
> > > > > >
> > > > > >    1. Download the source tarball, signature (.asc), and checksum
> > > > > >    (.sha512):   OK
> > > > > >    2. Import gpg keys: download KEYS and run gpg --import
> > > > > >    /path/to/downloaded/KEYS (optional if this hasn’t changed) :
> OK
> > > > > >    3. Verify the signature by running: gpg --verify
> > > > > >    flink-table-store-0.1.0-src.tgz.asc:  OK
> > > > > >    4. Verify the checksum by running: shasum -a 256 -c
> > > > > >    flink-table-store-0.1.0-src.tgz.sha512
> > > > > flink-table-store-0.1.0-src.tgz :  OK
> > > > > >    5. Untar the archive and go into the source directory: tar xzf
> > > > > >    flink-table-store-0.1.0-src.tgz && cd
> flink-table-store-0.1.0:  OK
> > > > > >    6. Build and test the project: mvn clean package (use Java 8)
> :
> > > >  All
> > > > > >    unit tests passed, except the e2e tests. Seems we will need
> to set
> > > > up
> > > > > a
> > > > > >    docker environment to run those e2e tests successfully.
> > > > > >    7. Verify the apache flink access table store:
> > > > > >
> > > > > > ./bin/sql-client.sh -j
> > > > > >
> > > > >
> > > >
> > >
> /Users/openinx/Downloads/flink-table-store-0.1.0/flink-table-store-dist/target/flink-table-store-dist-0.1.0.jar
> > > > > > embedded shell
> > > > > >
> > > > > > SET 'table-store.path' = '/Users/openinx/test/table-store' ;
> > > > > >
> > > > > > SET 'execution.runtime-mode'='batch';
> > > > > >
> > > > > > SET 'sql-client.execution.result-mode' = 'tableau';
> > > > > >
> > > > > > CREATE TABLE MyTable (
> > > > > >
> > > > > > user_id BIGINT,
> > > > > >
> > > > > > item_id BIGINT,
> > > > > >
> > > > > > behavior STRING,
> > > > > >
> > > > > > dt STRING,
> > > > > >
> > > > > > PRIMARY KEY (dt, user_id) NOT ENFORCED
> > > > > >
> > > > > > ) PARTITIONED BY (dt) WITH (
> > > > > >
> > > > > > 'bucket' = '4'
> > > > > >
> > > > > > );
> > > > > >
> > > > > > INSERT INTO MyTable VALUES
> > > > > >
> > > > > > (100, 200, 'buy', '2022-05-04'),
> > > > > >
> > > > > > (101, 201, 'save', '2022-05-04'),
> > > > > >
> > > > > > (101, 201, 'purchase', '2022-05-04');
> > > > > >
> > > > > >
> > > > > > SELECT * FROM MyTable;
> > > > > >
> > > > > > +---------+---------+----------+------------+
> > > > > >
> > > > > > | user_id | item_id | behavior | dt |
> > > > > >
> > > > > > +---------+---------+----------+------------+
> > > > > >
> > > > > > | 100 | 200 | buy | 2022-05-04 |
> > > > > >
> > > > > > | 101 | 201 | purchase | 2022-05-04 |
> > > > > >
> > > > > > +---------+---------+----------+------------+
> > > > > >
> > > > > > 2 rows in set
> > > > > >
> > > > > > On Thu, May 5, 2022 at 2:39 PM Nicholas Jiang <
> > > > nicholasjiang@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > > > Hi everyone,
> > > > > > >
> > > > > > > +1 for the release (non-binding).
> > > > > > >
> > > > > > > - Built and compiled source codes [PASSED]
> > > > > > > - Went through quick start guide [PASSED]
> > > > > > > - Checked README.md [PASSED]
> > > > > > > - Checked that use the table store jar to build query table
> > > > application
> > > > > > > [PASSED]
> > > > > > >
> > > > > > > Best regards,
> > > > > > >
> > > > > > > Nicholas Jiang
> > > > > > >
> > > > > > > On 2022/04/29 02:24:09 Jingsong Li wrote:
> > > > > > > > Hi everyone,
> > > > > > > >
> > > > > > > > Please review and vote on the release candidate #2 for the
> > > version
> > > > > 0.1.0
> > > > > > > of
> > > > > > > > Apache Flink Table Store, as follows:
> > > > > > > >
> > > > > > > > [ ] +1, Approve the release
> > > > > > > > [ ] -1, Do not approve the release (please provide specific
> > > > comments)
> > > > > > > >
> > > > > > > > **Release Overview**
> > > > > > > >
> > > > > > > > As an overview, the release consists of the following:
> > > > > > > > a) Table Store canonical source distribution, to be deployed
> to
> > > the
> > > > > > > > release repository at dist.apache.org
> > > > > > > > b) Maven artifacts to be deployed to the Maven Central
> Repository
> > > > > > > >
> > > > > > > > **Staging Areas to Review**
> > > > > > > >
> > > > > > > > The staging areas containing the above mentioned artifacts
> are as
> > > > > > > follows,
> > > > > > > > for your review:
> > > > > > > > * All artifacts for a) and b) can be found in the
> corresponding
> > > dev
> > > > > > > > repository at dist.apache.org [2]
> > > > > > > > * All artifacts for c) can be found at the Apache Nexus
> > > Repository
> > > > > [3]
> > > > > > > > * Pre Bundled Binaries Jar can work fine with quick start
> [4][5]
> > > > > > > >
> > > > > > > > All artifacts are signed with the key
> > > > > > > > 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> > > > > > > >
> > > > > > > > Other links for your review:
> > > > > > > > * JIRA release notes [7]
> > > > > > > > * source code tag "release-0.1.0-rc2" [8]
> > > > > > > > * PR to update the website Downloads page to include Table
> Store
> > > > > > > > links [9]
> > > > > > > >
> > > > > > > > **Vote Duration**
> > > > > > > >
> > > > > > > > The voting time will run for at least 72 hours.
> > > > > > > > It is adopted by majority approval, with at least 3 PMC
> > > affirmative
> > > > > > > votes.
> > > > > > > >
> > > > > > > > Best,
> > > > > > > > Jingsong Lee
> > > > > > > >
> > > > > > > > [1]
> > > > > > >
> > > > >
> > > >
> > >
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> > > > > > > > [2]
> > > > > > >
> > > > >
> > > >
> > >
> https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> > > > > > > > [3]
> > > > > > >
> > > > >
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1502/
> > > > > > > > [4]
> > > > > > >
> > > > >
> > > >
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> > > > > > > > [5]
> > > > > > >
> > > > >
> > > >
> > >
> https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> > > > > > > > [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > > > > > [7]
> > > > > > >
> > > > >
> > > >
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> > > > > > > > [8]
> > > > > https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> > > > > > > > [9] https://github.com/apache/flink-web/pull/531
> > > > > > > >
> > > > > > >
> > > > >
> > > >
> > >
>

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Jingsong Li <ji...@gmail.com>.

Hi Jark,

> I have checked the LICENSE and NOTICE files but found that the uber jar
(flink-table-store-dist) doesn't provide an appropriate NOTICE file to
list the bundled
dependencies.

Because the dependencies typed in by flink-table-store-dist are all
dependencies of flink-sql-jar, they already contain NOTICE files, and
all dependent NOTICE files will be merged during the shade process, so
the final dist-jar is the one containing NOTICE dependencies.

Best,
Jingsong

On Sun, May 8, 2022 at 12:50 AM Jark Wu <im...@gmail.com> wrote:
>
> Hi all,
>
> I have checked the LICENSE and NOTICE files but found that the uber jar
> (flink-table-store-dist)
>  doesn't provide an appropriate NOTICE file to list the bundled
> dependencies.
>
> I checked the license guideline [1], and it says:
> > For Maven artifacts that DO bundle (usually through the
> maven-shade-plugin)
> > any dependencies the NOTICE file can be found in the
> src/main/resources/META-INF
> > directory of the respective module. If the module does not have a NOTICE
> file yet,
> > then add one under src/main/resources/META-INF.
> and
> > All bundled dependencies must be listed in NOTICE, grouped by license
> type,
> > using standard maven syntax (groupId:artifactId:version).
> > This DOES include ASLv2 dependencies
>
> This DOES include ASLv2 dependencies (for maintainability reasons, as it
> simplifies matching of entries in the dependency-tree and NOTICE files)
>
> I'm not sure whether this would block the release or not.
> It would be great if @Chesnay Schepler <ch...@apache.org> could help to
> check this.
>
> Others look good to me:
> - build and compile the source code locally. OK
> - checked/verified signatures and hashes, OK
> - no missing artifacts in the release staging area. OK
> - reviewed the release PR. OK
> - ran the quick start in local. looks good
>
> Best,
> Jark
>
> [1]: https://cwiki.apache.org/confluence/display/FLINK/Licensing
>
> On Sat, 7 May 2022 at 17:30, Yun Tang <my...@live.com> wrote:
>
> > First of all, thanks for Jinsong to drive this. I checked the following:
> >
> >
> >   *   Reviewed the PR of release note.
> >   *   Build the package from the scratch: OK
> >   *   Check that the README.md file does not have anything unexpected:
> > *seems not OK*
> >
> > I noticed that current README actually does not give correct description
> > of how to build and get the expected jar package, and I created a PR [1] to
> > resolve this.
> >
> > [1] https://github.com/apache/flink-table-store/pull/112
> >
> > Best
> > Yun Tang
> > ________________________________
> > From: Yu Li <ca...@gmail.com>
> > Sent: Saturday, May 7, 2022 17:20
> > To: dev <de...@flink.apache.org>
> > Subject: Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2
> >
> > +1 (binding)
> >
> > - Checked release notes: *OK*
> > - Checked sums and signatures: *OK*
> > - Checked the jars in the staging repo: *OK*
> > - Checked source distribution doesn't include binaries: *OK*
> > - Maven clean install from source: *OK*
> > - Checked version consistency in pom files: *OK*
> > - Went through the quick start: *OK*
> >    - Minor: the set 'table-store.path' was not fully cleaned up after
> > dropping the table and exiting the sql client shell, please check whether
> > this is expected behavior.
> > - Checked the website updates: *OK*
> >   - Note: left some suggestions, please check.
> >
> > Thanks for driving this release, Jingsong!
> >
> > Best Regards,
> > Yu
> >
> >
> > On Sat, 7 May 2022 at 15:30, Becket Qin <be...@gmail.com> wrote:
> >
> > > Hi Jingsong,
> > >
> > > Thanks for driving the very first release of the flink-table-store!
> > >
> > > +1 (binding) for the RC.
> > >
> > > I verified the following:
> > > - the signature of the artifacts
> > > - the source jar does not contain binary files
> > > - no accidental distribution of other projects is included in the dist
> > jar
> > > - went through the quick start
> > > - compiled the code locally
> > >
> > > There were two things that are not blockers but might worth noting:
> > > 1. Running the verification requires docker installation. It happens
> > that I
> > > do not have that installed on my new laptop.
> > > 2. In the quick start, after dropping the word_count table, the Flink job
> > > that inserts data into the word_count table will keep failover. And this
> > > job won't exit after SQL Client exits. It is not a problem of
> > > flink-table-store, but it might be non-intuitive for some of the users.
> > >
> > > I also left some comment in the PR of release announcement.
> > >
> > > Thanks,
> > >
> > > Jiangjie (Becket) Qin
> > >
> > > On Thu, May 5, 2022 at 5:39 PM Jingsong Li <ji...@gmail.com>
> > wrote:
> > >
> > > > Hi, Konstantin and OpenInx,
> > > >
> > > > I have updated https://github.com/apache/flink-web/pull/531 , you can
> > > > take a review~
> > > >
> > > > Best,
> > > > Jingsong
> > > >
> > > > On Thu, May 5, 2022 at 3:07 PM OpenInx <op...@gmail.com> wrote:
> > > > >
> > > > > +1 ( non-binding) for the release. I agree with Konstantin that we
> > can
> > > > add
> > > > > more materials about the table-store for the voting.
> > > > >
> > > > >
> > > > >    1. Download the source tarball, signature (.asc), and checksum
> > > > >    (.sha512):   OK
> > > > >    2. Import gpg keys: download KEYS and run gpg --import
> > > > >    /path/to/downloaded/KEYS (optional if this hasn’t changed) :  OK
> > > > >    3. Verify the signature by running: gpg --verify
> > > > >    flink-table-store-0.1.0-src.tgz.asc:  OK
> > > > >    4. Verify the checksum by running: shasum -a 256 -c
> > > > >    flink-table-store-0.1.0-src.tgz.sha512
> > > > flink-table-store-0.1.0-src.tgz :  OK
> > > > >    5. Untar the archive and go into the source directory: tar xzf
> > > > >    flink-table-store-0.1.0-src.tgz && cd flink-table-store-0.1.0:  OK
> > > > >    6. Build and test the project: mvn clean package (use Java 8) :
> > >  All
> > > > >    unit tests passed, except the e2e tests. Seems we will need to set
> > > up
> > > > a
> > > > >    docker environment to run those e2e tests successfully.
> > > > >    7. Verify the apache flink access table store:
> > > > >
> > > > > ./bin/sql-client.sh -j
> > > > >
> > > >
> > >
> > /Users/openinx/Downloads/flink-table-store-0.1.0/flink-table-store-dist/target/flink-table-store-dist-0.1.0.jar
> > > > > embedded shell
> > > > >
> > > > > SET 'table-store.path' = '/Users/openinx/test/table-store' ;
> > > > >
> > > > > SET 'execution.runtime-mode'='batch';
> > > > >
> > > > > SET 'sql-client.execution.result-mode' = 'tableau';
> > > > >
> > > > > CREATE TABLE MyTable (
> > > > >
> > > > > user_id BIGINT,
> > > > >
> > > > > item_id BIGINT,
> > > > >
> > > > > behavior STRING,
> > > > >
> > > > > dt STRING,
> > > > >
> > > > > PRIMARY KEY (dt, user_id) NOT ENFORCED
> > > > >
> > > > > ) PARTITIONED BY (dt) WITH (
> > > > >
> > > > > 'bucket' = '4'
> > > > >
> > > > > );
> > > > >
> > > > > INSERT INTO MyTable VALUES
> > > > >
> > > > > (100, 200, 'buy', '2022-05-04'),
> > > > >
> > > > > (101, 201, 'save', '2022-05-04'),
> > > > >
> > > > > (101, 201, 'purchase', '2022-05-04');
> > > > >
> > > > >
> > > > > SELECT * FROM MyTable;
> > > > >
> > > > > +---------+---------+----------+------------+
> > > > >
> > > > > | user_id | item_id | behavior | dt |
> > > > >
> > > > > +---------+---------+----------+------------+
> > > > >
> > > > > | 100 | 200 | buy | 2022-05-04 |
> > > > >
> > > > > | 101 | 201 | purchase | 2022-05-04 |
> > > > >
> > > > > +---------+---------+----------+------------+
> > > > >
> > > > > 2 rows in set
> > > > >
> > > > > On Thu, May 5, 2022 at 2:39 PM Nicholas Jiang <
> > > nicholasjiang@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Hi everyone,
> > > > > >
> > > > > > +1 for the release (non-binding).
> > > > > >
> > > > > > - Built and compiled source codes [PASSED]
> > > > > > - Went through quick start guide [PASSED]
> > > > > > - Checked README.md [PASSED]
> > > > > > - Checked that use the table store jar to build query table
> > > application
> > > > > > [PASSED]
> > > > > >
> > > > > > Best regards,
> > > > > >
> > > > > > Nicholas Jiang
> > > > > >
> > > > > > On 2022/04/29 02:24:09 Jingsong Li wrote:
> > > > > > > Hi everyone,
> > > > > > >
> > > > > > > Please review and vote on the release candidate #2 for the
> > version
> > > > 0.1.0
> > > > > > of
> > > > > > > Apache Flink Table Store, as follows:
> > > > > > >
> > > > > > > [ ] +1, Approve the release
> > > > > > > [ ] -1, Do not approve the release (please provide specific
> > > comments)
> > > > > > >
> > > > > > > **Release Overview**
> > > > > > >
> > > > > > > As an overview, the release consists of the following:
> > > > > > > a) Table Store canonical source distribution, to be deployed to
> > the
> > > > > > > release repository at dist.apache.org
> > > > > > > b) Maven artifacts to be deployed to the Maven Central Repository
> > > > > > >
> > > > > > > **Staging Areas to Review**
> > > > > > >
> > > > > > > The staging areas containing the above mentioned artifacts are as
> > > > > > follows,
> > > > > > > for your review:
> > > > > > > * All artifacts for a) and b) can be found in the corresponding
> > dev
> > > > > > > repository at dist.apache.org [2]
> > > > > > > * All artifacts for c) can be found at the Apache Nexus
> > Repository
> > > > [3]
> > > > > > > * Pre Bundled Binaries Jar can work fine with quick start [4][5]
> > > > > > >
> > > > > > > All artifacts are signed with the key
> > > > > > > 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> > > > > > >
> > > > > > > Other links for your review:
> > > > > > > * JIRA release notes [7]
> > > > > > > * source code tag "release-0.1.0-rc2" [8]
> > > > > > > * PR to update the website Downloads page to include Table Store
> > > > > > > links [9]
> > > > > > >
> > > > > > > **Vote Duration**
> > > > > > >
> > > > > > > The voting time will run for at least 72 hours.
> > > > > > > It is adopted by majority approval, with at least 3 PMC
> > affirmative
> > > > > > votes.
> > > > > > >
> > > > > > > Best,
> > > > > > > Jingsong Lee
> > > > > > >
> > > > > > > [1]
> > > > > >
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> > > > > > > [2]
> > > > > >
> > > >
> > >
> > https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> > > > > > > [3]
> > > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1502/
> > > > > > > [4]
> > > > > >
> > > >
> > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> > > > > > > [5]
> > > > > >
> > > >
> > >
> > https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> > > > > > > [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > > > > [7]
> > > > > >
> > > >
> > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> > > > > > > [8]
> > > > https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> > > > > > > [9] https://github.com/apache/flink-web/pull/531
> > > > > > >
> > > > > >
> > > >
> > >
> >

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Jark Wu <im...@gmail.com>.

Hi all,

I have checked the LICENSE and NOTICE files but found that the uber jar
(flink-table-store-dist)
 doesn't provide an appropriate NOTICE file to list the bundled
dependencies.

I checked the license guideline [1], and it says:
> For Maven artifacts that DO bundle (usually through the
maven-shade-plugin)
> any dependencies the NOTICE file can be found in the
src/main/resources/META-INF
> directory of the respective module. If the module does not have a NOTICE
file yet,
> then add one under src/main/resources/META-INF.
and
> All bundled dependencies must be listed in NOTICE, grouped by license
type,
> using standard maven syntax (groupId:artifactId:version).
> This DOES include ASLv2 dependencies

This DOES include ASLv2 dependencies (for maintainability reasons, as it
simplifies matching of entries in the dependency-tree and NOTICE files)

I'm not sure whether this would block the release or not.
It would be great if @Chesnay Schepler <ch...@apache.org> could help to
check this.

Others look good to me:
- build and compile the source code locally. OK
- checked/verified signatures and hashes, OK
- no missing artifacts in the release staging area. OK
- reviewed the release PR. OK
- ran the quick start in local. looks good

Best,
Jark

[1]: https://cwiki.apache.org/confluence/display/FLINK/Licensing

On Sat, 7 May 2022 at 17:30, Yun Tang <my...@live.com> wrote:

> First of all, thanks for Jinsong to drive this. I checked the following:
>
>
>   *   Reviewed the PR of release note.
>   *   Build the package from the scratch: OK
>   *   Check that the README.md file does not have anything unexpected:
> *seems not OK*
>
> I noticed that current README actually does not give correct description
> of how to build and get the expected jar package, and I created a PR [1] to
> resolve this.
>
> [1] https://github.com/apache/flink-table-store/pull/112
>
> Best
> Yun Tang
> ________________________________
> From: Yu Li <ca...@gmail.com>
> Sent: Saturday, May 7, 2022 17:20
> To: dev <de...@flink.apache.org>
> Subject: Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2
>
> +1 (binding)
>
> - Checked release notes: *OK*
> - Checked sums and signatures: *OK*
> - Checked the jars in the staging repo: *OK*
> - Checked source distribution doesn't include binaries: *OK*
> - Maven clean install from source: *OK*
> - Checked version consistency in pom files: *OK*
> - Went through the quick start: *OK*
>    - Minor: the set 'table-store.path' was not fully cleaned up after
> dropping the table and exiting the sql client shell, please check whether
> this is expected behavior.
> - Checked the website updates: *OK*
>   - Note: left some suggestions, please check.
>
> Thanks for driving this release, Jingsong!
>
> Best Regards,
> Yu
>
>
> On Sat, 7 May 2022 at 15:30, Becket Qin <be...@gmail.com> wrote:
>
> > Hi Jingsong,
> >
> > Thanks for driving the very first release of the flink-table-store!
> >
> > +1 (binding) for the RC.
> >
> > I verified the following:
> > - the signature of the artifacts
> > - the source jar does not contain binary files
> > - no accidental distribution of other projects is included in the dist
> jar
> > - went through the quick start
> > - compiled the code locally
> >
> > There were two things that are not blockers but might worth noting:
> > 1. Running the verification requires docker installation. It happens
> that I
> > do not have that installed on my new laptop.
> > 2. In the quick start, after dropping the word_count table, the Flink job
> > that inserts data into the word_count table will keep failover. And this
> > job won't exit after SQL Client exits. It is not a problem of
> > flink-table-store, but it might be non-intuitive for some of the users.
> >
> > I also left some comment in the PR of release announcement.
> >
> > Thanks,
> >
> > Jiangjie (Becket) Qin
> >
> > On Thu, May 5, 2022 at 5:39 PM Jingsong Li <ji...@gmail.com>
> wrote:
> >
> > > Hi, Konstantin and OpenInx,
> > >
> > > I have updated https://github.com/apache/flink-web/pull/531 , you can
> > > take a review~
> > >
> > > Best,
> > > Jingsong
> > >
> > > On Thu, May 5, 2022 at 3:07 PM OpenInx <op...@gmail.com> wrote:
> > > >
> > > > +1 ( non-binding) for the release. I agree with Konstantin that we
> can
> > > add
> > > > more materials about the table-store for the voting.
> > > >
> > > >
> > > >    1. Download the source tarball, signature (.asc), and checksum
> > > >    (.sha512):   OK
> > > >    2. Import gpg keys: download KEYS and run gpg --import
> > > >    /path/to/downloaded/KEYS (optional if this hasn’t changed) :  OK
> > > >    3. Verify the signature by running: gpg --verify
> > > >    flink-table-store-0.1.0-src.tgz.asc:  OK
> > > >    4. Verify the checksum by running: shasum -a 256 -c
> > > >    flink-table-store-0.1.0-src.tgz.sha512
> > > flink-table-store-0.1.0-src.tgz :  OK
> > > >    5. Untar the archive and go into the source directory: tar xzf
> > > >    flink-table-store-0.1.0-src.tgz && cd flink-table-store-0.1.0:  OK
> > > >    6. Build and test the project: mvn clean package (use Java 8) :
> >  All
> > > >    unit tests passed, except the e2e tests. Seems we will need to set
> > up
> > > a
> > > >    docker environment to run those e2e tests successfully.
> > > >    7. Verify the apache flink access table store:
> > > >
> > > > ./bin/sql-client.sh -j
> > > >
> > >
> >
> /Users/openinx/Downloads/flink-table-store-0.1.0/flink-table-store-dist/target/flink-table-store-dist-0.1.0.jar
> > > > embedded shell
> > > >
> > > > SET 'table-store.path' = '/Users/openinx/test/table-store' ;
> > > >
> > > > SET 'execution.runtime-mode'='batch';
> > > >
> > > > SET 'sql-client.execution.result-mode' = 'tableau';
> > > >
> > > > CREATE TABLE MyTable (
> > > >
> > > > user_id BIGINT,
> > > >
> > > > item_id BIGINT,
> > > >
> > > > behavior STRING,
> > > >
> > > > dt STRING,
> > > >
> > > > PRIMARY KEY (dt, user_id) NOT ENFORCED
> > > >
> > > > ) PARTITIONED BY (dt) WITH (
> > > >
> > > > 'bucket' = '4'
> > > >
> > > > );
> > > >
> > > > INSERT INTO MyTable VALUES
> > > >
> > > > (100, 200, 'buy', '2022-05-04'),
> > > >
> > > > (101, 201, 'save', '2022-05-04'),
> > > >
> > > > (101, 201, 'purchase', '2022-05-04');
> > > >
> > > >
> > > > SELECT * FROM MyTable;
> > > >
> > > > +---------+---------+----------+------------+
> > > >
> > > > | user_id | item_id | behavior | dt |
> > > >
> > > > +---------+---------+----------+------------+
> > > >
> > > > | 100 | 200 | buy | 2022-05-04 |
> > > >
> > > > | 101 | 201 | purchase | 2022-05-04 |
> > > >
> > > > +---------+---------+----------+------------+
> > > >
> > > > 2 rows in set
> > > >
> > > > On Thu, May 5, 2022 at 2:39 PM Nicholas Jiang <
> > nicholasjiang@apache.org>
> > > > wrote:
> > > >
> > > > > Hi everyone,
> > > > >
> > > > > +1 for the release (non-binding).
> > > > >
> > > > > - Built and compiled source codes [PASSED]
> > > > > - Went through quick start guide [PASSED]
> > > > > - Checked README.md [PASSED]
> > > > > - Checked that use the table store jar to build query table
> > application
> > > > > [PASSED]
> > > > >
> > > > > Best regards,
> > > > >
> > > > > Nicholas Jiang
> > > > >
> > > > > On 2022/04/29 02:24:09 Jingsong Li wrote:
> > > > > > Hi everyone,
> > > > > >
> > > > > > Please review and vote on the release candidate #2 for the
> version
> > > 0.1.0
> > > > > of
> > > > > > Apache Flink Table Store, as follows:
> > > > > >
> > > > > > [ ] +1, Approve the release
> > > > > > [ ] -1, Do not approve the release (please provide specific
> > comments)
> > > > > >
> > > > > > **Release Overview**
> > > > > >
> > > > > > As an overview, the release consists of the following:
> > > > > > a) Table Store canonical source distribution, to be deployed to
> the
> > > > > > release repository at dist.apache.org
> > > > > > b) Maven artifacts to be deployed to the Maven Central Repository
> > > > > >
> > > > > > **Staging Areas to Review**
> > > > > >
> > > > > > The staging areas containing the above mentioned artifacts are as
> > > > > follows,
> > > > > > for your review:
> > > > > > * All artifacts for a) and b) can be found in the corresponding
> dev
> > > > > > repository at dist.apache.org [2]
> > > > > > * All artifacts for c) can be found at the Apache Nexus
> Repository
> > > [3]
> > > > > > * Pre Bundled Binaries Jar can work fine with quick start [4][5]
> > > > > >
> > > > > > All artifacts are signed with the key
> > > > > > 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> > > > > >
> > > > > > Other links for your review:
> > > > > > * JIRA release notes [7]
> > > > > > * source code tag "release-0.1.0-rc2" [8]
> > > > > > * PR to update the website Downloads page to include Table Store
> > > > > > links [9]
> > > > > >
> > > > > > **Vote Duration**
> > > > > >
> > > > > > The voting time will run for at least 72 hours.
> > > > > > It is adopted by majority approval, with at least 3 PMC
> affirmative
> > > > > votes.
> > > > > >
> > > > > > Best,
> > > > > > Jingsong Lee
> > > > > >
> > > > > > [1]
> > > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> > > > > > [2]
> > > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> > > > > > [3]
> > > > >
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1502/
> > > > > > [4]
> > > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> > > > > > [5]
> > > > >
> > >
> >
> https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> > > > > > [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > > > [7]
> > > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> > > > > > [8]
> > > https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> > > > > > [9] https://github.com/apache/flink-web/pull/531
> > > > > >
> > > > >
> > >
> >
>

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Yun Tang <my...@live.com>.

First of all, thanks for Jinsong to drive this. I checked the following:


  *   Reviewed the PR of release note.
  *   Build the package from the scratch: OK
  *   Check that the README.md file does not have anything unexpected: *seems not OK*

I noticed that current README actually does not give correct description of how to build and get the expected jar package, and I created a PR [1] to resolve this.

[1] https://github.com/apache/flink-table-store/pull/112

Best
Yun Tang
________________________________
From: Yu Li <ca...@gmail.com>
Sent: Saturday, May 7, 2022 17:20
To: dev <de...@flink.apache.org>
Subject: Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

+1 (binding)

- Checked release notes: *OK*
- Checked sums and signatures: *OK*
- Checked the jars in the staging repo: *OK*
- Checked source distribution doesn't include binaries: *OK*
- Maven clean install from source: *OK*
- Checked version consistency in pom files: *OK*
- Went through the quick start: *OK*
   - Minor: the set 'table-store.path' was not fully cleaned up after
dropping the table and exiting the sql client shell, please check whether
this is expected behavior.
- Checked the website updates: *OK*
  - Note: left some suggestions, please check.

Thanks for driving this release, Jingsong!

Best Regards,
Yu


On Sat, 7 May 2022 at 15:30, Becket Qin <be...@gmail.com> wrote:

> Hi Jingsong,
>
> Thanks for driving the very first release of the flink-table-store!
>
> +1 (binding) for the RC.
>
> I verified the following:
> - the signature of the artifacts
> - the source jar does not contain binary files
> - no accidental distribution of other projects is included in the dist jar
> - went through the quick start
> - compiled the code locally
>
> There were two things that are not blockers but might worth noting:
> 1. Running the verification requires docker installation. It happens that I
> do not have that installed on my new laptop.
> 2. In the quick start, after dropping the word_count table, the Flink job
> that inserts data into the word_count table will keep failover. And this
> job won't exit after SQL Client exits. It is not a problem of
> flink-table-store, but it might be non-intuitive for some of the users.
>
> I also left some comment in the PR of release announcement.
>
> Thanks,
>
> Jiangjie (Becket) Qin
>
> On Thu, May 5, 2022 at 5:39 PM Jingsong Li <ji...@gmail.com> wrote:
>
> > Hi, Konstantin and OpenInx,
> >
> > I have updated https://github.com/apache/flink-web/pull/531 , you can
> > take a review~
> >
> > Best,
> > Jingsong
> >
> > On Thu, May 5, 2022 at 3:07 PM OpenInx <op...@gmail.com> wrote:
> > >
> > > +1 ( non-binding) for the release. I agree with Konstantin that we can
> > add
> > > more materials about the table-store for the voting.
> > >
> > >
> > >    1. Download the source tarball, signature (.asc), and checksum
> > >    (.sha512):   OK
> > >    2. Import gpg keys: download KEYS and run gpg --import
> > >    /path/to/downloaded/KEYS (optional if this hasn’t changed) :  OK
> > >    3. Verify the signature by running: gpg --verify
> > >    flink-table-store-0.1.0-src.tgz.asc:  OK
> > >    4. Verify the checksum by running: shasum -a 256 -c
> > >    flink-table-store-0.1.0-src.tgz.sha512
> > flink-table-store-0.1.0-src.tgz :  OK
> > >    5. Untar the archive and go into the source directory: tar xzf
> > >    flink-table-store-0.1.0-src.tgz && cd flink-table-store-0.1.0:  OK
> > >    6. Build and test the project: mvn clean package (use Java 8) :
>  All
> > >    unit tests passed, except the e2e tests. Seems we will need to set
> up
> > a
> > >    docker environment to run those e2e tests successfully.
> > >    7. Verify the apache flink access table store:
> > >
> > > ./bin/sql-client.sh -j
> > >
> >
> /Users/openinx/Downloads/flink-table-store-0.1.0/flink-table-store-dist/target/flink-table-store-dist-0.1.0.jar
> > > embedded shell
> > >
> > > SET 'table-store.path' = '/Users/openinx/test/table-store' ;
> > >
> > > SET 'execution.runtime-mode'='batch';
> > >
> > > SET 'sql-client.execution.result-mode' = 'tableau';
> > >
> > > CREATE TABLE MyTable (
> > >
> > > user_id BIGINT,
> > >
> > > item_id BIGINT,
> > >
> > > behavior STRING,
> > >
> > > dt STRING,
> > >
> > > PRIMARY KEY (dt, user_id) NOT ENFORCED
> > >
> > > ) PARTITIONED BY (dt) WITH (
> > >
> > > 'bucket' = '4'
> > >
> > > );
> > >
> > > INSERT INTO MyTable VALUES
> > >
> > > (100, 200, 'buy', '2022-05-04'),
> > >
> > > (101, 201, 'save', '2022-05-04'),
> > >
> > > (101, 201, 'purchase', '2022-05-04');
> > >
> > >
> > > SELECT * FROM MyTable;
> > >
> > > +---------+---------+----------+------------+
> > >
> > > | user_id | item_id | behavior | dt |
> > >
> > > +---------+---------+----------+------------+
> > >
> > > | 100 | 200 | buy | 2022-05-04 |
> > >
> > > | 101 | 201 | purchase | 2022-05-04 |
> > >
> > > +---------+---------+----------+------------+
> > >
> > > 2 rows in set
> > >
> > > On Thu, May 5, 2022 at 2:39 PM Nicholas Jiang <
> nicholasjiang@apache.org>
> > > wrote:
> > >
> > > > Hi everyone,
> > > >
> > > > +1 for the release (non-binding).
> > > >
> > > > - Built and compiled source codes [PASSED]
> > > > - Went through quick start guide [PASSED]
> > > > - Checked README.md [PASSED]
> > > > - Checked that use the table store jar to build query table
> application
> > > > [PASSED]
> > > >
> > > > Best regards,
> > > >
> > > > Nicholas Jiang
> > > >
> > > > On 2022/04/29 02:24:09 Jingsong Li wrote:
> > > > > Hi everyone,
> > > > >
> > > > > Please review and vote on the release candidate #2 for the version
> > 0.1.0
> > > > of
> > > > > Apache Flink Table Store, as follows:
> > > > >
> > > > > [ ] +1, Approve the release
> > > > > [ ] -1, Do not approve the release (please provide specific
> comments)
> > > > >
> > > > > **Release Overview**
> > > > >
> > > > > As an overview, the release consists of the following:
> > > > > a) Table Store canonical source distribution, to be deployed to the
> > > > > release repository at dist.apache.org
> > > > > b) Maven artifacts to be deployed to the Maven Central Repository
> > > > >
> > > > > **Staging Areas to Review**
> > > > >
> > > > > The staging areas containing the above mentioned artifacts are as
> > > > follows,
> > > > > for your review:
> > > > > * All artifacts for a) and b) can be found in the corresponding dev
> > > > > repository at dist.apache.org [2]
> > > > > * All artifacts for c) can be found at the Apache Nexus Repository
> > [3]
> > > > > * Pre Bundled Binaries Jar can work fine with quick start [4][5]
> > > > >
> > > > > All artifacts are signed with the key
> > > > > 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> > > > >
> > > > > Other links for your review:
> > > > > * JIRA release notes [7]
> > > > > * source code tag "release-0.1.0-rc2" [8]
> > > > > * PR to update the website Downloads page to include Table Store
> > > > > links [9]
> > > > >
> > > > > **Vote Duration**
> > > > >
> > > > > The voting time will run for at least 72 hours.
> > > > > It is adopted by majority approval, with at least 3 PMC affirmative
> > > > votes.
> > > > >
> > > > > Best,
> > > > > Jingsong Lee
> > > > >
> > > > > [1]
> > > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> > > > > [2]
> > > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> > > > > [3]
> > > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1502/
> > > > > [4]
> > > >
> >
> https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> > > > > [5]
> > > >
> >
> https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> > > > > [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > > [7]
> > > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> > > > > [8]
> > https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> > > > > [9] https://github.com/apache/flink-web/pull/531
> > > > >
> > > >
> >
>

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Yu Li <ca...@gmail.com>.

+1 (binding)

- Checked release notes: *OK*
- Checked sums and signatures: *OK*
- Checked the jars in the staging repo: *OK*
- Checked source distribution doesn't include binaries: *OK*
- Maven clean install from source: *OK*
- Checked version consistency in pom files: *OK*
- Went through the quick start: *OK*
   - Minor: the set 'table-store.path' was not fully cleaned up after
dropping the table and exiting the sql client shell, please check whether
this is expected behavior.
- Checked the website updates: *OK*
  - Note: left some suggestions, please check.

Thanks for driving this release, Jingsong!

Best Regards,
Yu


On Sat, 7 May 2022 at 15:30, Becket Qin <be...@gmail.com> wrote:

> Hi Jingsong,
>
> Thanks for driving the very first release of the flink-table-store!
>
> +1 (binding) for the RC.
>
> I verified the following:
> - the signature of the artifacts
> - the source jar does not contain binary files
> - no accidental distribution of other projects is included in the dist jar
> - went through the quick start
> - compiled the code locally
>
> There were two things that are not blockers but might worth noting:
> 1. Running the verification requires docker installation. It happens that I
> do not have that installed on my new laptop.
> 2. In the quick start, after dropping the word_count table, the Flink job
> that inserts data into the word_count table will keep failover. And this
> job won't exit after SQL Client exits. It is not a problem of
> flink-table-store, but it might be non-intuitive for some of the users.
>
> I also left some comment in the PR of release announcement.
>
> Thanks,
>
> Jiangjie (Becket) Qin
>
> On Thu, May 5, 2022 at 5:39 PM Jingsong Li <ji...@gmail.com> wrote:
>
> > Hi, Konstantin and OpenInx,
> >
> > I have updated https://github.com/apache/flink-web/pull/531 , you can
> > take a review~
> >
> > Best,
> > Jingsong
> >
> > On Thu, May 5, 2022 at 3:07 PM OpenInx <op...@gmail.com> wrote:
> > >
> > > +1 ( non-binding) for the release. I agree with Konstantin that we can
> > add
> > > more materials about the table-store for the voting.
> > >
> > >
> > >    1. Download the source tarball, signature (.asc), and checksum
> > >    (.sha512):   OK
> > >    2. Import gpg keys: download KEYS and run gpg --import
> > >    /path/to/downloaded/KEYS (optional if this hasn’t changed) :  OK
> > >    3. Verify the signature by running: gpg --verify
> > >    flink-table-store-0.1.0-src.tgz.asc:  OK
> > >    4. Verify the checksum by running: shasum -a 256 -c
> > >    flink-table-store-0.1.0-src.tgz.sha512
> > flink-table-store-0.1.0-src.tgz :  OK
> > >    5. Untar the archive and go into the source directory: tar xzf
> > >    flink-table-store-0.1.0-src.tgz && cd flink-table-store-0.1.0:  OK
> > >    6. Build and test the project: mvn clean package (use Java 8) :
>  All
> > >    unit tests passed, except the e2e tests. Seems we will need to set
> up
> > a
> > >    docker environment to run those e2e tests successfully.
> > >    7. Verify the apache flink access table store:
> > >
> > > ./bin/sql-client.sh -j
> > >
> >
> /Users/openinx/Downloads/flink-table-store-0.1.0/flink-table-store-dist/target/flink-table-store-dist-0.1.0.jar
> > > embedded shell
> > >
> > > SET 'table-store.path' = '/Users/openinx/test/table-store' ;
> > >
> > > SET 'execution.runtime-mode'='batch';
> > >
> > > SET 'sql-client.execution.result-mode' = 'tableau';
> > >
> > > CREATE TABLE MyTable (
> > >
> > > user_id BIGINT,
> > >
> > > item_id BIGINT,
> > >
> > > behavior STRING,
> > >
> > > dt STRING,
> > >
> > > PRIMARY KEY (dt, user_id) NOT ENFORCED
> > >
> > > ) PARTITIONED BY (dt) WITH (
> > >
> > > 'bucket' = '4'
> > >
> > > );
> > >
> > > INSERT INTO MyTable VALUES
> > >
> > > (100, 200, 'buy', '2022-05-04'),
> > >
> > > (101, 201, 'save', '2022-05-04'),
> > >
> > > (101, 201, 'purchase', '2022-05-04');
> > >
> > >
> > > SELECT * FROM MyTable;
> > >
> > > +---------+---------+----------+------------+
> > >
> > > | user_id | item_id | behavior | dt |
> > >
> > > +---------+---------+----------+------------+
> > >
> > > | 100 | 200 | buy | 2022-05-04 |
> > >
> > > | 101 | 201 | purchase | 2022-05-04 |
> > >
> > > +---------+---------+----------+------------+
> > >
> > > 2 rows in set
> > >
> > > On Thu, May 5, 2022 at 2:39 PM Nicholas Jiang <
> nicholasjiang@apache.org>
> > > wrote:
> > >
> > > > Hi everyone,
> > > >
> > > > +1 for the release (non-binding).
> > > >
> > > > - Built and compiled source codes [PASSED]
> > > > - Went through quick start guide [PASSED]
> > > > - Checked README.md [PASSED]
> > > > - Checked that use the table store jar to build query table
> application
> > > > [PASSED]
> > > >
> > > > Best regards,
> > > >
> > > > Nicholas Jiang
> > > >
> > > > On 2022/04/29 02:24:09 Jingsong Li wrote:
> > > > > Hi everyone,
> > > > >
> > > > > Please review and vote on the release candidate #2 for the version
> > 0.1.0
> > > > of
> > > > > Apache Flink Table Store, as follows:
> > > > >
> > > > > [ ] +1, Approve the release
> > > > > [ ] -1, Do not approve the release (please provide specific
> comments)
> > > > >
> > > > > **Release Overview**
> > > > >
> > > > > As an overview, the release consists of the following:
> > > > > a) Table Store canonical source distribution, to be deployed to the
> > > > > release repository at dist.apache.org
> > > > > b) Maven artifacts to be deployed to the Maven Central Repository
> > > > >
> > > > > **Staging Areas to Review**
> > > > >
> > > > > The staging areas containing the above mentioned artifacts are as
> > > > follows,
> > > > > for your review:
> > > > > * All artifacts for a) and b) can be found in the corresponding dev
> > > > > repository at dist.apache.org [2]
> > > > > * All artifacts for c) can be found at the Apache Nexus Repository
> > [3]
> > > > > * Pre Bundled Binaries Jar can work fine with quick start [4][5]
> > > > >
> > > > > All artifacts are signed with the key
> > > > > 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> > > > >
> > > > > Other links for your review:
> > > > > * JIRA release notes [7]
> > > > > * source code tag "release-0.1.0-rc2" [8]
> > > > > * PR to update the website Downloads page to include Table Store
> > > > > links [9]
> > > > >
> > > > > **Vote Duration**
> > > > >
> > > > > The voting time will run for at least 72 hours.
> > > > > It is adopted by majority approval, with at least 3 PMC affirmative
> > > > votes.
> > > > >
> > > > > Best,
> > > > > Jingsong Lee
> > > > >
> > > > > [1]
> > > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> > > > > [2]
> > > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> > > > > [3]
> > > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1502/
> > > > > [4]
> > > >
> >
> https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> > > > > [5]
> > > >
> >
> https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> > > > > [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > > [7]
> > > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> > > > > [8]
> > https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> > > > > [9] https://github.com/apache/flink-web/pull/531
> > > > >
> > > >
> >
>

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Becket Qin <be...@gmail.com>.

Hi Jingsong,

Thanks for driving the very first release of the flink-table-store!

+1 (binding) for the RC.

I verified the following:
- the signature of the artifacts
- the source jar does not contain binary files
- no accidental distribution of other projects is included in the dist jar
- went through the quick start
- compiled the code locally

There were two things that are not blockers but might worth noting:
1. Running the verification requires docker installation. It happens that I
do not have that installed on my new laptop.
2. In the quick start, after dropping the word_count table, the Flink job
that inserts data into the word_count table will keep failover. And this
job won't exit after SQL Client exits. It is not a problem of
flink-table-store, but it might be non-intuitive for some of the users.

I also left some comment in the PR of release announcement.

Thanks,

Jiangjie (Becket) Qin

On Thu, May 5, 2022 at 5:39 PM Jingsong Li <ji...@gmail.com> wrote:

> Hi, Konstantin and OpenInx,
>
> I have updated https://github.com/apache/flink-web/pull/531 , you can
> take a review~
>
> Best,
> Jingsong
>
> On Thu, May 5, 2022 at 3:07 PM OpenInx <op...@gmail.com> wrote:
> >
> > +1 ( non-binding) for the release. I agree with Konstantin that we can
> add
> > more materials about the table-store for the voting.
> >
> >
> >    1. Download the source tarball, signature (.asc), and checksum
> >    (.sha512):   OK
> >    2. Import gpg keys: download KEYS and run gpg --import
> >    /path/to/downloaded/KEYS (optional if this hasn’t changed) :  OK
> >    3. Verify the signature by running: gpg --verify
> >    flink-table-store-0.1.0-src.tgz.asc:  OK
> >    4. Verify the checksum by running: shasum -a 256 -c
> >    flink-table-store-0.1.0-src.tgz.sha512
> flink-table-store-0.1.0-src.tgz :  OK
> >    5. Untar the archive and go into the source directory: tar xzf
> >    flink-table-store-0.1.0-src.tgz && cd flink-table-store-0.1.0:  OK
> >    6. Build and test the project: mvn clean package (use Java 8) :   All
> >    unit tests passed, except the e2e tests. Seems we will need to set up
> a
> >    docker environment to run those e2e tests successfully.
> >    7. Verify the apache flink access table store:
> >
> > ./bin/sql-client.sh -j
> >
> /Users/openinx/Downloads/flink-table-store-0.1.0/flink-table-store-dist/target/flink-table-store-dist-0.1.0.jar
> > embedded shell
> >
> > SET 'table-store.path' = '/Users/openinx/test/table-store' ;
> >
> > SET 'execution.runtime-mode'='batch';
> >
> > SET 'sql-client.execution.result-mode' = 'tableau';
> >
> > CREATE TABLE MyTable (
> >
> > user_id BIGINT,
> >
> > item_id BIGINT,
> >
> > behavior STRING,
> >
> > dt STRING,
> >
> > PRIMARY KEY (dt, user_id) NOT ENFORCED
> >
> > ) PARTITIONED BY (dt) WITH (
> >
> > 'bucket' = '4'
> >
> > );
> >
> > INSERT INTO MyTable VALUES
> >
> > (100, 200, 'buy', '2022-05-04'),
> >
> > (101, 201, 'save', '2022-05-04'),
> >
> > (101, 201, 'purchase', '2022-05-04');
> >
> >
> > SELECT * FROM MyTable;
> >
> > +---------+---------+----------+------------+
> >
> > | user_id | item_id | behavior | dt |
> >
> > +---------+---------+----------+------------+
> >
> > | 100 | 200 | buy | 2022-05-04 |
> >
> > | 101 | 201 | purchase | 2022-05-04 |
> >
> > +---------+---------+----------+------------+
> >
> > 2 rows in set
> >
> > On Thu, May 5, 2022 at 2:39 PM Nicholas Jiang <ni...@apache.org>
> > wrote:
> >
> > > Hi everyone,
> > >
> > > +1 for the release (non-binding).
> > >
> > > - Built and compiled source codes [PASSED]
> > > - Went through quick start guide [PASSED]
> > > - Checked README.md [PASSED]
> > > - Checked that use the table store jar to build query table application
> > > [PASSED]
> > >
> > > Best regards,
> > >
> > > Nicholas Jiang
> > >
> > > On 2022/04/29 02:24:09 Jingsong Li wrote:
> > > > Hi everyone,
> > > >
> > > > Please review and vote on the release candidate #2 for the version
> 0.1.0
> > > of
> > > > Apache Flink Table Store, as follows:
> > > >
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > > **Release Overview**
> > > >
> > > > As an overview, the release consists of the following:
> > > > a) Table Store canonical source distribution, to be deployed to the
> > > > release repository at dist.apache.org
> > > > b) Maven artifacts to be deployed to the Maven Central Repository
> > > >
> > > > **Staging Areas to Review**
> > > >
> > > > The staging areas containing the above mentioned artifacts are as
> > > follows,
> > > > for your review:
> > > > * All artifacts for a) and b) can be found in the corresponding dev
> > > > repository at dist.apache.org [2]
> > > > * All artifacts for c) can be found at the Apache Nexus Repository
> [3]
> > > > * Pre Bundled Binaries Jar can work fine with quick start [4][5]
> > > >
> > > > All artifacts are signed with the key
> > > > 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> > > >
> > > > Other links for your review:
> > > > * JIRA release notes [7]
> > > > * source code tag "release-0.1.0-rc2" [8]
> > > > * PR to update the website Downloads page to include Table Store
> > > > links [9]
> > > >
> > > > **Vote Duration**
> > > >
> > > > The voting time will run for at least 72 hours.
> > > > It is adopted by majority approval, with at least 3 PMC affirmative
> > > votes.
> > > >
> > > > Best,
> > > > Jingsong Lee
> > > >
> > > > [1]
> > >
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> > > > [2]
> > >
> https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> > > > [3]
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1502/
> > > > [4]
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> > > > [5]
> > >
> https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> > > > [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > [7]
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> > > > [8]
> https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> > > > [9] https://github.com/apache/flink-web/pull/531
> > > >
> > >
>

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Jingsong Li <ji...@gmail.com>.

Hi, Konstantin and OpenInx,

I have updated https://github.com/apache/flink-web/pull/531 , you can
take a review~

Best,
Jingsong

On Thu, May 5, 2022 at 3:07 PM OpenInx <op...@gmail.com> wrote:
>
> +1 ( non-binding) for the release. I agree with Konstantin that we can add
> more materials about the table-store for the voting.
>
>
>    1. Download the source tarball, signature (.asc), and checksum
>    (.sha512):   OK
>    2. Import gpg keys: download KEYS and run gpg --import
>    /path/to/downloaded/KEYS (optional if this hasn’t changed) :  OK
>    3. Verify the signature by running: gpg --verify
>    flink-table-store-0.1.0-src.tgz.asc:  OK
>    4. Verify the checksum by running: shasum -a 256 -c
>    flink-table-store-0.1.0-src.tgz.sha512 flink-table-store-0.1.0-src.tgz :  OK
>    5. Untar the archive and go into the source directory: tar xzf
>    flink-table-store-0.1.0-src.tgz && cd flink-table-store-0.1.0:  OK
>    6. Build and test the project: mvn clean package (use Java 8) :   All
>    unit tests passed, except the e2e tests. Seems we will need to set up a
>    docker environment to run those e2e tests successfully.
>    7. Verify the apache flink access table store:
>
> ./bin/sql-client.sh -j
> /Users/openinx/Downloads/flink-table-store-0.1.0/flink-table-store-dist/target/flink-table-store-dist-0.1.0.jar
> embedded shell
>
> SET 'table-store.path' = '/Users/openinx/test/table-store' ;
>
> SET 'execution.runtime-mode'='batch';
>
> SET 'sql-client.execution.result-mode' = 'tableau';
>
> CREATE TABLE MyTable (
>
> user_id BIGINT,
>
> item_id BIGINT,
>
> behavior STRING,
>
> dt STRING,
>
> PRIMARY KEY (dt, user_id) NOT ENFORCED
>
> ) PARTITIONED BY (dt) WITH (
>
> 'bucket' = '4'
>
> );
>
> INSERT INTO MyTable VALUES
>
> (100, 200, 'buy', '2022-05-04'),
>
> (101, 201, 'save', '2022-05-04'),
>
> (101, 201, 'purchase', '2022-05-04');
>
>
> SELECT * FROM MyTable;
>
> +---------+---------+----------+------------+
>
> | user_id | item_id | behavior | dt |
>
> +---------+---------+----------+------------+
>
> | 100 | 200 | buy | 2022-05-04 |
>
> | 101 | 201 | purchase | 2022-05-04 |
>
> +---------+---------+----------+------------+
>
> 2 rows in set
>
> On Thu, May 5, 2022 at 2:39 PM Nicholas Jiang <ni...@apache.org>
> wrote:
>
> > Hi everyone,
> >
> > +1 for the release (non-binding).
> >
> > - Built and compiled source codes [PASSED]
> > - Went through quick start guide [PASSED]
> > - Checked README.md [PASSED]
> > - Checked that use the table store jar to build query table application
> > [PASSED]
> >
> > Best regards,
> >
> > Nicholas Jiang
> >
> > On 2022/04/29 02:24:09 Jingsong Li wrote:
> > > Hi everyone,
> > >
> > > Please review and vote on the release candidate #2 for the version 0.1.0
> > of
> > > Apache Flink Table Store, as follows:
> > >
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > **Release Overview**
> > >
> > > As an overview, the release consists of the following:
> > > a) Table Store canonical source distribution, to be deployed to the
> > > release repository at dist.apache.org
> > > b) Maven artifacts to be deployed to the Maven Central Repository
> > >
> > > **Staging Areas to Review**
> > >
> > > The staging areas containing the above mentioned artifacts are as
> > follows,
> > > for your review:
> > > * All artifacts for a) and b) can be found in the corresponding dev
> > > repository at dist.apache.org [2]
> > > * All artifacts for c) can be found at the Apache Nexus Repository [3]
> > > * Pre Bundled Binaries Jar can work fine with quick start [4][5]
> > >
> > > All artifacts are signed with the key
> > > 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> > >
> > > Other links for your review:
> > > * JIRA release notes [7]
> > > * source code tag "release-0.1.0-rc2" [8]
> > > * PR to update the website Downloads page to include Table Store
> > > links [9]
> > >
> > > **Vote Duration**
> > >
> > > The voting time will run for at least 72 hours.
> > > It is adopted by majority approval, with at least 3 PMC affirmative
> > votes.
> > >
> > > Best,
> > > Jingsong Lee
> > >
> > > [1]
> > https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> > > [2]
> > https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> > > [3]
> > https://repository.apache.org/content/repositories/orgapacheflink-1502/
> > > [4]
> > https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> > > [5]
> > https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> > > [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > [7]
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> > > [8] https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> > > [9] https://github.com/apache/flink-web/pull/531
> > >
> >

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by OpenInx <op...@gmail.com>.

+1 ( non-binding) for the release. I agree with Konstantin that we can add
more materials about the table-store for the voting.


   1. Download the source tarball, signature (.asc), and checksum
   (.sha512):   OK
   2. Import gpg keys: download KEYS and run gpg --import
   /path/to/downloaded/KEYS (optional if this hasn’t changed) :  OK
   3. Verify the signature by running: gpg --verify
   flink-table-store-0.1.0-src.tgz.asc:  OK
   4. Verify the checksum by running: shasum -a 256 -c
   flink-table-store-0.1.0-src.tgz.sha512 flink-table-store-0.1.0-src.tgz :  OK
   5. Untar the archive and go into the source directory: tar xzf
   flink-table-store-0.1.0-src.tgz && cd flink-table-store-0.1.0:  OK
   6. Build and test the project: mvn clean package (use Java 8) :   All
   unit tests passed, except the e2e tests. Seems we will need to set up a
   docker environment to run those e2e tests successfully.
   7. Verify the apache flink access table store:

./bin/sql-client.sh -j
/Users/openinx/Downloads/flink-table-store-0.1.0/flink-table-store-dist/target/flink-table-store-dist-0.1.0.jar
embedded shell

SET 'table-store.path' = '/Users/openinx/test/table-store' ;

SET 'execution.runtime-mode'='batch';

SET 'sql-client.execution.result-mode' = 'tableau';

CREATE TABLE MyTable (

user_id BIGINT,

item_id BIGINT,

behavior STRING,

dt STRING,

PRIMARY KEY (dt, user_id) NOT ENFORCED

) PARTITIONED BY (dt) WITH (

'bucket' = '4'

);

INSERT INTO MyTable VALUES

(100, 200, 'buy', '2022-05-04'),

(101, 201, 'save', '2022-05-04'),

(101, 201, 'purchase', '2022-05-04');


SELECT * FROM MyTable;

+---------+---------+----------+------------+

| user_id | item_id | behavior | dt |

+---------+---------+----------+------------+

| 100 | 200 | buy | 2022-05-04 |

| 101 | 201 | purchase | 2022-05-04 |

+---------+---------+----------+------------+

2 rows in set

On Thu, May 5, 2022 at 2:39 PM Nicholas Jiang <ni...@apache.org>
wrote:

> Hi everyone,
>
> +1 for the release (non-binding).
>
> - Built and compiled source codes [PASSED]
> - Went through quick start guide [PASSED]
> - Checked README.md [PASSED]
> - Checked that use the table store jar to build query table application
> [PASSED]
>
> Best regards,
>
> Nicholas Jiang
>
> On 2022/04/29 02:24:09 Jingsong Li wrote:
> > Hi everyone,
> >
> > Please review and vote on the release candidate #2 for the version 0.1.0
> of
> > Apache Flink Table Store, as follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > **Release Overview**
> >
> > As an overview, the release consists of the following:
> > a) Table Store canonical source distribution, to be deployed to the
> > release repository at dist.apache.org
> > b) Maven artifacts to be deployed to the Maven Central Repository
> >
> > **Staging Areas to Review**
> >
> > The staging areas containing the above mentioned artifacts are as
> follows,
> > for your review:
> > * All artifacts for a) and b) can be found in the corresponding dev
> > repository at dist.apache.org [2]
> > * All artifacts for c) can be found at the Apache Nexus Repository [3]
> > * Pre Bundled Binaries Jar can work fine with quick start [4][5]
> >
> > All artifacts are signed with the key
> > 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> >
> > Other links for your review:
> > * JIRA release notes [7]
> > * source code tag "release-0.1.0-rc2" [8]
> > * PR to update the website Downloads page to include Table Store
> > links [9]
> >
> > **Vote Duration**
> >
> > The voting time will run for at least 72 hours.
> > It is adopted by majority approval, with at least 3 PMC affirmative
> votes.
> >
> > Best,
> > Jingsong Lee
> >
> > [1]
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> > [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> > [3]
> https://repository.apache.org/content/repositories/orgapacheflink-1502/
> > [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> > [5]
> https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> > [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [7]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> > [8] https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> > [9] https://github.com/apache/flink-web/pull/531
> >
>

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Nicholas Jiang <ni...@apache.org>.

Hi everyone,

+1 for the release (non-binding). 

- Built and compiled source codes [PASSED]
- Went through quick start guide [PASSED]
- Checked README.md [PASSED]
- Checked that use the table store jar to build query table application [PASSED]

Best regards,

Nicholas Jiang

On 2022/04/29 02:24:09 Jingsong Li wrote:
> Hi everyone,
> 
> Please review and vote on the release candidate #2 for the version 0.1.0 of
> Apache Flink Table Store, as follows:
> 
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> **Release Overview**
> 
> As an overview, the release consists of the following:
> a) Table Store canonical source distribution, to be deployed to the
> release repository at dist.apache.org
> b) Maven artifacts to be deployed to the Maven Central Repository
> 
> **Staging Areas to Review**
> 
> The staging areas containing the above mentioned artifacts are as follows,
> for your review:
> * All artifacts for a) and b) can be found in the corresponding dev
> repository at dist.apache.org [2]
> * All artifacts for c) can be found at the Apache Nexus Repository [3]
> * Pre Bundled Binaries Jar can work fine with quick start [4][5]
> 
> All artifacts are signed with the key
> 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> 
> Other links for your review:
> * JIRA release notes [7]
> * source code tag "release-0.1.0-rc2" [8]
> * PR to update the website Downloads page to include Table Store
> links [9]
> 
> **Vote Duration**
> 
> The voting time will run for at least 72 hours.
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
> 
> Best,
> Jingsong Lee
> 
> [1] https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> [2] https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> [3] https://repository.apache.org/content/repositories/orgapacheflink-1502/
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> [5] https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> [7] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> [8] https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> [9] https://github.com/apache/flink-web/pull/531
>

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Konstantin Knauf <kn...@apache.org>.

+1 (binding)

* mvn clean package - PASSED
* checked signatures & checksums of source artifacts - OK
* went through quick start - WORKS
* skimmed over NOTICE file - LOOKS GOOD

I also read over the announcement blog post. In my opinion, we could try to
motivate the project a bit better. What is the problem that
flink-table-store will solve? What is its relationship to Apache Flink
itself? Since this is the first release, I am sure a lot of users will ask
themselves these questions.





Am Fr., 29. Apr. 2022 um 11:49 Uhr schrieb Caizhi Weng <tsreaper96@gmail.com
>:

> Hi all!
>
> +1 for the release (non-binding). I've tested the jar with a standalone
> cluster and SQL client.
>
>    - Compiled the sources;
>    - Run through quick start guide;
>    - Test all supported data types;
>    - Check that table store jar has no conflict with orc / avro format and
>    kafka connector;
>    - Check that both file store and log store works.
>
> I haven't checked the signatures as my gnupg version is old.
>
> Jingsong Li <ji...@gmail.com> 于2022年4月29日周五 10:24写道：
>
> > Hi everyone,
> >
> > Please review and vote on the release candidate #2 for the version 0.1.0
> of
> > Apache Flink Table Store, as follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > **Release Overview**
> >
> > As an overview, the release consists of the following:
> > a) Table Store canonical source distribution, to be deployed to the
> > release repository at dist.apache.org
> > b) Maven artifacts to be deployed to the Maven Central Repository
> >
> > **Staging Areas to Review**
> >
> > The staging areas containing the above mentioned artifacts are as
> follows,
> > for your review:
> > * All artifacts for a) and b) can be found in the corresponding dev
> > repository at dist.apache.org [2]
> > * All artifacts for c) can be found at the Apache Nexus Repository [3]
> > * Pre Bundled Binaries Jar can work fine with quick start [4][5]
> >
> > All artifacts are signed with the key
> > 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> >
> > Other links for your review:
> > * JIRA release notes [7]
> > * source code tag "release-0.1.0-rc2" [8]
> > * PR to update the website Downloads page to include Table Store
> > links [9]
> >
> > **Vote Duration**
> >
> > The voting time will run for at least 72 hours.
> > It is adopted by majority approval, with at least 3 PMC affirmative
> votes.
> >
> > Best,
> > Jingsong Lee
> >
> > [1]
> >
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> > [2]
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> > [3]
> > https://repository.apache.org/content/repositories/orgapacheflink-1502/
> > [4]
> >
> https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> > [5]
> >
> https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> > [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [7]
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> > [8] https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> > [9] https://github.com/apache/flink-web/pull/531
> >
>


-- 
https://twitter.com/snntrable
https://github.com/knaufk

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Caizhi Weng <ts...@gmail.com>.

Hi all!

+1 for the release (non-binding). I've tested the jar with a standalone
cluster and SQL client.

   - Compiled the sources;
   - Run through quick start guide;
   - Test all supported data types;
   - Check that table store jar has no conflict with orc / avro format and
   kafka connector;
   - Check that both file store and log store works.

I haven't checked the signatures as my gnupg version is old.

Jingsong Li <ji...@gmail.com> 于2022年4月29日周五 10:24写道：

> Hi everyone,
>
> Please review and vote on the release candidate #2 for the version 0.1.0 of
> Apache Flink Table Store, as follows:
>
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> **Release Overview**
>
> As an overview, the release consists of the following:
> a) Table Store canonical source distribution, to be deployed to the
> release repository at dist.apache.org
> b) Maven artifacts to be deployed to the Maven Central Repository
>
> **Staging Areas to Review**
>
> The staging areas containing the above mentioned artifacts are as follows,
> for your review:
> * All artifacts for a) and b) can be found in the corresponding dev
> repository at dist.apache.org [2]
> * All artifacts for c) can be found at the Apache Nexus Repository [3]
> * Pre Bundled Binaries Jar can work fine with quick start [4][5]
>
> All artifacts are signed with the key
> 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
>
> Other links for your review:
> * JIRA release notes [7]
> * source code tag "release-0.1.0-rc2" [8]
> * PR to update the website Downloads page to include Table Store
> links [9]
>
> **Vote Duration**
>
> The voting time will run for at least 72 hours.
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
>
> Best,
> Jingsong Lee
>
> [1]
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> [3]
> https://repository.apache.org/content/repositories/orgapacheflink-1502/
> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> [5]
> https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> [7]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> [8] https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> [9] https://github.com/apache/flink-web/pull/531
>

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Jingsong Li <ji...@gmail.com>.

Hi Konstantin,

Thanks for your suggestions. I will add more descriptions.

Best,
Jingsong

On Sat, Apr 30, 2022 at 12:14 AM Jane Chan <qi...@gmail.com> wrote:
>
> Hi all,
>
> +1 for the release (non-binding). The check follows the Jira release
> note[1] and is listed as follows.
>
>     - Verify that the source distributions of [2] do not contain any
> binaries;
>     - Build the source distribution to ensure all source files have Apache
> headers, and test functionality against Maven Staged Artifacts under Java8
> and Scala 2.12;
>     - Check README.md;
>     - Check file hashes(MD5 and SHA-1 for [3], SHA-512 for [2]) and GPG
> signatures for [2] and [3] with gpg 2.3.6;
>
> Best,
> Jane Chan
>
> [1]
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> [3] https://repository.apache.org/content/repositories/orgapacheflink-1502/
>
> On Fri, Apr 29, 2022 at 10:24 AM Jingsong Li <ji...@gmail.com> wrote:
>
> > Hi everyone,
> >
> > Please review and vote on the release candidate #2 for the version 0.1.0 of
> > Apache Flink Table Store, as follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > **Release Overview**
> >
> > As an overview, the release consists of the following:
> > a) Table Store canonical source distribution, to be deployed to the
> > release repository at dist.apache.org
> > b) Maven artifacts to be deployed to the Maven Central Repository
> >
> > **Staging Areas to Review**
> >
> > The staging areas containing the above mentioned artifacts are as follows,
> > for your review:
> > * All artifacts for a) and b) can be found in the corresponding dev
> > repository at dist.apache.org [2]
> > * All artifacts for c) can be found at the Apache Nexus Repository [3]
> > * Pre Bundled Binaries Jar can work fine with quick start [4][5]
> >
> > All artifacts are signed with the key
> > 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
> >
> > Other links for your review:
> > * JIRA release notes [7]
> > * source code tag "release-0.1.0-rc2" [8]
> > * PR to update the website Downloads page to include Table Store
> > links [9]
> >
> > **Vote Duration**
> >
> > The voting time will run for at least 72 hours.
> > It is adopted by majority approval, with at least 3 PMC affirmative votes.
> >
> > Best,
> > Jingsong Lee
> >
> > [1]
> > https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> > [2]
> > https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> > [3]
> > https://repository.apache.org/content/repositories/orgapacheflink-1502/
> > [4]
> > https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> > [5]
> > https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> > [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [7]
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> > [8] https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> > [9] https://github.com/apache/flink-web/pull/531
> >

Re: [VOTE] Apache Flink Table Store 0.1.0, release candidate #2

Posted by Jane Chan <qi...@gmail.com>.

Hi all,

+1 for the release (non-binding). The check follows the Jira release
note[1] and is listed as follows.

    - Verify that the source distributions of [2] do not contain any
binaries;
    - Build the source distribution to ensure all source files have Apache
headers, and test functionality against Maven Staged Artifacts under Java8
and Scala 2.12;
    - Check README.md;
    - Check file hashes(MD5 and SHA-1 for [3], SHA-512 for [2]) and GPG
signatures for [2] and [3] with gpg 2.3.6;

Best,
Jane Chan

[1]
https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
[3] https://repository.apache.org/content/repositories/orgapacheflink-1502/

On Fri, Apr 29, 2022 at 10:24 AM Jingsong Li <ji...@gmail.com> wrote:

> Hi everyone,
>
> Please review and vote on the release candidate #2 for the version 0.1.0 of
> Apache Flink Table Store, as follows:
>
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> **Release Overview**
>
> As an overview, the release consists of the following:
> a) Table Store canonical source distribution, to be deployed to the
> release repository at dist.apache.org
> b) Maven artifacts to be deployed to the Maven Central Repository
>
> **Staging Areas to Review**
>
> The staging areas containing the above mentioned artifacts are as follows,
> for your review:
> * All artifacts for a) and b) can be found in the corresponding dev
> repository at dist.apache.org [2]
> * All artifacts for c) can be found at the Apache Nexus Repository [3]
> * Pre Bundled Binaries Jar can work fine with quick start [4][5]
>
> All artifacts are signed with the key
> 2C2B6A653B07086B65E4369F7C76245E0A318150 [6]
>
> Other links for your review:
> * JIRA release notes [7]
> * source code tag "release-0.1.0-rc2" [8]
> * PR to update the website Downloads page to include Table Store
> links [9]
>
> **Vote Duration**
>
> The voting time will run for at least 72 hours.
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
>
> Best,
> Jingsong Lee
>
> [1]
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Table+Store+Release
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-table-store-0.1.0-rc2/
> [3]
> https://repository.apache.org/content/repositories/orgapacheflink-1502/
> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1502/org/apache/flink/flink-table-store-dist/0.1.0/flink-table-store-dist-0.1.0.jar
> [5]
> https://nightlies.apache.org/flink/flink-table-store-docs-release-0.1/docs/try-table-store/quick-start/
> [6] https://dist.apache.org/repos/dist/release/flink/KEYS
> [7]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351234
> [8] https://github.com/apache/flink-table-store/tree/release-0.1.0-rc2
> [9] https://github.com/apache/flink-web/pull/531
>