[jira] [Issue Comment Edited] (GERONIMO-6025) Validate that servlet and filter mapping url-patterns don't have internal line breaks

["Rex Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056296#comment-13056296 ] 

Rex Wang edited comment on GERONIMO-6025 at 6/28/11 4:49 AM:
-------------------------------------------------------------

Hi, David,
Just uploaded a patch(GERONIMO-6025-central-validation.patch) to make the validation happen in a single place. I found we have WebDeploymentValidationUtils before, so use it. Is that ok?

btw, JspPropertyGroup also have a url-pattern prop need TrimStringAdapter...

Really appreciate you could help this issue. thanks. 

      was (Author: rwonly):
    Hi, David,
Just loaded a patch(GERONIMO-6025-central-validation.patch) to make the validation happen in a single place. I found we have WebDeploymentValidationUtils before, so use it. Is that ok?

btw, JspPropertyGroup also have a url-pattern prop need TrimStringAdapter...

Really appreciate you could help this issue. thanks. 
  
> Validate that servlet and filter mapping url-patterns don't have internal line breaks
> -------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-6025
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6025
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: web
>    Affects Versions: 3.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 3.0
>
>         Attachments: GERONIMO-6025-central-validation.patch
>
>
> they aren't supposed to allow internal line breaks, we need to check.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira