You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Dave Newton <da...@gmail.com> on 2011/11/29 21:02:26 UTC
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Let's talk about the name; I'm not sure it needs to be explicitly
xwork2 any more.
I might consider something like o.a.s2.core or something like that.
On Tue, Nov 29, 2011 at 2:55 PM, Lukasz Lenart (Created) (JIRA)
<ji...@apache.org> wrote:
> Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
> -----------------------------------------------------------
>
> Key: WW-3714
> URL: https://issues.apache.org/jira/browse/WW-3714
> Project: Struts 2
> Issue Type: Task
> Components: Core Actions
> Affects Versions: 2.2.3.1
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Minor
> Fix For: 2.3
>
>
> To finish acquisition of XWork project, all the packages have to be renamed to much current Struts 2 package hierarchy
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to
org.apache.struts2.xwork2
Posted by Rene Gielen <re...@googlemail.com>.
*sigh*
Good! For a moment I was really scared there would have been such commit
already once I read the mail - breaking API changes should under all
circumstances happen in new major releases, and they need upfront
communication to our user community, as well as tool providers such as
IDEA (Yann Cebron in the case of the Struts 2 plugin). Good to see it
scheduduled for 3.x now.
Cheers,
- René
On 30.11.11 16:57, Łukasz Lenart wrote:
> 2011/11/30 Maurizio Cucchiara <mc...@apache.org>:
>> At that time there was no planning for 3.x version :)
>> Furthermore, AFAIK the original problem is already solved in the trunk,
>> isn't it?
> Yes, it was but that change should be done months ago, when S2 absorb XWork :/
>
>> As I said before, rename the OS package will break the
>> backward-compatibility, so, take for example IDE like IDEA: because of this
>> its struts integration might stop to work
>> Since there is a planning for new release, why don't we take advantage of
>> this to make cleaner the concept?
>> Just my 2 cents. WDYT?
> Maybe you're right, let's leave it for 3.x now, we can always do it
> even before releasing 3.x ;-)
> I'll ask JetBrains about that problem.
>
>
> Kind regards
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
I've setup a new build of Struts3
https://builds.apache.org/view/S-Z/view/Struts/job/Struts3/
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
2011/11/30 Maurizio Cucchiara <mc...@apache.org>:
> Yes, I know (I have already updated that page :))
> Were you asking to add the svn details on that page?
Yes, details about where the development of S3 happens ;-)
Thanks in advance
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Maurizio Cucchiara <mc...@apache.org>.
Yes, I know (I have already updated that page :))
Were you asking to add the svn details on that page?
Twitter :http://www.twitter.com/m_cucchiara
G+ :https://plus.google.com/107903711540963855921
Linkedin :http://www.linkedin.com/in/mauriziocucchiara
Maurizio Cucchiara
2011/11/30 Łukasz Lenart <lu...@googlemail.com>
> I've created a wiki page regarding S3 here [1], I'd like to keep any
> important information on that page for now, before we'll request a new
> space on Confluence
>
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
2011/11/30 Maurizio Cucchiara <mc...@apache.org>:
>> Ok, will try. Could you update wiki as well ?
>
> Do you mean adding svn details/instructions?
I've created a wiki page regarding S3 here [1], I'd like to keep any
important information on that page for now, before we'll request a new
space on Confluence
[1] https://cwiki.apache.org/confluence/display/WW/Struts3Planning
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Maurizio Cucchiara <mc...@apache.org>.
>
> Ok, will try. Could you update wiki as well ?
Do you mean adding svn details/instructions?
Twitter :http://www.twitter.com/m_cucchiara
G+ :https://plus.google.com/107903711540963855921
Linkedin :http://www.linkedin.com/in/mauriziocucchiara
Maurizio Cucchiara
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
2011/11/30 Maurizio Cucchiara <mc...@apache.org>:
> Hi Lukasz,
> I have just added a new 3.x branch based on the current trunk, what about to
> apply your patch on that?
Ok, will try. Could you update wiki as well ?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Maurizio Cucchiara <mc...@apache.org>.
Hi Lukasz,
I have just added a new 3.x branch based on the current trunk, what about
to apply your patch on that?
Twitter :http://www.twitter.com/m_cucchiara
G+ :https://plus.google.com/107903711540963855921
Linkedin :http://www.linkedin.com/in/mauriziocucchiara
Maurizio Cucchiara
2011/11/30 Łukasz Lenart <lu...@googlemail.com>
> Maybe you're right, let's leave it for 3.x now, we can always do it
> even before releasing 3.x ;-)
>
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
2011/11/30 Maurizio Cucchiara <mc...@apache.org>:
> At that time there was no planning for 3.x version :)
> Furthermore, AFAIK the original problem is already solved in the trunk,
> isn't it?
Yes, it was but that change should be done months ago, when S2 absorb XWork :/
> As I said before, rename the OS package will break the
> backward-compatibility, so, take for example IDE like IDEA: because of this
> its struts integration might stop to work
> Since there is a planning for new release, why don't we take advantage of
> this to make cleaner the concept?
> Just my 2 cents. WDYT?
Maybe you're right, let's leave it for 3.x now, we can always do it
even before releasing 3.x ;-)
I'll ask JetBrains about that problem.
Kind regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
2011/11/30 Maurizio Cucchiara <mc...@apache.org>:
> As I said before, rename the OS package will break the
> backward-compatibility, so, take for example IDE like IDEA: because of this
> its struts integration might stop to work
I talked to JetBrains guys about S3/S2.5 support and there be no
problem with that and they will start looking into it soon after
they'll release the new IntelliJ IDEA 11.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Maurizio Cucchiara <mc...@apache.org>.
At that time there was no planning for 3.x version :)
Furthermore, AFAIK the original problem is already solved in the trunk,
isn't it?
As I said before, rename the OS package will break the
backward-compatibility, so, take for example IDE like IDEA: because of this
its struts integration might stop to work
Since there is a planning for new release, why don't we take advantage of
this to make cleaner the concept?
Just my 2 cents. WDYT?
Twitter :http://www.twitter.com/m_cucchiara
G+ :https://plus.google.com/107903711540963855921
Linkedin :http://www.linkedin.com/in/mauriziocucchiara
Maurizio Cucchiara
2011/11/30 Łukasz Lenart <lu...@googlemail.com>
> But we already discussed that [1] and we shouldn't postpone clean up
> process till 3.x, it the same case as with DTDs.
>
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
2011/11/30 Maurizio Cucchiara <mc...@apache.org>:
>> Should I commit ?
>
> I'm not sure this is the right time to change the package name, we should
> make cleaner the loss of backward-compatibility, maybe we should wait until
> 3.x release?
But we already discussed that [1] and we shouldn't postpone clean up
process till 3.x, it the same case as with DTDs.
[1] http://markmail.org/message/qlzgnlkbizzzksj5
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Maurizio Cucchiara <mc...@apache.org>.
> Should I commit ?
I'm not sure this is the right time to change the package name, we should
make cleaner the loss of backward-compatibility, maybe we should wait until
3.x release?
Twitter :http://www.twitter.com/m_cucchiara
G+ :https://plus.google.com/107903711540963855921
Linkedin :http://www.linkedin.com/in/mauriziocucchiara
Maurizio Cucchiara
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
Should I commit ?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
Packages renamed, 1349 files were affected ;-)
Kind regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
2011/11/30 Steven Benitez <st...@gmail.com>:
> org.apache.struts2.xwork; keep it a separate JAR, but part of the S2 project
> (as it currently is).
Yes, it'll remain as is.
> Since renaming the package is a breaking change, do we want to make any
> other API changes to XWork now or are we fine with just changing the package
> now and making (potential) API changes later?
Just rename the package and clean up other stuff related to
com.opensymphony, no API changes now.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Steven Benitez <st...@gmail.com>.
org.apache.struts2.xwork; keep it a separate JAR, but part of the S2
project (as it currently is).
Since renaming the package is a breaking change, do we want to make any
other API changes to XWork now or are we fine with just changing the
package now and making (potential) API changes later?
2011/11/29 Łukasz Lenart <lu...@googlemail.com>
> 2011/11/29 Dave Newton <da...@gmail.com>:
> > As long as it can be referenced as an individual component, I'm not
> > super-concerned about what it's called.
>
> I just wanna clean up what's left after OpenSymphony, as we had the
> same issue with DTDs that were pointing to the OpenSymphony site.
>
> > I agree we need to preserve its utility outside of web-related things,
> > though. (I actually *did* use it for a non-web thing once.)
>
> +1
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> Warszawa JUG conference - Confitura http://confitura.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
2011/11/29 Dave Newton <da...@gmail.com>:
> As long as it can be referenced as an individual component, I'm not
> super-concerned about what it's called.
I just wanna clean up what's left after OpenSymphony, as we had the
same issue with DTDs that were pointing to the OpenSymphony site.
> I agree we need to preserve its utility outside of web-related things,
> though. (I actually *did* use it for a non-web thing once.)
+1
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Dave Newton <da...@gmail.com>.
As long as it can be referenced as an individual component, I'm not
super-concerned about what it's called.
I agree we need to preserve its utility outside of web-related things,
though. (I actually *did* use it for a non-web thing once.)
Dave
2011/11/29 Łukasz Lenart <lu...@googlemail.com>:
> 2011/11/29 Dave Newton <da...@gmail.com>:
>> Then we shouldn't be merging it into the S2 code base to begin with, IMO.
>>
>> Moving it to a top-level project would require incubation etc., I'm
>> not convinced it's worth it for a component lightly-used outside of
>> S2.
>
> I just remember discussion about leaving XWork alone and not to
> integrate it into S2 code base - moving classes, dropping xwork-core
> and so on...
> XWork as a command pattern base project, not connect to WWW, should be
> keep separately, if not, we should consider merging its code base into
> S2.
>
> And as I understand incubation is mostly needed to clear license
> related issues and rights.
>
>> Another alternative would be to do the restructuring internal to S2,
>> keeping it separated as we already want, then promoting it to a TLP
>> when (and if) it seems reasonable, out of s2.
>>
>> With that in mind, it doesn't make sense to rename it to o.a.s2.xw2,
>> but rather o.a.xw2, but leave it in the S2 codebase until it's been
>> revamped.
>
> But from other side, we had the same situation some time ago (when XW
> was part of OpenSymphony) and it was pain in the ass, especially for
> developers :/
>
> So maybe just move it to o.a.s2.xwork and keep it clean.
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> Warszawa JUG conference - Confitura http://confitura.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
2011/11/29 Dave Newton <da...@gmail.com>:
> Then we shouldn't be merging it into the S2 code base to begin with, IMO.
>
> Moving it to a top-level project would require incubation etc., I'm
> not convinced it's worth it for a component lightly-used outside of
> S2.
I just remember discussion about leaving XWork alone and not to
integrate it into S2 code base - moving classes, dropping xwork-core
and so on...
XWork as a command pattern base project, not connect to WWW, should be
keep separately, if not, we should consider merging its code base into
S2.
And as I understand incubation is mostly needed to clear license
related issues and rights.
> Another alternative would be to do the restructuring internal to S2,
> keeping it separated as we already want, then promoting it to a TLP
> when (and if) it seems reasonable, out of s2.
>
> With that in mind, it doesn't make sense to rename it to o.a.s2.xw2,
> but rather o.a.xw2, but leave it in the S2 codebase until it's been
> revamped.
But from other side, we had the same situation some time ago (when XW
was part of OpenSymphony) and it was pain in the ass, especially for
developers :/
So maybe just move it to o.a.s2.xwork and keep it clean.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Dave Newton <da...@gmail.com>.
Then we shouldn't be merging it into the S2 code base to begin with, IMO.
Moving it to a top-level project would require incubation etc., I'm
not convinced it's worth it for a component lightly-used outside of
S2.
Another alternative would be to do the restructuring internal to S2,
keeping it separated as we already want, then promoting it to a TLP
when (and if) it seems reasonable, out of s2.
With that in mind, it doesn't make sense to rename it to o.a.s2.xw2,
but rather o.a.xw2, but leave it in the S2 codebase until it's been
revamped.
d.
2011/11/29 Łukasz Lenart <lu...@googlemail.com>:
> 2011/11/29 Dave Newton <da...@gmail.com>:
>> Let's talk about the name; I'm not sure it needs to be explicitly
>> xwork2 any more.
>>
>> I might consider something like o.a.s2.core or something like that.
>
> XWork should stay as a separated project, maybe someday a top project
> and maybe we should rename what we have right now as a struts2-core to
> o.a.s2.core
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> Warszawa JUG conference - Confitura http://confitura.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [jira] [Created] (WW-3714) Rename org.opensymphony.xwork2 to org.apache.struts2.xwork2
Posted by Łukasz Lenart <lu...@googlemail.com>.
2011/11/29 Dave Newton <da...@gmail.com>:
> Let's talk about the name; I'm not sure it needs to be explicitly
> xwork2 any more.
>
> I might consider something like o.a.s2.core or something like that.
XWork should stay as a separated project, maybe someday a top project
and maybe we should rename what we have right now as a struts2-core to
o.a.s2.core
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org