You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org> on 2019/01/30 05:46:32 UTC
[native-toolchain-CR] Use git:// protocol to clone kudu
hector.acosta@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12303
Change subject: Use git:// protocol to clone kudu
......................................................................
Use git:// protocol to clone kudu
All the platforms on the master branch can clone using the git protocol.
Change-Id: I60eaff3f38d9659ed79693b93e9232a97a1d5d9e
---
M source/kudu/build.sh
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/03/12303/1
--
To view, visit http://gerrit.cloudera.org:8080/12303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60eaff3f38d9659ed79693b93e9232a97a1d5d9e
Gerrit-Change-Number: 12303
Gerrit-PatchSet: 1
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
[native-toolchain-CR] Use git:// protocol to clone kudu
Posted by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org>.
hector.acosta@cloudera.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12303 )
Change subject: Use git:// protocol to clone kudu
......................................................................
Use git:// protocol to clone kudu
All the platforms on the master branch can clone using the git protocol.
Change-Id: I60eaff3f38d9659ed79693b93e9232a97a1d5d9e
---
M source/kudu/build.sh
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/03/12303/2
--
To view, visit http://gerrit.cloudera.org:8080/12303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I60eaff3f38d9659ed79693b93e9232a97a1d5d9e
Gerrit-Change-Number: 12303
Gerrit-PatchSet: 2
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
[native-toolchain-CR] Use git:// protocol to clone kudu
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12303 )
Change subject: Use git:// protocol to clone kudu
......................................................................
Patch Set 2:
I'm not too up-to-speed with the pros and cons of different git protocols. I understand git:// has some security limitations.
I believe all of the platforms that build Kudu can connect to github over ssh.
--
To view, visit http://gerrit.cloudera.org:8080/12303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60eaff3f38d9659ed79693b93e9232a97a1d5d9e
Gerrit-Change-Number: 12303
Gerrit-PatchSet: 2
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 22:57:08 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Use git:// protocol to clone kudu
Posted by "hector.acosta@cloudera.com (Code Review)" <ge...@cloudera.org>.
hector.acosta@cloudera.com has abandoned this change. ( http://gerrit.cloudera.org:8080/12303 )
Change subject: Use git:// protocol to clone kudu
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/12303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I60eaff3f38d9659ed79693b93e9232a97a1d5d9e
Gerrit-Change-Number: 12303
Gerrit-PatchSet: 2
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Use git:// protocol to clone kudu
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12303 )
Change subject: Use git:// protocol to clone kudu
......................................................................
Patch Set 2:
> Patch Set 2:
>
> I'm not too up-to-speed with the pros and cons of different git protocols. I understand git:// has some security limitations.
>
> I believe all of the platforms that build Kudu can connect to github over ssh.
Yes, git:// is unauthenticated, so it can be subject to a man-in-the-middle attack.
The problem with SSH is not a protocol problem, it's an authentication problem: SSH wants to perform mutual authN, so you need to supply a key. In our internal automation framework all the build workers came equipped with an old, legacy private key that was recognized by github.com, so things "just worked". This key was recently disabled, and it would be much better if we did not have to supply another key just to keep the build process going.
HTTPS would solve the server authN/MITM problem once we figure out the SSL versions we need to run. Until that happens git:// would be a workable option as long as we ensure that our binary publishing builds run off of internal mirrors.
--
To view, visit http://gerrit.cloudera.org:8080/12303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60eaff3f38d9659ed79693b93e9232a97a1d5d9e
Gerrit-Change-Number: 12303
Gerrit-PatchSet: 2
Gerrit-Owner: hector.acosta@cloudera.com <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 13:41:08 +0000
Gerrit-HasComments: No