You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by MaxGekk <gi...@git.apache.org> on 2018/11/14 21:43:49 UTC
[GitHub] spark pull request #23039: [SPARK-26066][SQL] Moving truncatedString to sql/...
GitHub user MaxGekk opened a pull request:
https://github.com/apache/spark/pull/23039
[SPARK-26066][SQL] Moving truncatedString to sql/catalyst
## What changes were proposed in this pull request?
I propose to move truncatedString out of `core` to `sql/catalyst` because it is used only in sql/catalyst for restricting number of fields converted to strings from `TreeNode` and expressions of`StructType`. Also I introduced new SQL config `spark.sql.debug.maxToStringFields` to control maximum number fields up to which `truncatedString` cuts its input sequences.
## How was this patch tested?
Added a test to `QueryExecutionSuite` to check that `spark.sql.debug.maxToStringFields` impacts to behavior of `truncatedString`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MaxGekk/spark-1 truncated-string-catalyst
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/23039.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23039
----
commit 265a81031f670392f9a78a0b9fb130a7e3908727
Author: Maxim Gekk <ma...@...>
Date: 2018-09-25T11:31:02Z
Moving truncatedString out of core
commit 36de047eca9848288146f4e3491b437e38671105
Author: Maxim Gekk <ma...@...>
Date: 2018-11-14T21:34:40Z
Adding spark.sql.debug.maxToStringFields
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5227/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #99030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99030/testReport)** for PR 23039 at commit [`082254d`](https://github.com/apache/spark/commit/082254dd5ef36d84acd1103e7e2aedf4c922ea10).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #99106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99106/testReport)** for PR 23039 at commit [`e90f888`](https://github.com/apache/spark/commit/e90f888c6ab846335c781094bd11c7521a488324).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5157/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by MaxGekk <gi...@git.apache.org>.
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23039
@HyukjinKwon @kiszk Do you have any objections for this PR?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99121/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Moving truncatedString to sql/catalys...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #98841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98841/testReport)** for PR 23039 at commit [`36de047`](https://github.com/apache/spark/commit/36de047eca9848288146f4e3491b437e38671105).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Using new SQL config spark.sql.debug....
Posted by MaxGekk <gi...@git.apache.org>.
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23039
> let's fix PR description and title for that.
> One PR should have one theme with a proper title.
@HyukjinKwon @dongjoon-hyun I have renamed this PR. Is new title fine for you?
> We frequently search by commit title. Please don't split this PR into two sub PRs.
Sure, I will not.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Moving truncatedString to sql/catalys...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23039
@MaxGekk . One PR should have one theme with a proper title. We frequently search by commit title. Please don't split this PR into two sub PRs.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #99121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99121/testReport)** for PR 23039 at commit [`e90f888`](https://github.com/apache/spark/commit/e90f888c6ab846335c781094bd11c7521a488324).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23039
Retest this please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Moving truncatedString to sql/catalys...
Posted by MaxGekk <gi...@git.apache.org>.
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23039
@hvanhovell @gatorsmile @HyukjinKwon @cloud-fan Could you take a look at this PR, please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Moving truncatedString to sql/catalys...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #98915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98915/testReport)** for PR 23039 at commit [`7180c2e`](https://github.com/apache/spark/commit/7180c2ea672783d903f29c0013fd5e1817949ed6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23039: [SPARK-26066][SQL] Move truncatedString to sql/ca...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23039#discussion_r234303428
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/util/UtilsSuite.scala ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.util
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.sql.catalyst.util.truncatedString
+
+class UtilsSuite extends SparkFunSuite {
--- End diff --
`UtilsSuite` -> `UtilSuite` since the package is `org.apache.spark.sql.util`. Previously, it was in `Utils.scala`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #99121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99121/testReport)** for PR 23039 at commit [`e90f888`](https://github.com/apache/spark/commit/e90f888c6ab846335c781094bd11c7521a488324).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Moving truncatedString to sql/catalys...
Posted by MaxGekk <gi...@git.apache.org>.
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23039
The PR extracts a part of changes from #22429
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23039: [SPARK-26066][SQL] Move truncatedString to sql/ca...
Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23039#discussion_r234202827
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1594,6 +1594,13 @@ object SQLConf {
"WHERE, which does not follow SQL standard.")
.booleanConf
.createWithDefault(false)
+
+ val MAX_TO_STRING_FIELDS = buildConf("spark.sql.debug.maxToStringFields")
+ .doc("Maximum number of fields of sequence-like entries that can be converted to strings " +
--- End diff --
nit: `that` is not necessary if I am correct.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Moving truncatedString to sql/catalys...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #98841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98841/testReport)** for PR 23039 at commit [`36de047`](https://github.com/apache/spark/commit/36de047eca9848288146f4e3491b437e38671105).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #99106 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99106/testReport)** for PR 23039 at commit [`e90f888`](https://github.com/apache/spark/commit/e90f888c6ab846335c781094bd11c7521a488324).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #99030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99030/testReport)** for PR 23039 at commit [`082254d`](https://github.com/apache/spark/commit/082254dd5ef36d84acd1103e7e2aedf4c922ea10).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Moving truncatedString to sql/catalys...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #23039: [SPARK-26066][SQL] Move truncatedString to sql/ca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23039
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99030/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99106/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Moving truncatedString to sql/catalys...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23039
@MaxGekk, I think the main purpose of this PR is rather to introduce `spark.sql.debug.maxToStringFields` .. let's fix PR description and title for that.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #98927 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98927/testReport)** for PR 23039 at commit [`082254d`](https://github.com/apache/spark/commit/082254dd5ef36d84acd1103e7e2aedf4c922ea10).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Using new SQL config spark.sql.debug....
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23039
How about the following?
```
Move `truncatedString` to `sql/catalyst` and add `spark.sql.debug.maxToStringFields` conf
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #98915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98915/testReport)** for PR 23039 at commit [`7180c2e`](https://github.com/apache/spark/commit/7180c2ea672783d903f29c0013fd5e1817949ed6).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23039
Retest this please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23039
**[Test build #98927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98927/testReport)** for PR 23039 at commit [`082254d`](https://github.com/apache/spark/commit/082254dd5ef36d84acd1103e7e2aedf4c922ea10).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/23039
Merged to master. Thank you, @MaxGekk and @HyukjinKwon , @kiszk .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98927/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Moving truncatedString to sql/catalys...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Moving truncatedString to sql/catalys...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98841/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23039
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98915/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...
Posted by MaxGekk <gi...@git.apache.org>.
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23039
@gatorsmile @hvanhovell Could you look at the PR, please. I extracted a piece of changes from #22429.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org