You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2023/04/26 19:22:29 UTC

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19809


Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................

KUDU-1945 Update docs with non-unique PK

Added small update to cover non-unique primary key. For further info, I
added a link to the examples folder. Right now we only have the C++
example in place for non-unique PK, I plan to translate that example to
Java and Python as well.

Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
---
M docs/schema_design.adoc
1 file changed, 31 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/19809/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 2:

https://kudu.apache.org/faq.html#does-kudu-have-relational-features-like-autoincrement-column-pkfk-constraints-or-built-in-indexes

Also needs to be updated.

We need to put a note about restoring tables as well with auto incrementing column - it is not currently supported.


-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 01 May 2023 21:16:53 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19809/5/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/5/docs/administration.adoc@320
PS5, Line 320: NOTE: Restoring tables with non-unique primary keys is not supported currently.
nit:
non-unique primary keys/auto-incrementing columns


http://gerrit.cloudera.org:8080/#/c/19809/5/docs/schema_design.adoc
File docs/schema_design.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/5/docs/schema_design.adoc@289
PS5, Line 289: couner
nit: counter



-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 10 May 2023 16:31:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 09 May 2023 18:24:52 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc
File docs/schema_design.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@237
PS2, Line 237: an
> Sorry, 'an' is right, I think now.
Done


http://gerrit.cloudera.org:8080/#/c/19809/3/docs/schema_design.adoc
File docs/schema_design.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/3/docs/schema_design.adoc@265
PS3, Line 265: column
> nit: columns
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 09 May 2023 18:18:38 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 10 May 2023 17:42:34 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 6: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 10 May 2023 17:33:53 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 10 May 2023 15:36:20 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 3:

Please find the updated site here: https://martongreber.github.io/


-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 08 May 2023 17:15:56 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc
File docs/schema_design.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@237
PS2, Line 237: a 
> Done
I think "an" is correct, the first 'R' is a vowel sound "a:" ?


http://gerrit.cloudera.org:8080/#/c/19809/3/docs/schema_design.adoc
File docs/schema_design.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/3/docs/schema_design.adoc@265
PS3, Line 265: colums
nit: columns



-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 09 May 2023 03:47:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 2:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc
File docs/schema_design.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@265
PS2, Line 265: key
add a comma after key


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@268
PS2, Line 268: counter
counter which is used to assign value for auto-incrementing column


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@275
PS2, Line 275: may
can


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@277
PS2, Line 277: During inserts one has to speciy the non-unique primary key columns and the auto-incrementing
             : counter is populated on the server side.
For inserts, one has to provide values for the non-unique primary key columns without specifying the values for auto-incrementing column. The auto-incrementing column is populated on the server side automatically.


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@282
PS2, Line 282: 
please mention upsert operation is not supported for table with non-unique primary key.


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@285
PS2, Line 285: insert
insertion for auto-incrementing column.


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@288
PS2, Line 288: :
add space after :



-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 23:42:13 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19809

to look at the new patch set (#4).

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................

KUDU-1945 Update docs with non-unique PK

Added small update to cover non-unique primary key. For further info, I
added a link to the examples folder. Right now we only have the C++
example in place for non-unique PK, I plan to translate that example to
Java and Python as well.

Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
---
M docs/administration.adoc
M docs/schema_design.adoc
2 files changed, 38 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/19809/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 10 May 2023 15:11:24 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19809

to look at the new patch set (#3).

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................

KUDU-1945 Update docs with non-unique PK

Added small update to cover non-unique primary key. For further info, I
added a link to the examples folder. Right now we only have the C++
example in place for non-unique PK, I plan to translate that example to
Java and Python as well.

Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
---
M docs/administration.adoc
M docs/schema_design.adoc
2 files changed, 38 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/19809/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 2:

(13 comments)

> Patch Set 2:
> 
> https://kudu.apache.org/faq.html#does-kudu-have-relational-features-like-autoincrement-column-pkfk-constraints-or-built-in-indexes
> 
> Also needs to be updated.
> 
> We need to put a note about restoring tables as well with auto incrementing column - it is not currently supported.

I will create a separate patch to update the faq.md as that file lives not on kudu/master rather kudu/gh-pages.

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc
File docs/schema_design.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@237
PS2, Line 237: an
> nit: a
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@240
PS2, Line 240: key
> nit: keys
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@241
PS2, Line 241: key
> nit: keys
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@263
PS2, Line 263: uqnique
> nit: unique
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@265
PS2, Line 265: key
> add a comma after key
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@268
PS2, Line 268: counter
> counter which is used to assign value for auto-incrementing column
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@275
PS2, Line 275: incrementin
> nit: incrementing
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@275
PS2, Line 275: may
> can
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@277
PS2, Line 277: During inserts one has to speciy the non-unique primary key columns and the auto-incrementing
             : counter is populated on the server side.
> For inserts, one has to provide values for the non-unique primary key colum
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@282
PS2, Line 282: 
> please mention upsert operation is not supported for table with non-unique 
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@283
PS2, Line 283: uqnique
> nit: unique
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@285
PS2, Line 285: insert
> insertion for auto-incrementing column.
Done


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@288
PS2, Line 288: :
> add space after :
This is adoc syntax to create link. Can't add space, as that doesn't renders the link properly.
https://docs.asciidoctor.org/asciidoc/latest/macros/link-macro/



-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 08 May 2023 16:17:42 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19809

to look at the new patch set (#6).

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................

KUDU-1945 Update docs with non-unique PK

Added small update to cover non-unique primary key. For further info, I
added a link to the examples folder. Right now we only have the C++
example in place for non-unique PK, I plan to translate that example to
Java and Python as well.

Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
---
M docs/administration.adoc
M docs/schema_design.adoc
2 files changed, 40 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/19809/6
-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19809

to look at the new patch set (#2).

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................

KUDU-1945 Update docs with non-unique PK

Added small update to cover non-unique primary key. For further info, I
added a link to the examples folder. Right now we only have the C++
example in place for non-unique PK, I plan to translate that example to
Java and Python as well.

Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
---
M docs/schema_design.adoc
1 file changed, 31 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/19809/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc
File docs/schema_design.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@237
PS2, Line 237: an
nit: a


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@263
PS2, Line 263: uqnique
nit: unique


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@275
PS2, Line 275: incrementin
nit: incrementing


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@283
PS2, Line 283: uqnique
nit: unique



-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Apr 2023 02:59:42 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc
File docs/schema_design.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@237
PS2, Line 237: a 
> I think "an" is correct, the first 'R' is a vowel sound "a:" ?
Sorry, 'an' is right, I think now.



-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 09 May 2023 08:38:19 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 5:

https://martongreber.github.io/docs/schema_design.html#non-unique_primary_keys
Added index.


-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 10 May 2023 15:58:49 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................

KUDU-1945 Update docs with non-unique PK

Added small update to cover non-unique primary key. For further info, I
added a link to the examples folder. Right now we only have the C++
example in place for non-unique PK, I plan to translate that example to
Java and Python as well.

Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Reviewed-on: http://gerrit.cloudera.org:8080/19809
Tested-by: Kudu Jenkins
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M docs/administration.adoc
M docs/schema_design.adoc
2 files changed, 40 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Wenzhe Zhou: Looks good to me, but someone else must approve
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 7
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19809/5/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/5/docs/administration.adoc@320
PS5, Line 320: NOTE: Restoring tables with non-unique primary keys/auto-incrementing columns is
> nit:
Done


http://gerrit.cloudera.org:8080/#/c/19809/5/docs/schema_design.adoc
File docs/schema_design.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/5/docs/schema_design.adoc@289
PS5, Line 289: counte
> nit: counter
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 10 May 2023 16:43:35 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Removed Code-Review+2 by Yingchun Lai <la...@apache.org>
-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 08 May 2023 21:19:38 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yuqi Du, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19809

to look at the new patch set (#5).

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................

KUDU-1945 Update docs with non-unique PK

Added small update to cover non-unique primary key. For further info, I
added a link to the examples folder. Right now we only have the C++
example in place for non-unique PK, I plan to translate that example to
Java and Python as well.

Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
---
M docs/administration.adoc
M docs/schema_design.adoc
2 files changed, 39 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/19809/5
-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc
File docs/schema_design.adoc:

http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@240
PS2, Line 240: key
nit: keys


http://gerrit.cloudera.org:8080/#/c/19809/2/docs/schema_design.adoc@241
PS2, Line 241: key
nit: keys



-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 08 May 2023 03:30:13 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1945 Update docs with non-unique PK

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 )

Change subject: KUDU-1945 Update docs with non-unique PK
......................................................................


Patch Set 2:

You can preview the changes under: https://martongreber.github.io/docs/schema_design.html#primary-keys


-- 
To view, visit http://gerrit.cloudera.org:8080/19809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84e1c6b85d4fdb5ac95bad611246c071a63bcd31
Gerrit-Change-Number: 19809
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 19:26:01 +0000
Gerrit-HasComments: No