You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/05 12:59:25 UTC

[GitHub] [flink] cmick opened a new pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

cmick opened a new pull request #16378:
URL: https://github.com/apache/flink/pull/16378


   This is a backport of #16333 (fixing FLINK-23182) to release-1.12. The fix is exactly the same as in #16333, just the unit tests had to be slightly adjusted. There is no `assertThrows` in junit 4.12, so an ExpectedException junit rule have been used instead (the logic remained the same though).
   
   Please see #16333 for a detailed description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16378:
URL: https://github.com/apache/flink/pull/16378#issuecomment-874121463


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "423bb06676e53788d3f12f523d510242ce82196a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19931",
       "triggerID" : "423bb06676e53788d3f12f523d510242ce82196a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0909ec160d8f7dbd48b1924587a31cf418b87bf1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19938",
       "triggerID" : "0909ec160d8f7dbd48b1924587a31cf418b87bf1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 423bb06676e53788d3f12f523d510242ce82196a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19931) 
   * 0909ec160d8f7dbd48b1924587a31cf418b87bf1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19938) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] AHeise merged pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #16378:
URL: https://github.com/apache/flink/pull/16378


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16378:
URL: https://github.com/apache/flink/pull/16378#issuecomment-874121463






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16378:
URL: https://github.com/apache/flink/pull/16378#issuecomment-874096098


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0909ec160d8f7dbd48b1924587a31cf418b87bf1 (Thu Sep 23 17:58:34 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16378:
URL: https://github.com/apache/flink/pull/16378#issuecomment-874121463


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "423bb06676e53788d3f12f523d510242ce82196a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19931",
       "triggerID" : "423bb06676e53788d3f12f523d510242ce82196a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 423bb06676e53788d3f12f523d510242ce82196a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19931) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16378:
URL: https://github.com/apache/flink/pull/16378#issuecomment-874121463


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "423bb06676e53788d3f12f523d510242ce82196a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19931",
       "triggerID" : "423bb06676e53788d3f12f523d510242ce82196a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0909ec160d8f7dbd48b1924587a31cf418b87bf1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0909ec160d8f7dbd48b1924587a31cf418b87bf1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 423bb06676e53788d3f12f523d510242ce82196a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19931) 
   * 0909ec160d8f7dbd48b1924587a31cf418b87bf1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16378:
URL: https://github.com/apache/flink/pull/16378#issuecomment-874121463


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "423bb06676e53788d3f12f523d510242ce82196a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19931",
       "triggerID" : "423bb06676e53788d3f12f523d510242ce82196a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0909ec160d8f7dbd48b1924587a31cf418b87bf1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19938",
       "triggerID" : "0909ec160d8f7dbd48b1924587a31cf418b87bf1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0909ec160d8f7dbd48b1924587a31cf418b87bf1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19938) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16378:
URL: https://github.com/apache/flink/pull/16378#issuecomment-874121463


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "423bb06676e53788d3f12f523d510242ce82196a",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19931",
       "triggerID" : "423bb06676e53788d3f12f523d510242ce82196a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0909ec160d8f7dbd48b1924587a31cf418b87bf1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19938",
       "triggerID" : "0909ec160d8f7dbd48b1924587a31cf418b87bf1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 423bb06676e53788d3f12f523d510242ce82196a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19931) 
   * 0909ec160d8f7dbd48b1924587a31cf418b87bf1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19938) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16378:
URL: https://github.com/apache/flink/pull/16378#issuecomment-874096098


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 423bb06676e53788d3f12f523d510242ce82196a (Mon Jul 05 13:03:33 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16378:
URL: https://github.com/apache/flink/pull/16378#issuecomment-874096098






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #16378: [BP-1.12][FLINK-23182][connectors/rabbitmq] Fix connection leak in RMQSource

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16378:
URL: https://github.com/apache/flink/pull/16378#issuecomment-874121463


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "423bb06676e53788d3f12f523d510242ce82196a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "423bb06676e53788d3f12f523d510242ce82196a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 423bb06676e53788d3f12f523d510242ce82196a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org