You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/06/17 16:13:01 UTC
[GitHub] [incubator-mxnet] eric-haibin-lin opened a new pull request #18579: [WIP] switch to cached op in the testing suite
eric-haibin-lin opened a new pull request #18579:
URL: https://github.com/apache/incubator-mxnet/pull/18579
## Description ##
This is one of a series of PRs that removes graph executor for better maintenance of MXNet execution backend. The graph executor will be still maintained in mxnet 1.x. Also, disabled two tests that failed with cached op:
- https://github.com/apache/incubator-mxnet/issues/13193
- https://github.com/apache/incubator-mxnet/issues/18575
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18579: [WIP] switch to cached op in the testing suite
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18579:
URL: https://github.com/apache/incubator-mxnet/pull/18579#issuecomment-645470867
Hey @eric-haibin-lin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [miscellaneous, centos-cpu, unix-gpu, edge, windows-gpu, clang, website, sanity, windows-cpu, centos-gpu, unix-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on pull request #18579: Switch to cached op in the testing suite
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on pull request #18579:
URL: https://github.com/apache/incubator-mxnet/pull/18579#issuecomment-646895501
Does that mean we are dropping Perl support?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18579: Switch to cached op in the testing suite
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18579:
URL: https://github.com/apache/incubator-mxnet/pull/18579#issuecomment-646897637
@marcoabreu as described in #17676, the language bindings are expected to move together with this change as initiated by the maintainers of those language bindings. For the specific case of Perl, it makes more sense to convert the new Gluon API in 2.0 again with SWIG (@sergeykolychev may have more comments)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #18579: Switch to cached op in the testing suite
Posted by GitBox <gi...@apache.org>.
szha merged pull request #18579:
URL: https://github.com/apache/incubator-mxnet/pull/18579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org