[superset] branch master updated: chore: add test for SPA explore endpoints around missing datasets (#21303)

[hu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 14cd8a2160 chore: add test for SPA explore endpoints around missing datasets (#21303)
14cd8a2160 is described below

commit 14cd8a2160f02884fefbb89717707a7eca50b703
Author: Hugh A. Miles II <hu...@gmail.com>
AuthorDate: Fri Sep 9 10:54:39 2022 -0700

    chore: add test for SPA explore endpoints around missing datasets (#21303)
---
 tests/unit_tests/datasource/dao_tests.py | 12 ++++++++++++
 tests/unit_tests/explore/api_test.py     | 30 ++++++++++++++++++++++++++++++
 2 files changed, 42 insertions(+)

diff --git a/tests/unit_tests/datasource/dao_tests.py b/tests/unit_tests/datasource/dao_tests.py
index 8647f97f74..cb313b3dd7 100644
--- a/tests/unit_tests/datasource/dao_tests.py
+++ b/tests/unit_tests/datasource/dao_tests.py
@@ -202,3 +202,15 @@ def test_get_all_datasources(session_with_data: Session) -> None:
 
     result = SqlaTable.get_all_datasources(session=session_with_data)
     assert len(result) == 1
+
+
+def test_not_found_datasource(session_with_data: Session) -> None:
+    from superset.dao.exceptions import DatasourceNotFound
+    from superset.datasource.dao import DatasourceDAO
+
+    with pytest.raises(DatasourceNotFound):
+        DatasourceDAO.get_datasource(
+            datasource_type="table",
+            datasource_id=500000,
+            session=session_with_data,
+        )
diff --git a/tests/unit_tests/explore/api_test.py b/tests/unit_tests/explore/api_test.py
new file mode 100644
index 0000000000..7f6d8ee2b2
--- /dev/null
+++ b/tests/unit_tests/explore/api_test.py
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from typing import Any
+
+import pytest
+
+
+def test_explore_datasource_not_found(client: Any, full_api_access: None) -> None:
+    # validating the payload for a dataset that doesn't exist
+    # user should be expecting missing_datasource view
+    response = client.get(
+        "/api/v1/explore/?dataset_id=50000&dataset_type=table",
+    )
+    response.json["result"]["dataset"]["name"] == "[Missing Dataset]"
+    assert response.status_code == 200