[GitHub] [airflow] ashb commented on a change in pull request #17324: Improve `dag_maker` fixture

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #17324:
URL: https://github.com/apache/airflow/pull/17324#discussion_r681605562



##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -715,6 +699,8 @@ def test_fast_follow(
                 for upstream, downstream in dependencies.items():
                     dag.set_dependency(upstream, downstream)
 
+            dag_maker.make_dagmodel()

Review comment:
       This shouldn't have to be called -- I think we should _always_ create the DagModel, as my high-level goal with asking for this fixture is to make tests more representative of _How_ Airflow is when running, specifically that the SerializedDag and DagModel rows are always present for a DAG.
   
   And in the _rare_ cases where we don't want either of these we could then delete them in the tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org