You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by jkff <gi...@git.apache.org> on 2017/04/29 00:59:24 UTC
[GitHub] beam pull request #2774: [BEAM-1402] Makes TextIO comply with PTransform sty...
GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/2774
[BEAM-1402] Makes TextIO comply with PTransform style guide
Migration guide: TextIO.Read.from() -> TextIO.read().from; TextIO.Write.to() -> TextIO.write().to()
Also converts both to AutoValue and moves some utility classes to upper level to declutter TextIO.java.
Each individual commit should be trivial to review.
R: @reuvenlax
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam text-style
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2774.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2774
----
commit 2421f80eb46525d18ffa4af1dd0dc398db278b61
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:14:29Z
Removes leftover no-op withoutValidation methods
commit 98526274d69ed4665f34108b46e678ecf850b561
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:06:46Z
Removes TextIO.Read.Bound
commit cb18481b034f1b47f47e6f749b73c4395cb9684d
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:16:14Z
Converts TextIO.Read to AutoValue
commit ed28a1e8a3eca34ddc278b2facbef61cf3dd37f5
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:28:06Z
Removes TextIO.Write.Bound
commit 51208cd05f0cbf43776772092909da2afaafb1d8
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:39:01Z
Converts TextIO.Write to AutoValue
commit e5eb565522885b7dae78d45db0cdd4a447cfb14f
Author: Eugene Kirpichov <ki...@google.com>
Date: 2017-04-29T00:46:44Z
Moves TextSource and TextSink to top level
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2774: [BEAM-1402] Makes TextIO comply with PTransform sty...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2774
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---