You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/16 07:48:50 UTC

[GitHub] [apisix-ingress-controller] tokers edited a comment on pull request #102: fix: set base url to seven module

tokers edited a comment on pull request #102:
URL: https://github.com/apache/apisix-ingress-controller/pull/102#issuecomment-745853609


   > We can add a test case about `baseUrl`.
   
   We can only add very shallow test cases like checking the value is really set to conf.BaseUrl.
   
   We cannot test it in other cases like testing APISIXRoute, APISIXUpstream or others, since all of them are lack.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org