[jira] [Commented] (FELIX-3517) Use of internal Logger seems not worth it

["Richard S. Hall (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280361#comment-13280361 ] 

Richard S. Hall commented on FELIX-3517:
----------------------------------------

Overall, it is not worth it to have an abstraction for only this purpose, no. In the framework, the logger abstraction is used throughout.

However, the particular place in the resolver where this is being used does provide invaluable information, since it is logging all failed permutation and the reason they failed when DEBUG logging is enabled.

So, in short, I don't think we should eliminate that, although we could eliminate the abstraction and just print to stdout, but at the same time it makes it more difficult to integrate into things like the Felix framework that do have a logger for this sort of stuff.
                
> Use of internal Logger seems not worth it
> -----------------------------------------
>
>                 Key: FELIX-3517
>                 URL: https://issues.apache.org/jira/browse/FELIX-3517
>             Project: Felix
>          Issue Type: Bug
>          Components: Resolver
>         Environment: All
>            Reporter: Thomas Watson
>
> This may be a point in time issue, but the use of the internal logger (org.apache.felix.resolver.Logger) seems a bit overboard since it is only used in one place in the method org.apache.felix.resolver.ResolverImpl.checkPackageSpaceConsistency
> Should we be adding more usages of this logger for debugging or is it really intended to be used to debug class space consistency issues?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira