You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2020/11/26 03:23:00 UTC

[jira] [Commented] (HBASE-25333) Add a yetus check to disable usage of VisibleForTesting annotation on IA.Public and IA.LimitedPrivate classes

    [ https://issues.apache.org/jira/browse/HBASE-25333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239045#comment-17239045 ] 

Duo Zhang commented on HBASE-25333:
-----------------------------------

This is a shell script which could be used to filter out the files with both IA.Public or IA.LimitedPrivate and VisibleForTesting annotation.

{code}
find . -type f -name *.java | grep -v generated | xargs grep -l "@InterfaceAudience.Public\|@InterfaceAudience.LimitedPrivate" | xargs grep -l @VisibleForTesting
{code}

Let me see how to integrate this with yetus pre commit check and also the nightly build.

> Add a yetus check to disable usage of VisibleForTesting annotation on IA.Public and IA.LimitedPrivate classes
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-25333
>                 URL: https://issues.apache.org/jira/browse/HBASE-25333
>             Project: HBase
>          Issue Type: Task
>          Components: build
>            Reporter: Duo Zhang
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)