[GitHub] spark pull request #16441: [SPARK-14975][ML][WIP] Fixed GBTClassifier to pre...

[sethah <gi...@git.apache.org>]

Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16441#discussion_r94861988
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala ---
    @@ -66,10 +66,39 @@ class GBTClassifierSuite extends SparkFunSuite with MLlibTestSparkContext
         ParamsSuite.checkParams(new GBTClassifier)
         val model = new GBTClassificationModel("gbtc",
           Array(new DecisionTreeRegressionModel("dtr", new LeafNode(0.0, 0.0, null), 1)),
    -      Array(1.0), 1)
    +      Array(1.0), 1, 2)
         ParamsSuite.checkParams(model)
       }
     
    +  test("Verify raw scores correspond to labels") {
    +    val rawPredictionCol = "MyRawPrediction"
    --- End diff --
    
    Just use defaults here. And I'm in favor of only setting parameters that matter for the given test, otherwise it may give the impression that the test depends on a certain, say checkpoint interval.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org