[jira] [Comment Edited] (ARROW-14458) [R] Use expect_snapshot() to improve tests in dplyr funcs strings

["Dragoș Moldovan-Grünfeld (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-14458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433643#comment-17433643 ] 

Dragoș Moldovan-Grünfeld edited comment on ARROW-14458 at 1/20/22, 10:26 AM:
-----------------------------------------------------------------------------

I think we should definitely use {{expect_snapshot()}} for the tests where we are providing the error message to compare to / check against. Not sure it's relevant to swap for every instance of {{expect_error()}} at this stage. We could extend if we want to keep an eye on the messages accompanying the errors.


was (Author: dragosmg):
I think we should definitely user {{expect_snapshot()}} for the tests where we are providing the error message to compare to / check against. Not sure it's relevant to swap for every instance of {{expect_error()}} at this stage. We could extend if we want to keep an eye on the messages accompanying the errors.   

> [R] Use expect_snapshot() to improve tests in dplyr funcs strings
> -----------------------------------------------------------------
>
>                 Key: ARROW-14458
>                 URL: https://issues.apache.org/jira/browse/ARROW-14458
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Dragoș Moldovan-Grünfeld
>            Assignee: Dragoș Moldovan-Grünfeld
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 8.0.0
>
>          Time Spent: 8h
>  Remaining Estimate: 0h
>
> This comes from [Romain's suggestion|https://github.com/apache/arrow/pull/11502/files/2a8a139b727acb13019da6176444578ead6bf208#r735351673] to transform the test that rely on capturing a string by using a snapshot test (added in {{testthat}}'s 3rd edition). 
> A test like:
> {code:r}
> expect_error(expression, message)
> {code}
> becomes
> {code:r}
> expect_snapshot({
>   (expect_error(expression))
> })
> {code}
> This is probably a more general improvement we can make to our unit tests (i.e. to make more extensive use of the snapshot functionality), but I thought I'd focus on one test file to begin with.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)