You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org> on 2007/09/20 09:38:31 UTC

[jira] Created: (TRINIDAD-727) funny issue with form and defaultCommand (in IE)

funny issue with form and defaultCommand (in IE)
------------------------------------------------

                 Key: TRINIDAD-727
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-727
             Project: MyFaces Trinidad
          Issue Type: Bug
            Reporter: Matthias Weßendorf
            Assignee: Matthias Weßendorf


I noticed this funny thing with form's defaultCommand and
IE7 (true for IE 6 as well ??)

here is a demo, that has a form, containing a defaultCommand

http://www.irian.at/trinidad-demo/faces/components/form.jspx

Do the following:
-enter first value
-enter second value AND! hit enter.

=> Notice that the button label changes to the ID of the button :-)

(sure, FF it works as expected ;-))

the source-code is:
<tr:form defaultCommand="first" binding="#{editor.component}">
...
 <tr:inputText label="First form, First Field:" shortDesc="Field 1" />
 <tr:inputText label="First form, Second Field:" shortDesc="Field 2" />
 <tr:commandButton id="first" text="First" />
...
</tr:form>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-727) funny issue with form and defaultCommand (in IE)

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529010 ] 

Matthias Weßendorf commented on TRINIDAD-727:
---------------------------------------------

>From Adam Winer:

OK, so looks like the issue is that for this submit,
we have:

       var params = new Object();
       params[src] = src;
       params['source'] = src;

       submitForm(frm,0,params);

We set params['source'] = src; to handle Trinidad buttons.
We set params[src] = src; to handle non-Trinidad buttons.

Then submitForm() has (with a lot of non-taken branches
snipped):

           var hiddenField = form.elements[paramName];

            if (hiddenField.type == 'submit')
              // create an input type="hidden"
            else
                 hiddenField.value = paramValue;

I think we need to add a checkt to submitForm() that hiddenField is
not a button element too!

> funny issue with form and defaultCommand (in IE)
> ------------------------------------------------
>
>                 Key: TRINIDAD-727
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-727
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>            Reporter: Matthias Weßendorf
>            Assignee: Matthias Weßendorf
>
> I noticed this funny thing with form's defaultCommand and
> IE7 (true for IE 6 as well ??)
> here is a demo, that has a form, containing a defaultCommand
> http://www.irian.at/trinidad-demo/faces/components/form.jspx
> Do the following:
> -enter first value
> -enter second value AND! hit enter.
> => Notice that the button label changes to the ID of the button :-)
> (sure, FF it works as expected ;-))
> the source-code is:
> <tr:form defaultCommand="first" binding="#{editor.component}">
> ...
>  <tr:inputText label="First form, First Field:" shortDesc="Field 1" />
>  <tr:inputText label="First form, Second Field:" shortDesc="Field 2" />
>  <tr:commandButton id="first" text="First" />
> ...
> </tr:form>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TRINIDAD-727) funny issue with form and defaultCommand (in IE)

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf resolved TRINIDAD-727.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.3-core

> funny issue with form and defaultCommand (in IE)
> ------------------------------------------------
>
>                 Key: TRINIDAD-727
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-727
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>            Reporter: Matthias Weßendorf
>            Assignee: Matthias Weßendorf
>             Fix For: 1.0.3-core
>
>
> I noticed this funny thing with form's defaultCommand and
> IE7 (true for IE 6 as well ??)
> here is a demo, that has a form, containing a defaultCommand
> http://www.irian.at/trinidad-demo/faces/components/form.jspx
> Do the following:
> -enter first value
> -enter second value AND! hit enter.
> => Notice that the button label changes to the ID of the button :-)
> (sure, FF it works as expected ;-))
> the source-code is:
> <tr:form defaultCommand="first" binding="#{editor.component}">
> ...
>  <tr:inputText label="First form, First Field:" shortDesc="Field 1" />
>  <tr:inputText label="First form, Second Field:" shortDesc="Field 2" />
>  <tr:commandButton id="first" text="First" />
> ...
> </tr:form>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-727) funny issue with form and defaultCommand (in IE)

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529009 ] 

Matthias Weßendorf commented on TRINIDAD-727:
---------------------------------------------

reason is this

<script>

function changeValue(element)
{
 element.value = element.id;
}


</script>

<button id="foo" onclick="changeValue(this);">bar</button>

in FF, never the button-text is changed.

> funny issue with form and defaultCommand (in IE)
> ------------------------------------------------
>
>                 Key: TRINIDAD-727
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-727
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>            Reporter: Matthias Weßendorf
>            Assignee: Matthias Weßendorf
>
> I noticed this funny thing with form's defaultCommand and
> IE7 (true for IE 6 as well ??)
> here is a demo, that has a form, containing a defaultCommand
> http://www.irian.at/trinidad-demo/faces/components/form.jspx
> Do the following:
> -enter first value
> -enter second value AND! hit enter.
> => Notice that the button label changes to the ID of the button :-)
> (sure, FF it works as expected ;-))
> the source-code is:
> <tr:form defaultCommand="first" binding="#{editor.component}">
> ...
>  <tr:inputText label="First form, First Field:" shortDesc="Field 1" />
>  <tr:inputText label="First form, Second Field:" shortDesc="Field 2" />
>  <tr:commandButton id="first" text="First" />
> ...
> </tr:form>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.