You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/03/07 07:04:57 UTC
[GitHub] carbondata pull request #2037: [CARBONDATA-2232][DataLoad] Fix incorrect log...
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2037
[CARBONDATA-2232][DataLoad] Fix incorrect logic in spilling unsafe pages to disk
The unsafe row page will only be written to disk if the memory is
unavailable -- the previous logic just reversed it.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 0307_bug_unsafe_sort_savedisk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2037
----
commit 87853683e71b6a2f39d4239d9a2e3f396a375033
Author: xuchuanyin <xu...@...>
Date: 2018-03-07T06:55:51Z
Fix bugs in unsafe row page
The unsafe row page will only be written to disk is the memory is
unavailable -- the previous logic just reversed it.
----
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2037
This is only bug fix for the previous code. It mainly affects the batch_sort data loading performance.
It is designed to hold all the pages in memory if possible and only spill the incoming pages if memory is unavailable. Due to the bug, the logic is reversed.
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2037
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4142/
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2037
when will this pr be merged? and will it be merged into branch-1.3?
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2037
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4114/
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2037
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3803/
---
[GitHub] carbondata pull request #2037: [CARBONDATA-2232][DataLoad] Fix incorrect log...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2037
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2037
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3805/
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2037
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4115/
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2037
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2898/
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2037
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2870/
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2037
LGTM
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2037
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4117/
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2037
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2872/
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2037
retest this please
---
[GitHub] carbondata pull request #2037: [CARBONDATA-2232][DataLoad] Fix incorrect log...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2037#discussion_r172756248
--- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/UnsafeSortDataRows.java ---
@@ -192,14 +196,7 @@ private void addBatch(Object[][] rowBatch, int size) throws CarbonSortKeyAndGrou
unsafeInMemoryIntermediateFileMerger.startFileMergingIfPossible();
semaphore.acquire();
dataSorterAndWriterExecutorService.execute(new DataSorterAndWriter(rowPage));
- MemoryBlock memoryBlock =
- UnsafeMemoryManager.allocateMemoryWithRetry(this.taskId, inMemoryChunkSize);
- boolean saveToDisk =
--- End diff --
FYI:
Previous logic is wrong here.
---
[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2037
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2869/
---