You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/06/07 15:41:30 UTC

[GitHub] [drill] jnturton commented on a diff in pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

jnturton commented on code in PR #2568:
URL: https://github.com/apache/drill/pull/2568#discussion_r891124891


##########
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java:
##########
@@ -46,7 +51,9 @@ public class ProjectRecordBatch extends AbstractSingleRecordBatch<Project> {
   private static final Logger logger = LoggerFactory.getLogger(ProjectRecordBatch.class);
 
   protected List<ValueVector> allocationVectors;
+  @Deprecated // use new writer rsLoader

Review Comment:
   Just checking that I understand here: it's still possible for UDFs like `convert_fromJSON` to use org.apache.drill.exec.vector.complex.fn.JsonReader because it is only deprecated, not removed? But we could convert those in future too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org